All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Joel Stanley <joel@jms.id.au>
Cc: Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/gcc: Disable uclibc for powerpc64 and powerpc64le
Date: Thu, 5 May 2022 21:55:31 +0200	[thread overview]
Message-ID: <20220505195531.GA2547@scaer> (raw)
In-Reply-To: <20220505100956.155737-1-joel@jms.id.au>

Joel, All,

On 2022-05-05 19:39 +0930, Joel Stanley spake thusly:
> uClibc-ng does not (and has never) supported the 64 bit powerpc
> architecture.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> I'm a bit confused as to why uclibc was ever an option. Perhaps I missed
> something! I did a search of the mailing list archive and the best I
> found was this post from Thomas:
> 
>  https://lore.kernel.org/buildroot/20160817193721.0cc1466d@free-electrons.com/
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  package/gcc/Config.in.host | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
> index a1fe192d3a24..3364860ec7a4 100644
> --- a/package/gcc/Config.in.host
> +++ b/package/gcc/Config.in.host
> @@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X
>  	# upstream gcc. C-SKY gcc upstream support not tested
>  	# with upstream binutils and glibc.
>  	depends on !BR2_csky
> +	# 64 bit powerpc is not supported by uclibc
> +	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_powerpc64 || BR2_powerpc64le))

This is not the proper place to put this limitation. Instead, it should
be added to toolchain/toolchain-buildroot/Config.in so that uClibc is
not ever selectable for powerpc64.

Except this is already the case:

   28 config BR2_TOOLCHAIN_BUILDROOT_UCLIBC
   29     bool "uClibc-ng"
   30     depends on BR2_aarch64 || BR2_aarch64_be || BR2_arcle   || BR2_arceb  || \
   31            BR2_arm     || BR2_armeb    || \
   32            BR2_i386    || BR2_m68k   || BR2_microblaze || \
   33            BR2_mips    || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
   34            BR2_or1k    || BR2_powerpc || BR2_RISCV_64 || \
   35            BR2_sh4     || BR2_sh4eb   || BR2_sparc || BR2_xtensa || \
   36            BR2_x86_64

And indeed, when I enable either BR2_powerpc64 or BR2_powerpc64le, then
uclibc-ng is not selectable in the C library choice...

So now I am confused. Could you explain why you had to hide away the gcc
versions when uclibc-ng is selected? And how you even managed to select
uClibc-ng with powerpc64 to begine with? Can you share a defconfig that
exhibits the issue?

Regards,
Yann E. MORIN.

>  	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
>  
>  config BR2_GCC_VERSION_10_X
> @@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X
>  	# upstream gcc. C-SKY gcc upstream support not tested
>  	# with upstream binutils and glibc.
>  	depends on !BR2_csky
> +	# 64 bit powerpc is not supported by uclibc
> +	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_powerpc64 || BR2_powerpc64le))
>  	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
>  
>  config BR2_GCC_VERSION_11_X
> @@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X
>  	# that need to be reverted since gcc 8.4, 9.3 and 10.1.
>  	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
>  	depends on !BR2_sparc
> +	# 64 bit powerpc is not supported by uclibc
> +	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_powerpc64 || BR2_powerpc64le))
>  	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
>  
>  endchoice
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-05-05 19:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 10:09 [Buildroot] [PATCH] package/gcc: Disable uclibc for powerpc64 and powerpc64le Joel Stanley
2022-05-05 19:45 ` Arnout Vandecappelle
2022-05-05 19:55 ` Yann E. MORIN [this message]
2022-05-09  7:59   ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505195531.GA2547@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=joel@jms.id.au \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.