From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Wang Cheng <wanngchenng@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8() and friends
Date: Fri, 6 May 2022 10:57:18 +0300 [thread overview]
Message-ID: <20220506075718.GE4009@kadam> (raw)
In-Reply-To: <7dad295f-2ac4-d6ff-8d8a-17db8ef18c12@gmail.com>
On Fri, May 06, 2022 at 10:23:39AM +0300, Pavel Skripkin wrote:
> Hi Wang,
>
> On 5/6/22 06:15, Wang Cheng wrote:
> > When r8712_usbctrl_vendorreq() returns negative, 'data' in
> > usb_read{8,16,32} will not be initialized.
>
> [code snip]
>
> > + status = r8712_usbctrl_vendorreq(intfpriv, request, wvalue, index,
> > + &data, len, requesttype);
> > + if (status < 0)
> > + return 0;
> > return le32_to_cpu(data);
> > }
>
> Why do you believe that 0 is not valid register value? And if it's possible
> then how you can identify an error?
I think you are getting data and status mixed up?
regards,
dan carpenter
next prev parent reply other threads:[~2022-05-06 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 3:13 [PATCH v2 0/2] staging: rtl8712: fix uninit-value 'data' and 'mac' Wang Cheng
2022-05-06 3:15 ` [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8() and friends Wang Cheng
2022-05-06 7:10 ` Dan Carpenter
2022-05-06 11:22 ` Wang Cheng
2022-05-06 7:23 ` Pavel Skripkin
2022-05-06 7:57 ` Dan Carpenter [this message]
2022-05-06 3:16 ` [PATCH v2 2/2] staging: rtl8712: fix uninit-value in r871xu_drv_init() Wang Cheng
2022-05-06 7:41 ` Pavel Skripkin
2022-05-06 11:33 ` Wang Cheng
2022-05-06 11:56 ` Wang Cheng
2022-05-06 12:02 ` Pavel Skripkin
2022-05-09 4:03 ` Wang Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506075718.GE4009@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=wanngchenng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.