From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3E462A for ; Fri, 6 May 2022 01:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651802119; x=1683338119; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VYh3t/xp0DZMnprLcLN9Qaa20uH8rVTUofBzr82Uzts=; b=JpwAtfCHU6LUrKxRusDB1x4I7MQBpiiMZHviYtoJ8UL+s9PalVN6ovFm G4FU1es28SlEm9rKrm8QfBBv8BDDmzT6O3oGt6Sw5eE0ui3mnWEdOPV+3 gXiGZF80OWdFancrKG7jdLDKqlV94WwAFluWB5mnSygeQqWezuhgRe4yt Bv8RRPcKyrAfFVUandI8kCCFL3DD6F8FA4lonqohlZcENJAl/WKI9pEln cyWIc56pVPdGLJ45cuxztVqPC9hnSyb5UpUedBGvyuvHfWFwgk4fq7yFa C4tH8MLbkIdu8R2AcUv6TJtBfD+hb8+pX1u8dHTa5CvQ0wk++ULWb4l53 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="293522464" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="293522464" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:55:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="517802313" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 05 May 2022 18:55:15 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nmnBb-000CxX-6L; Fri, 06 May 2022 01:55:15 +0000 Date: Fri, 6 May 2022 09:54:34 +0800 From: kernel test robot To: Robert Hancock , netdev@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, radhey.shyam.pandey@xilinx.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, Robert Hancock Subject: Re: [PATCH net-next v3] net: axienet: Use NAPI for TX completion path Message-ID: <202205060910.pO104P2e-lkp@intel.com> References: <20220505203754.1905881-1-robert.hancock@calian.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505203754.1905881-1-robert.hancock@calian.com> Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Robert-Hancock/net-axienet-Use-NAPI-for-TX-completion-path/20220506-043932 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1c1ed5a48411e1686997157c21633653fbe045c6 config: x86_64-randconfig-c007 (https://download.01.org/0day-ci/archive/20220506/202205060910.pO104P2e-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/89eb9e692229a3af81eaf2f599781bfae3091e93 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Robert-Hancock/net-axienet-Use-NAPI-for-TX-completion-path/20220506-043932 git checkout 89eb9e692229a3af81eaf2f599781bfae3091e93 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/xilinx/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:765: warning: expecting prototype for axienet_start_xmit_done(). Prototype was for axienet_tx_poll() instead vim +765 drivers/net/ethernet/xilinx/xilinx_axienet_main.c bb193e3db8b86a Robert Hancock 2022-01-18 749 ab365c3393664f Andre Przywara 2020-03-24 750 /** ab365c3393664f Andre Przywara 2020-03-24 751 * axienet_start_xmit_done - Invoked once a transmit is completed by the ab365c3393664f Andre Przywara 2020-03-24 752 * Axi DMA Tx channel. 89eb9e692229a3 Robert Hancock 2022-05-05 753 * @napi: Pointer to NAPI structure. 89eb9e692229a3 Robert Hancock 2022-05-05 754 * @budget: Max number of TX packets to process. 89eb9e692229a3 Robert Hancock 2022-05-05 755 * 89eb9e692229a3 Robert Hancock 2022-05-05 756 * Return: Number of TX packets processed. ab365c3393664f Andre Przywara 2020-03-24 757 * 89eb9e692229a3 Robert Hancock 2022-05-05 758 * This function is invoked from the NAPI processing to notify the completion ab365c3393664f Andre Przywara 2020-03-24 759 * of transmit operation. It clears fields in the corresponding Tx BDs and ab365c3393664f Andre Przywara 2020-03-24 760 * unmaps the corresponding buffer so that CPU can regain ownership of the ab365c3393664f Andre Przywara 2020-03-24 761 * buffer. It finally invokes "netif_wake_queue" to restart transmission if ab365c3393664f Andre Przywara 2020-03-24 762 * required. ab365c3393664f Andre Przywara 2020-03-24 763 */ 89eb9e692229a3 Robert Hancock 2022-05-05 764 static int axienet_tx_poll(struct napi_struct *napi, int budget) ab365c3393664f Andre Przywara 2020-03-24 @765 { 89eb9e692229a3 Robert Hancock 2022-05-05 766 struct axienet_local *lp = container_of(napi, struct axienet_local, napi_tx); 89eb9e692229a3 Robert Hancock 2022-05-05 767 struct net_device *ndev = lp->ndev; ab365c3393664f Andre Przywara 2020-03-24 768 u32 size = 0; 89eb9e692229a3 Robert Hancock 2022-05-05 769 int packets; ab365c3393664f Andre Przywara 2020-03-24 770 89eb9e692229a3 Robert Hancock 2022-05-05 771 packets = axienet_free_tx_chain(lp, lp->tx_bd_ci, budget, false, &size, budget); ab365c3393664f Andre Przywara 2020-03-24 772 89eb9e692229a3 Robert Hancock 2022-05-05 773 if (packets) { ab365c3393664f Andre Przywara 2020-03-24 774 lp->tx_bd_ci += packets; ab365c3393664f Andre Przywara 2020-03-24 775 if (lp->tx_bd_ci >= lp->tx_bd_num) 89eb9e692229a3 Robert Hancock 2022-05-05 776 lp->tx_bd_ci %= lp->tx_bd_num; ab365c3393664f Andre Przywara 2020-03-24 777 8a3b7a252dca9f Daniel Borkmann 2012-01-19 778 ndev->stats.tx_packets += packets; 8a3b7a252dca9f Daniel Borkmann 2012-01-19 779 ndev->stats.tx_bytes += size; 7de44285c1f69c Robert Hancock 2019-06-06 780 7de44285c1f69c Robert Hancock 2019-06-06 781 /* Matches barrier in axienet_start_xmit */ 7de44285c1f69c Robert Hancock 2019-06-06 782 smp_mb(); 7de44285c1f69c Robert Hancock 2019-06-06 783 bb193e3db8b86a Robert Hancock 2022-01-18 784 if (!axienet_check_tx_bd_space(lp, MAX_SKB_FRAGS + 1)) 8a3b7a252dca9f Daniel Borkmann 2012-01-19 785 netif_wake_queue(ndev); 8a3b7a252dca9f Daniel Borkmann 2012-01-19 786 } 8a3b7a252dca9f Daniel Borkmann 2012-01-19 787 89eb9e692229a3 Robert Hancock 2022-05-05 788 if (packets < budget && napi_complete_done(napi, packets)) { 89eb9e692229a3 Robert Hancock 2022-05-05 789 /* Re-enable TX completion interrupts. This should 89eb9e692229a3 Robert Hancock 2022-05-05 790 * cause an immediate interrupt if any TX packets are 89eb9e692229a3 Robert Hancock 2022-05-05 791 * already pending. 89eb9e692229a3 Robert Hancock 2022-05-05 792 */ 89eb9e692229a3 Robert Hancock 2022-05-05 793 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET, lp->tx_dma_cr); 89eb9e692229a3 Robert Hancock 2022-05-05 794 } 89eb9e692229a3 Robert Hancock 2022-05-05 795 return packets; 89eb9e692229a3 Robert Hancock 2022-05-05 796 } 89eb9e692229a3 Robert Hancock 2022-05-05 797 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FFCDC433EF for ; Fri, 6 May 2022 01:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k8YEhv8AOoX4b2oMvZuEyjK+zDkvkzePQU7X4Z8OVpI=; b=lKi+C2wGPC0Yws NiwE2yJtwcxUWWWaPDSN11wk2l6lmSw6AfXoY0XUkYatgR8nQCzStNNgrvNZSAQysswmPtAW8LxbO pmLgC3zTpgDwF/C1Ew4snH0QRyTAQDbu9WJcqt2TLAAdaNkCJMi/co8NlRhVl2xl0HShoj+43TDMG rO67nGzshwX6nleXu3dzhN0/59Onls11v92y7HdNS2ra0F59SNNCI80KrSqN5Btrohio9R57NU65i ss4Ptsd5x8CSlMTq+LhP1GPQaI0vcdbF1c6XYhdR84Fksw0Myd4immTXgDvnRkaBxKbQfZiQ+GFH1 V2B6I/HcxjOFQgBgEdIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmnBr-000rIr-0J; Fri, 06 May 2022 01:55:31 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmnBf-000rEl-Ua for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 01:55:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651802119; x=1683338119; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VYh3t/xp0DZMnprLcLN9Qaa20uH8rVTUofBzr82Uzts=; b=JpwAtfCHU6LUrKxRusDB1x4I7MQBpiiMZHviYtoJ8UL+s9PalVN6ovFm G4FU1es28SlEm9rKrm8QfBBv8BDDmzT6O3oGt6Sw5eE0ui3mnWEdOPV+3 gXiGZF80OWdFancrKG7jdLDKqlV94WwAFluWB5mnSygeQqWezuhgRe4yt Bv8RRPcKyrAfFVUandI8kCCFL3DD6F8FA4lonqohlZcENJAl/WKI9pEln cyWIc56pVPdGLJ45cuxztVqPC9hnSyb5UpUedBGvyuvHfWFwgk4fq7yFa C4tH8MLbkIdu8R2AcUv6TJtBfD+hb8+pX1u8dHTa5CvQ0wk++ULWb4l53 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="268461811" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="268461811" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:55:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="517802313" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 05 May 2022 18:55:15 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nmnBb-000CxX-6L; Fri, 06 May 2022 01:55:15 +0000 Date: Fri, 6 May 2022 09:54:34 +0800 From: kernel test robot To: Robert Hancock , netdev@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, radhey.shyam.pandey@xilinx.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, Robert Hancock Subject: Re: [PATCH net-next v3] net: axienet: Use NAPI for TX completion path Message-ID: <202205060910.pO104P2e-lkp@intel.com> References: <20220505203754.1905881-1-robert.hancock@calian.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220505203754.1905881-1-robert.hancock@calian.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_185520_073062_6C38EA11 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Robert-Hancock/net-axienet-Use-NAPI-for-TX-completion-path/20220506-043932 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1c1ed5a48411e1686997157c21633653fbe045c6 config: x86_64-randconfig-c007 (https://download.01.org/0day-ci/archive/20220506/202205060910.pO104P2e-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/89eb9e692229a3af81eaf2f599781bfae3091e93 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Robert-Hancock/net-axienet-Use-NAPI-for-TX-completion-path/20220506-043932 git checkout 89eb9e692229a3af81eaf2f599781bfae3091e93 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/xilinx/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:765: warning: expecting prototype for axienet_start_xmit_done(). Prototype was for axienet_tx_poll() instead vim +765 drivers/net/ethernet/xilinx/xilinx_axienet_main.c bb193e3db8b86a Robert Hancock 2022-01-18 749 ab365c3393664f Andre Przywara 2020-03-24 750 /** ab365c3393664f Andre Przywara 2020-03-24 751 * axienet_start_xmit_done - Invoked once a transmit is completed by the ab365c3393664f Andre Przywara 2020-03-24 752 * Axi DMA Tx channel. 89eb9e692229a3 Robert Hancock 2022-05-05 753 * @napi: Pointer to NAPI structure. 89eb9e692229a3 Robert Hancock 2022-05-05 754 * @budget: Max number of TX packets to process. 89eb9e692229a3 Robert Hancock 2022-05-05 755 * 89eb9e692229a3 Robert Hancock 2022-05-05 756 * Return: Number of TX packets processed. ab365c3393664f Andre Przywara 2020-03-24 757 * 89eb9e692229a3 Robert Hancock 2022-05-05 758 * This function is invoked from the NAPI processing to notify the completion ab365c3393664f Andre Przywara 2020-03-24 759 * of transmit operation. It clears fields in the corresponding Tx BDs and ab365c3393664f Andre Przywara 2020-03-24 760 * unmaps the corresponding buffer so that CPU can regain ownership of the ab365c3393664f Andre Przywara 2020-03-24 761 * buffer. It finally invokes "netif_wake_queue" to restart transmission if ab365c3393664f Andre Przywara 2020-03-24 762 * required. ab365c3393664f Andre Przywara 2020-03-24 763 */ 89eb9e692229a3 Robert Hancock 2022-05-05 764 static int axienet_tx_poll(struct napi_struct *napi, int budget) ab365c3393664f Andre Przywara 2020-03-24 @765 { 89eb9e692229a3 Robert Hancock 2022-05-05 766 struct axienet_local *lp = container_of(napi, struct axienet_local, napi_tx); 89eb9e692229a3 Robert Hancock 2022-05-05 767 struct net_device *ndev = lp->ndev; ab365c3393664f Andre Przywara 2020-03-24 768 u32 size = 0; 89eb9e692229a3 Robert Hancock 2022-05-05 769 int packets; ab365c3393664f Andre Przywara 2020-03-24 770 89eb9e692229a3 Robert Hancock 2022-05-05 771 packets = axienet_free_tx_chain(lp, lp->tx_bd_ci, budget, false, &size, budget); ab365c3393664f Andre Przywara 2020-03-24 772 89eb9e692229a3 Robert Hancock 2022-05-05 773 if (packets) { ab365c3393664f Andre Przywara 2020-03-24 774 lp->tx_bd_ci += packets; ab365c3393664f Andre Przywara 2020-03-24 775 if (lp->tx_bd_ci >= lp->tx_bd_num) 89eb9e692229a3 Robert Hancock 2022-05-05 776 lp->tx_bd_ci %= lp->tx_bd_num; ab365c3393664f Andre Przywara 2020-03-24 777 8a3b7a252dca9f Daniel Borkmann 2012-01-19 778 ndev->stats.tx_packets += packets; 8a3b7a252dca9f Daniel Borkmann 2012-01-19 779 ndev->stats.tx_bytes += size; 7de44285c1f69c Robert Hancock 2019-06-06 780 7de44285c1f69c Robert Hancock 2019-06-06 781 /* Matches barrier in axienet_start_xmit */ 7de44285c1f69c Robert Hancock 2019-06-06 782 smp_mb(); 7de44285c1f69c Robert Hancock 2019-06-06 783 bb193e3db8b86a Robert Hancock 2022-01-18 784 if (!axienet_check_tx_bd_space(lp, MAX_SKB_FRAGS + 1)) 8a3b7a252dca9f Daniel Borkmann 2012-01-19 785 netif_wake_queue(ndev); 8a3b7a252dca9f Daniel Borkmann 2012-01-19 786 } 8a3b7a252dca9f Daniel Borkmann 2012-01-19 787 89eb9e692229a3 Robert Hancock 2022-05-05 788 if (packets < budget && napi_complete_done(napi, packets)) { 89eb9e692229a3 Robert Hancock 2022-05-05 789 /* Re-enable TX completion interrupts. This should 89eb9e692229a3 Robert Hancock 2022-05-05 790 * cause an immediate interrupt if any TX packets are 89eb9e692229a3 Robert Hancock 2022-05-05 791 * already pending. 89eb9e692229a3 Robert Hancock 2022-05-05 792 */ 89eb9e692229a3 Robert Hancock 2022-05-05 793 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET, lp->tx_dma_cr); 89eb9e692229a3 Robert Hancock 2022-05-05 794 } 89eb9e692229a3 Robert Hancock 2022-05-05 795 return packets; 89eb9e692229a3 Robert Hancock 2022-05-05 796 } 89eb9e692229a3 Robert Hancock 2022-05-05 797 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel