From: "Michael Büsch" <m@bues.ch>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ssb: remove unreachable code
Date: Fri, 6 May 2022 17:29:56 +0200 [thread overview]
Message-ID: <20220506172956.25004612@barney> (raw)
In-Reply-To: <20220506075814.115059-1-jiapeng.chong@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Fri, 6 May 2022 15:58:14 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Clean up the following smatch warning:
>
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/ssb/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 148bcb99c212..493bebbba521 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
> err = 0;
> goto out_free;
> }
> - pr_warn("WARNING: Invalid SPROM CRC (corrupt
> SPROM)\n"); }
> }
> err = sprom_extract(bus, sprom, buf, bus->sprom_size);
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-06 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 7:58 [PATCH] ssb: remove unreachable code Jiapeng Chong
2022-05-06 15:29 ` Michael Büsch [this message]
2022-05-11 5:29 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2021-05-18 2:52 Tian Tao
2021-05-20 16:51 ` Michael Büsch
2021-05-21 0:49 ` tiantao (H)
2021-05-21 3:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506172956.25004612@barney \
--to=m@bues.ch \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.