From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5C6C433FE for ; Sun, 8 May 2022 07:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbiEHHUy (ORCPT ); Sun, 8 May 2022 03:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbiEHHUx (ORCPT ); Sun, 8 May 2022 03:20:53 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7457EBF64 for ; Sun, 8 May 2022 00:17:03 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id bo5so9736038pfb.4 for ; Sun, 08 May 2022 00:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Pmia3f83d9c4z0pslQdQjq3eRCIFxyb8z/IWO9Z38ao=; b=t6kDm7iTCtb4FmyDMxma8umwQwzKL2JupjfLGk02JjYTGCWzc8I9DDOPnVU/JulmG3 KszspKzJB8w+ttIZYkI7L9z8UUJJLtx7CRWRGfS4VPRBlXRFRwct2yAOUziTqaForIGg cQ2nzM8vWDrOU+oGjD+0OaCFvvIOTShiAvA3dEbYlt4A1OjormyjvG4wAs5wuCYWCo+v GtVuJvYGKEok/g5gq8PoHIBzscVGuzN6nrWgmAw/Oy8ah9YMJAt0zOlTYX64UPACkMcq 6ej+hbT8CBfWY63RjIuDHc97Tm1zW/HQl8Zg9TEzo4m3QuLQ+oD/beHpyUnUbWMgCFBH JeKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Pmia3f83d9c4z0pslQdQjq3eRCIFxyb8z/IWO9Z38ao=; b=p1jzQN0ZTCjsNt2XT54kDgX+douvdqgKTXCrUHCVITwdkTDk2mEd+LvE0Tcb4WVuLV MF3eGBQWOOX/MGZLLqabUtixgbLiwAj3Y39pDt/IRm9z+GM0Y6DQ4Z/yAB8FXJ8+RWll SYU3E9VmtHP3sObg9WY0gwxp+wYkaScBH948tbU0eMsTcFhXI7gUoYn6ujHP14z16MPl pc+uANXbNsGHCZ8J0RWOVjnJ6PVfXw/dJIAlsLhW5aGJxg2I/p00edL/fTt5tXjzNnai nX+NVr9E0aVELbwZsdIOvB68WBp6jI0TWAnWZlclnfROsNKvAO0YgkbwIskWWK8oIoA8 gsRg== X-Gm-Message-State: AOAM5308Le0snPoVExMKo94i8mGFGWTVKSHZn+KvIqrbumh78T1jb+TV Kiko+QU+ShOEmep1qkctHmw7 X-Google-Smtp-Source: ABdhPJxu5CrFctjLtjT1lTJIK1jFwL+XEsVaS5Sz7j5qObZKbONmEaEZJKQEO5T8vskmUppYOSmqGw== X-Received: by 2002:a05:6a00:26cf:b0:4f6:fc52:7b6a with SMTP id p15-20020a056a0026cf00b004f6fc527b6amr10673139pfw.39.1651994222762; Sun, 08 May 2022 00:17:02 -0700 (PDT) Received: from thinkpad ([27.111.75.235]) by smtp.gmail.com with ESMTPSA id iy11-20020a17090b16cb00b001dc37aef4ffsm6363055pjb.48.2022.05.08.00.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 00:17:02 -0700 (PDT) Date: Sun, 8 May 2022 12:46:56 +0530 From: Manivannan Sadhasivam To: Viresh Kumar Cc: Hector Martin , "Rafael J. Wysocki" , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Ulf Hansson , Marc Zyngier , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Apple SoC cpufreq driver Message-ID: <20220508071656.GA42059@thinkpad> References: <20220504075153.185208-1-marcan@marcan.st> <20220504102745.fv5bl2cphq7ft4lm@vireshk-i7> <20220504160019.GB3507@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220504160019.GB3507@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, May 04, 2022 at 09:30:26PM +0530, Manivannan Sadhasivam wrote: > Hi Viresh, > > On Wed, May 04, 2022 at 03:57:45PM +0530, Viresh Kumar wrote: > > On 04-05-22, 16:51, Hector Martin wrote: > > > Hi folks, > > > > > > Here's a second take on the cpufreq driver for Apple SoCs. This is a > > > complete rewrite using a stand-alone cpufreq driver instead of using the > > > cpufreq-dt infrastructure. > > > > > > Since v1 we ran some experiments on the memory controller performance > > > switching and it turns out it doesn't make a huge difference, so it > > > makes sense to punt that feature to the future (perhaps once a proper > > > memory controller driver exists for other reasons, e.g. for error > > > handling). > > > > > > One advantage of having a standalone cpufreq driver is that we can > > > support fast switching. This also means any future interaction with > > > the memory controller will probably use some bespoke mechanism instead > > > of the genpd infrastructure, so we can keep the fast path without > > > allowing sleeps/etc. > > > > > > The driver is based on scpi-cpufreq.c, with some bits (e.g. the > > > apple,freq-domain stuff) inspired by how cpufreq-qcom-hw does it. > > > I'm not sure if that particular property should be described > > > in a binding, since it goes in the cpu nodes (qcom doesn't have it > > > anywhere...). > > > > Hi Mani, > > > > I can see that Rob asked you to add this somewhere, maybe in arm/cpu > > stuff, but I don't think you ever sent a patch with that. What > > happened ? > > > > https://lore.kernel.org/lkml/20201013171800.GA3716411@bogus/ > > > > Oops. Looks like that one slipped through the cracks. I did add it to my todo > list for qcom-cpufreq but missed it completely. > > I will look into it. > So I did send a patch for adding the qcom specific property [1], but Rob asked for a common one and that's where it got lost. But in the last revision [2], you've asked for converting the qcom cpufreq driver to support the generic performance domains instead. For maintaining compatibility with the old dts files, we need to support the qcom specific property as well. I will send a series for that. Thanks, Mani [1] https://patchwork.kernel.org/project/linux-pm/patch/20201020153944.18047-1-manivannan.sadhasivam@linaro.org/#23718065 [2] https://patchwork.kernel.org/project/linux-pm/patch/20210701105730.322718-4-angelogioacchino.delregno@somainline.org/ > Thanks, > Mani > > > -- > > viresh -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD97CC433F5 for ; Sun, 8 May 2022 07:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=miQhdQDEnXN0iVd3K4ZaaeWWML26CjZdfwHoM/Ipklk=; b=3qZPaEb9kdx7kF /8cDW89C7NeykEakx2Lphx4PsP6rBcrn8XfPLpIsBkxIMMnmTy3wsGX4m2giJypncN3ag8UFUJyXM FUyyJh6NwSqv+6EjIagdNcf73EAwPEogfEZBojD6RYT3s8wAPR+pT2hd4vjjzVFqo+G5k1wWwtkKm wR+5eF50PIYpxqmVJQtpFCPIBvVvxVggt2mCB22DeyrJt8eeZ72/4F4XaOibfUl9bzgZJRGwVoVRC Sma4hnm/zt0x7k62Cso1CGRT8I8scsbC+burTun43oJ7j/WiEMpua5zIhAVQSCQbXHkoI3uqpO+iu dbML5NPBdEGz+8KR31sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnbAC-009MxH-HZ; Sun, 08 May 2022 07:17:08 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnbA8-009Mw9-Mo for linux-arm-kernel@lists.infradead.org; Sun, 08 May 2022 07:17:06 +0000 Received: by mail-pg1-x534.google.com with SMTP id a191so9565292pge.2 for ; Sun, 08 May 2022 00:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Pmia3f83d9c4z0pslQdQjq3eRCIFxyb8z/IWO9Z38ao=; b=t6kDm7iTCtb4FmyDMxma8umwQwzKL2JupjfLGk02JjYTGCWzc8I9DDOPnVU/JulmG3 KszspKzJB8w+ttIZYkI7L9z8UUJJLtx7CRWRGfS4VPRBlXRFRwct2yAOUziTqaForIGg cQ2nzM8vWDrOU+oGjD+0OaCFvvIOTShiAvA3dEbYlt4A1OjormyjvG4wAs5wuCYWCo+v GtVuJvYGKEok/g5gq8PoHIBzscVGuzN6nrWgmAw/Oy8ah9YMJAt0zOlTYX64UPACkMcq 6ej+hbT8CBfWY63RjIuDHc97Tm1zW/HQl8Zg9TEzo4m3QuLQ+oD/beHpyUnUbWMgCFBH JeKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Pmia3f83d9c4z0pslQdQjq3eRCIFxyb8z/IWO9Z38ao=; b=77Nt764FD5GPLThLIsFe5l2ksNuVjQQVehdeC2KQbBnt+kH5eLEMaf4NVSNBZb7yal LG7eYiOt5qmIGcyoYhtD6Eku9XWfIU+Fm2aQVOhRtiSrhQuC/mIXvkWbARTOAJZaINHP rTrhRU4Wc4O4cOLJKYCTNnM7UKZnL9F+5tN5NHXUroQXwj6cram0x+2JGnAdhvp8ABoo ZLb4YxdBZFMYoZGS2WSEQ4u4qaSBS00tweXh0aJuVlR5y+jFizXbq8VBCvjkR2RMaskM ndJs2qZcoXYmGXWiSyUYYiLMRTvfES9Orvp/koVLDteSTnKkF+aOOg20hFh1MackPhfp 3PBA== X-Gm-Message-State: AOAM532yak2iQJNcmhtxCYpKSADWi2ey50vyYeHbAJrX48T7IrsIoJbd 8sB02NACo9Iw05fxUNd5kCQr X-Google-Smtp-Source: ABdhPJxu5CrFctjLtjT1lTJIK1jFwL+XEsVaS5Sz7j5qObZKbONmEaEZJKQEO5T8vskmUppYOSmqGw== X-Received: by 2002:a05:6a00:26cf:b0:4f6:fc52:7b6a with SMTP id p15-20020a056a0026cf00b004f6fc527b6amr10673139pfw.39.1651994222762; Sun, 08 May 2022 00:17:02 -0700 (PDT) Received: from thinkpad ([27.111.75.235]) by smtp.gmail.com with ESMTPSA id iy11-20020a17090b16cb00b001dc37aef4ffsm6363055pjb.48.2022.05.08.00.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 00:17:02 -0700 (PDT) Date: Sun, 8 May 2022 12:46:56 +0530 From: Manivannan Sadhasivam To: Viresh Kumar Cc: Hector Martin , "Rafael J. Wysocki" , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Ulf Hansson , Marc Zyngier , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Apple SoC cpufreq driver Message-ID: <20220508071656.GA42059@thinkpad> References: <20220504075153.185208-1-marcan@marcan.st> <20220504102745.fv5bl2cphq7ft4lm@vireshk-i7> <20220504160019.GB3507@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220504160019.GB3507@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220508_001704_829986_90A19E72 X-CRM114-Status: GOOD ( 35.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMDQsIDIwMjIgYXQgMDk6MzA6MjZQTSArMDUzMCwgTWFuaXZhbm5hbiBTYWRo YXNpdmFtIHdyb3RlOgo+IEhpIFZpcmVzaCwKPiAKPiBPbiBXZWQsIE1heSAwNCwgMjAyMiBhdCAw Mzo1Nzo0NVBNICswNTMwLCBWaXJlc2ggS3VtYXIgd3JvdGU6Cj4gPiBPbiAwNC0wNS0yMiwgMTY6 NTEsIEhlY3RvciBNYXJ0aW4gd3JvdGU6Cj4gPiA+IEhpIGZvbGtzLAo+ID4gPiAKPiA+ID4gSGVy ZSdzIGEgc2Vjb25kIHRha2Ugb24gdGhlIGNwdWZyZXEgZHJpdmVyIGZvciBBcHBsZSBTb0NzLiBU aGlzIGlzIGEKPiA+ID4gY29tcGxldGUgcmV3cml0ZSB1c2luZyBhIHN0YW5kLWFsb25lIGNwdWZy ZXEgZHJpdmVyIGluc3RlYWQgb2YgdXNpbmcgdGhlCj4gPiA+IGNwdWZyZXEtZHQgaW5mcmFzdHJ1 Y3R1cmUuCj4gPiA+IAo+ID4gPiBTaW5jZSB2MSB3ZSByYW4gc29tZSBleHBlcmltZW50cyBvbiB0 aGUgbWVtb3J5IGNvbnRyb2xsZXIgcGVyZm9ybWFuY2UKPiA+ID4gc3dpdGNoaW5nIGFuZCBpdCB0 dXJucyBvdXQgaXQgZG9lc24ndCBtYWtlIGEgaHVnZSBkaWZmZXJlbmNlLCBzbyBpdAo+ID4gPiBt YWtlcyBzZW5zZSB0byBwdW50IHRoYXQgZmVhdHVyZSB0byB0aGUgZnV0dXJlIChwZXJoYXBzIG9u Y2UgYSBwcm9wZXIKPiA+ID4gbWVtb3J5IGNvbnRyb2xsZXIgZHJpdmVyIGV4aXN0cyBmb3Igb3Ro ZXIgcmVhc29ucywgZS5nLiBmb3IgZXJyb3IKPiA+ID4gaGFuZGxpbmcpLgo+ID4gPiAKPiA+ID4g T25lIGFkdmFudGFnZSBvZiBoYXZpbmcgYSBzdGFuZGFsb25lIGNwdWZyZXEgZHJpdmVyIGlzIHRo YXQgd2UgY2FuCj4gPiA+IHN1cHBvcnQgZmFzdCBzd2l0Y2hpbmcuIFRoaXMgYWxzbyBtZWFucyBh bnkgZnV0dXJlIGludGVyYWN0aW9uIHdpdGgKPiA+ID4gdGhlIG1lbW9yeSBjb250cm9sbGVyIHdp bGwgcHJvYmFibHkgdXNlIHNvbWUgYmVzcG9rZSBtZWNoYW5pc20gaW5zdGVhZAo+ID4gPiBvZiB0 aGUgZ2VucGQgaW5mcmFzdHJ1Y3R1cmUsIHNvIHdlIGNhbiBrZWVwIHRoZSBmYXN0IHBhdGggd2l0 aG91dAo+ID4gPiBhbGxvd2luZyBzbGVlcHMvZXRjLgo+ID4gPiAKPiA+ID4gVGhlIGRyaXZlciBp cyBiYXNlZCBvbiBzY3BpLWNwdWZyZXEuYywgd2l0aCBzb21lIGJpdHMgKGUuZy4gdGhlCj4gPiA+ IGFwcGxlLGZyZXEtZG9tYWluIHN0dWZmKSBpbnNwaXJlZCBieSBob3cgY3B1ZnJlcS1xY29tLWh3 IGRvZXMgaXQuCj4gPiA+IEknbSBub3Qgc3VyZSBpZiB0aGF0IHBhcnRpY3VsYXIgcHJvcGVydHkg c2hvdWxkIGJlIGRlc2NyaWJlZAo+ID4gPiBpbiBhIGJpbmRpbmcsIHNpbmNlIGl0IGdvZXMgaW4g dGhlIGNwdSBub2RlcyAocWNvbSBkb2Vzbid0IGhhdmUgaXQKPiA+ID4gYW55d2hlcmUuLi4pLgo+ ID4gCj4gPiBIaSBNYW5pLAo+ID4gCj4gPiBJIGNhbiBzZWUgdGhhdCBSb2IgYXNrZWQgeW91IHRv IGFkZCB0aGlzIHNvbWV3aGVyZSwgbWF5YmUgaW4gYXJtL2NwdQo+ID4gc3R1ZmYsIGJ1dCBJIGRv bid0IHRoaW5rIHlvdSBldmVyIHNlbnQgYSBwYXRjaCB3aXRoIHRoYXQuIFdoYXQKPiA+IGhhcHBl bmVkID8KPiA+IAo+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDIwMTAxMzE3MTgw MC5HQTM3MTY0MTFAYm9ndXMvCj4gPiAKPiAKPiBPb3BzLiBMb29rcyBsaWtlIHRoYXQgb25lIHNs aXBwZWQgdGhyb3VnaCB0aGUgY3JhY2tzLiBJIGRpZCBhZGQgaXQgdG8gbXkgdG9kbwo+IGxpc3Qg Zm9yIHFjb20tY3B1ZnJlcSBidXQgbWlzc2VkIGl0IGNvbXBsZXRlbHkuCj4gCj4gSSB3aWxsIGxv b2sgaW50byBpdC4KPiAKClNvIEkgZGlkIHNlbmQgYSBwYXRjaCBmb3IgYWRkaW5nIHRoZSBxY29t IHNwZWNpZmljIHByb3BlcnR5IFsxXSwgYnV0IFJvYiBhc2tlZApmb3IgYSBjb21tb24gb25lIGFu ZCB0aGF0J3Mgd2hlcmUgaXQgZ290IGxvc3QuCgpCdXQgaW4gdGhlIGxhc3QgcmV2aXNpb24gWzJd LCB5b3UndmUgYXNrZWQgZm9yIGNvbnZlcnRpbmcgdGhlIHFjb20gY3B1ZnJlcQpkcml2ZXIgdG8g c3VwcG9ydCB0aGUgZ2VuZXJpYyBwZXJmb3JtYW5jZSBkb21haW5zIGluc3RlYWQuIEZvciBtYWlu dGFpbmluZwpjb21wYXRpYmlsaXR5IHdpdGggdGhlIG9sZCBkdHMgZmlsZXMsIHdlIG5lZWQgdG8g c3VwcG9ydCB0aGUgcWNvbSBzcGVjaWZpYwpwcm9wZXJ0eSBhcyB3ZWxsLgoKSSB3aWxsIHNlbmQg YSBzZXJpZXMgZm9yIHRoYXQuCgpUaGFua3MsCk1hbmkKClsxXSBodHRwczovL3BhdGNod29yay5r ZXJuZWwub3JnL3Byb2plY3QvbGludXgtcG0vcGF0Y2gvMjAyMDEwMjAxNTM5NDQuMTgwNDctMS1t YW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZy8jMjM3MTgwNjUKWzJdIGh0dHBzOi8vcGF0 Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9saW51eC1wbS9wYXRjaC8yMDIxMDcwMTEwNTczMC4z MjI3MTgtNC1hbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQHNvbWFpbmxpbmUub3JnLyAKPiBUaGFu a3MsCj4gTWFuaQo+IAo+ID4gLS0gCj4gPiB2aXJlc2gKCi0tIArgrq7grqPgrr/grrXgrqPgr43g rqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==