From: Jakub Kicinski <kuba@kernel.org>
To: <Yuiko.Oshino@microchip.com>
Cc: <andrew@lunn.ch>, <Woojung.Huh@microchip.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>,
<Ravi.Hegde@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.
Date: Mon, 9 May 2022 09:35:10 -0700 [thread overview]
Message-ID: <20220509093510.33bcfea2@kernel.org> (raw)
In-Reply-To: <CH0PR11MB55611C73D1A6472911151BB98EC69@CH0PR11MB5561.namprd11.prod.outlook.com>
On Mon, 9 May 2022 14:24:44 +0000 Yuiko.Oshino@microchip.com wrote:
> May I also fix this missing one tab after the phy_id in smsc.c in the same patch?
>
> + .phy_id = 0x0007c130, /* 0x0007c130 and 0x0007c131 */
> + .phy_id_mask = 0xfffffff2,
> +
Seems like an okay change to make in addition in adding the comments.
Both are non-functional changes, anyway.
next prev parent reply other threads:[~2022-05-09 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 18:12 [PATCH v4 net-next 0/2] net: phy: add LAN8742 phy support Yuiko Oshino
2022-05-05 18:12 ` [PATCH v4 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask Yuiko Oshino
2022-05-05 18:12 ` [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support Yuiko Oshino
2022-05-05 19:29 ` Andrew Lunn
2022-05-06 22:45 ` Jakub Kicinski
2022-05-07 13:48 ` Andrew Lunn
2022-05-09 13:47 ` Yuiko.Oshino
2022-05-09 13:50 ` Andrew Lunn
2022-05-09 14:24 ` Yuiko.Oshino
2022-05-09 16:35 ` Jakub Kicinski [this message]
2022-05-09 11:45 ` Yuiko.Oshino
2022-05-09 13:40 ` [PATCH v4 net-next 0/2] net: phy: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509093510.33bcfea2@kernel.org \
--to=kuba@kernel.org \
--cc=Ravi.Hegde@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=Yuiko.Oshino@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.