From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D8DDC433F5 for ; Mon, 9 May 2022 22:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MIXgDLv2Y3jv2xlJGkZ1jB9D9rxvkGqDV5XTgTN8Nck=; b=4Qc+/wN1HU9RPS kHEYQNgTLCrDbxb1LZ6DX8zSWWqZq00vjtbwvxvMQfjJVRi0iFHeAtlPUwH+Cq6QmE0VZAnpPf6uN +kSrdBBwV9bzAHkyWPhDkOgp5Gzgw2a+sZbvWIgdMp6FeNuJzsLorpUF08sRlSUoAJZbDH22J4wqg dRMF2AO0I4I2iA2W+E9trdPEqKYVQRxympn6QkblKSgUMhMOse1t7ZdLMLNDJc9ojtQS5WnKfksw6 EAG4fwv2TEmUiWQpuP+bwvvgW56SI+nQz3ZU//t/E0ilntjBdM/DoNwRjU/ZzpICJH7/LviUrEcWk lJasajWucQee+SukjUEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noCHu-00GdE4-3g; Mon, 09 May 2022 22:55:34 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noCHq-00GdCi-Qp for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 22:55:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5204B81730; Mon, 9 May 2022 22:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 216F8C385B3; Mon, 9 May 2022 22:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652136926; bh=eOxOKk3ZG98rLra0WnplqxNnsGlWGScNzyOmq/fwewM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iVwc7ON6x7KA8RL7JKq7syWCbuOrk3bj+ONYR7nESKE+4dRrKHNDCsMv1VrZsBsT3 5MMZ1Yb1jhA3Rxv0uFyPQaq9CJcxMgRQEj5/YqD3mqvwG3y25+OGDyFgK+0eXqAeSY q6T2pdkQyaPb5AlzJbdSpK3TRzqrlV04hUDXGHF3RMA91W4qswKZ0EVjylOp6OyW0B m8LAeAdoZVIpCAvZP7XzPyieIp2T4MaRMXYSbnKJXDv9Nya5kYqtrv5tGzxzMkz6ab RvQQOXsMfGxEKidoKLCkv1bbRiInpuBek1ikEdkLXQA6EmCuXpNy9xvfBd84YcbT0N yPHO0nuRdsU2w== Date: Mon, 9 May 2022 15:55:25 -0700 From: Jakub Kicinski To: Yang Yingliang Cc: , , , , , , , Subject: Re: [PATCH] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe() Message-ID: <20220509155525.26e053db@kernel.org> In-Reply-To: <20220506094039.3629649-1-yangyingliang@huawei.com> References: <20220506094039.3629649-1-yangyingliang@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_155531_038425_E077A911 X-CRM114-Status: UNSURE ( 8.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 6 May 2022 17:40:39 +0800 Yang Yingliang wrote: > Fix the missing pci_disable_device() before return > from stmmac_pci_probe() in the error handling case. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Here indeed pcim_enable_device() seems like a better fit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64FAC433F5 for ; Mon, 9 May 2022 22:55:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbiEIW7Y (ORCPT ); Mon, 9 May 2022 18:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbiEIW7W (ORCPT ); Mon, 9 May 2022 18:59:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8698F2C4F67; Mon, 9 May 2022 15:55:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2334160BC5; Mon, 9 May 2022 22:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 216F8C385B3; Mon, 9 May 2022 22:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652136926; bh=eOxOKk3ZG98rLra0WnplqxNnsGlWGScNzyOmq/fwewM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iVwc7ON6x7KA8RL7JKq7syWCbuOrk3bj+ONYR7nESKE+4dRrKHNDCsMv1VrZsBsT3 5MMZ1Yb1jhA3Rxv0uFyPQaq9CJcxMgRQEj5/YqD3mqvwG3y25+OGDyFgK+0eXqAeSY q6T2pdkQyaPb5AlzJbdSpK3TRzqrlV04hUDXGHF3RMA91W4qswKZ0EVjylOp6OyW0B m8LAeAdoZVIpCAvZP7XzPyieIp2T4MaRMXYSbnKJXDv9Nya5kYqtrv5tGzxzMkz6ab RvQQOXsMfGxEKidoKLCkv1bbRiInpuBek1ikEdkLXQA6EmCuXpNy9xvfBd84YcbT0N yPHO0nuRdsU2w== Date: Mon, 9 May 2022 15:55:25 -0700 From: Jakub Kicinski To: Yang Yingliang Cc: , , , , , , , Subject: Re: [PATCH] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe() Message-ID: <20220509155525.26e053db@kernel.org> In-Reply-To: <20220506094039.3629649-1-yangyingliang@huawei.com> References: <20220506094039.3629649-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 May 2022 17:40:39 +0800 Yang Yingliang wrote: > Fix the missing pci_disable_device() before return > from stmmac_pci_probe() in the error handling case. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Here indeed pcim_enable_device() seems like a better fit.