All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Sven Auhagen <Sven.Auhagen@voleatech.de>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
	nbd@nbd.name, fw@strlen.de, paulb@nvidia.com, ozsh@nvidia.com
Subject: Re: [PATCH] nf_flowtable: teardown fix race condition
Date: Mon, 9 May 2022 18:47:33 +0200	[thread overview]
Message-ID: <20220509164733.GA12438@breakpoint.cc> (raw)
In-Reply-To: <20220509093132.fmxxhhogq7jhhpks@SvensMacbookPro.hq.voleatech.com>

Sven Auhagen <Sven.Auhagen@voleatech.de> wrote:
> +	if (unlikely(!test_bit(IPS_ASSURED_BIT, &flow->ct->status))) {
> +		spin_lock_bh(&flow->ct->lock);
> +		flow->ct->proto.tcp.state = TCP_CONNTRACK_ESTABLISHED;
> +		spin_unlock_bh(&flow->ct->lock);
> +		set_bit(IPS_ASSURED_BIT, &flow->ct->status);

Uh. Whats going on here?  ASSURED bit prevents early-eviction,
it should not be set at random.

  parent reply	other threads:[~2022-05-09 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  9:31 [PATCH] nf_flowtable: teardown fix race condition Sven Auhagen
2022-05-09 13:13 ` Oz Shlomo
2022-05-09 13:16   ` Sven Auhagen
2022-05-09 16:47 ` Florian Westphal [this message]
2022-05-09 17:11   ` Sven Auhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509164733.GA12438@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=Sven.Auhagen@voleatech.de \
    --cc=nbd@nbd.name \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=ozsh@nvidia.com \
    --cc=pablo@netfilter.org \
    --cc=paulb@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.