On Mon, 9 May 2022 16:52:17 -0700 Eric Dumazet wrote: > On Mon, May 9, 2022 at 4:32 PM kernel test robot wrote: > > > > Hi Eric, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on net-next/master] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-CONFIG_DEBUG_NET-and-friends/20220510-031145 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9c095bd0d4c451d31d0fd1131cc09d3b60de815d > > config: arm-oxnas_v6_defconfig (https://download.01.org/0day-ci/archive/20220510/202205100723.9Wqso3nI-lkp(a)intel.com/config) > > compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/d316b61f313a417d7dfa97fa006320288f3af150 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Eric-Dumazet/net-CONFIG_DEBUG_NET-and-friends/20220510-031145 > > git checkout d316b61f313a417d7dfa97fa006320288f3af150 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/ethernet/stmicro/stmmac/ drivers/net/mdio/ net/core/ > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > I suppose some compiler/arches are asking us to add forward > declaration for struct net_device. > I have no idea what is the justification for that. Yeah the order of inclusion is skbuff -> netdevice, as you probably figured out by yourself. We may want to pull back the code move for the print helpers. Unless you have cycles to untangle that :S