From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <limings@nvidia.com>,
<cai.huoqing@linux.dev>, Asmaa Mnebhi <asmaa@nvidia.com>
Subject: Re: [PATCH net-next v1] mlxbf_gige: remove driver-managed interrupt counts
Date: Tue, 10 May 2022 15:24:31 -0700 [thread overview]
Message-ID: <20220510152431.0d7673bb@kernel.org> (raw)
In-Reply-To: <20220509152426.28800-1-davthompson@nvidia.com>
On Mon, 9 May 2022 11:24:26 -0400 David Thompson wrote:
> The driver currently has three interrupt counters,
> which are incremented every time each interrupt handler
> executes. These driver-managed counters are not
> necessary as the kernel already has logic that manages
> interrupt counts and exposes them via /proc/interrupts.
> This patch removes the driver-managed counters, and thus
> removes them from "ethtool -S" output as well.
The last part of the last sentence is not true, or at
least I don't see the patch removing any ethtool -S keys.
I think we requested you removed them from ethtool -S
during initial upstream review.
prev parent reply other threads:[~2022-05-10 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 15:24 [PATCH net-next v1] mlxbf_gige: remove driver-managed interrupt counts David Thompson
2022-05-10 22:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510152431.0d7673bb@kernel.org \
--to=kuba@kernel.org \
--cc=asmaa@nvidia.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=limings@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.