Re: [RFC PATCH bpf-next 4/9] bpf: add bpf rstat helpers

[kernel test robot <lkp@intel.com>]

Hi Yosry,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf/master]
[also build test ERROR on tj-cgroup/for-next v5.18-rc6]
[cannot apply to bpf-next/master next-20220509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-cgroup-hierarchical-stats-collection/20220510-082111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
config: arm-randconfig-c002-20220509 (https://download.01.org/0day-ci/archive/20220510/202205101901.s2K40KKV-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 18dd123c56754edf62c7042dcf23185c3727610f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/8e6d31618fefe87ecb64ce7445e427dd52563ec3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yosry-Ahmed/bpf-cgroup-hierarchical-stats-collection/20220510-082111
        git checkout 8e6d31618fefe87ecb64ce7445e427dd52563ec3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/bpf/helpers.c:1379:2: error: call to undeclared function 'cgroup_rstat_updated'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           cgroup_rstat_updated(cgrp, smp_processor_id());
           ^
   kernel/bpf/helpers.c:1379:2: note: did you mean 'bpf_cgroup_rstat_updated'?
   kernel/bpf/helpers.c:1377:12: note: 'bpf_cgroup_rstat_updated' declared here
   BPF_CALL_1(bpf_cgroup_rstat_updated, struct cgroup *, cgrp)
              ^
   include/linux/filter.h:511:45: note: expanded from macro 'BPF_CALL_1'
   #define BPF_CALL_1(name, ...)   BPF_CALL_x(1, name, __VA_ARGS__)
                                                 ^
   include/linux/filter.h:503:6: note: expanded from macro 'BPF_CALL_x'
           u64 name(__BPF_REG(x, __BPF_DECL_REGS, __BPF_N, __VA_ARGS__))          \
               ^
>> kernel/bpf/helpers.c:1392:2: error: call to undeclared function 'cgroup_rstat_flush_irqsafe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           cgroup_rstat_flush_irqsafe(cgrp);
           ^
   2 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for NET_DSA_SMSC_LAN9303
   Depends on NETDEVICES && NET_DSA && (VLAN_8021Q || VLAN_8021Q
   Selected by
   - NET_DSA_SMSC_LAN9303_I2C && NETDEVICES && NET_DSA && I2C


vim +/cgroup_rstat_updated +1379 kernel/bpf/helpers.c

  1376	
  1377	BPF_CALL_1(bpf_cgroup_rstat_updated, struct cgroup *, cgrp)
  1378	{
> 1379		cgroup_rstat_updated(cgrp, smp_processor_id());
  1380		return 0;
  1381	}
  1382	
  1383	static const struct bpf_func_proto bpf_cgroup_rstat_updated_proto = {
  1384		.func		= bpf_cgroup_rstat_updated,
  1385		.gpl_only	= false,
  1386		.ret_type	= RET_VOID,
  1387		.arg1_type	= ARG_ANYTHING,
  1388	};
  1389	
  1390	BPF_CALL_1(bpf_cgroup_rstat_flush, struct cgroup *, cgrp)
  1391	{
> 1392		cgroup_rstat_flush_irqsafe(cgrp);
  1393		return 0;
  1394	}
  1395	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp