From: Dave Chinner <david@fromorbit.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] casefold: Fix expansion of seqres variable
Date: Wed, 11 May 2022 14:55:37 +1000 [thread overview]
Message-ID: <20220511045537.GF2306852@dread.disaster.area> (raw)
In-Reply-To: <20220511002520.352812-1-krisman@collabora.com>
On Tue, May 10, 2022 at 08:25:20PM -0400, Gabriel Krisman Bertazi wrote:
> seqres is not properly expanded on these error paths, causing a file
> called seqres.full to be created instead.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
> common/casefold | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/casefold b/common/casefold
> index 9172d818125a..7e8f941211db 100644
> --- a/common/casefold
> +++ b/common/casefold
> @@ -25,7 +25,7 @@ _require_scratch_casefold()
> _notrun "$FSTYP does not support casefold feature"
> fi
>
> - if ! _scratch_mkfs_casefold &>>seqres.full; then
> + if ! _scratch_mkfs_casefold &>>$seqres.full; then
PLease add a space between the &>> and $seqres.full while you are
fixing this. It's unreadable without proper whitespace separation...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-05-11 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 0:25 [PATCH] casefold: Fix expansion of seqres variable Gabriel Krisman Bertazi
2022-05-11 4:55 ` Dave Chinner [this message]
2022-05-11 9:26 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511045537.GF2306852@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=krisman@collabora.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.