From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7933162242035123074==" MIME-Version: 1.0 From: Martin Habets To: kbuild-all@lists.01.org Subject: Re: [alaahl:netdev-next 12/22] drivers/net/ethernet/sfc/siena/siena_sriov.c:1578:5: warning: no previous prototype for 'efx_init_sriov' Date: Wed, 11 May 2022 14:17:37 +0100 Message-ID: <20220511131736.d2g2vtpbbbbajbyx@gmail.com> In-Reply-To: <202205111720.oJ7rmJle-lkp@intel.com> List-Id: --===============7933162242035123074== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable My next series of the Siena splitoff will fix this. Martin On Wed, May 11, 2022 at 05:55:15PM +0800, kernel test robot wrote: > tree: https://github.com/alaahl/linux.git netdev-next > head: 53a332f222c015cb82349fd4f6b58cb14f574e8d > commit: c5a13c319e10e795850b61bc7e3447b08024be2e [12/22] sfc: Add a basic= Siena module > config: arc-allyesconfig (https://download.01.org/0day-ci/archive/2022051= 1/202205111720.oJ7rmJle-lkp(a)intel.com/config) > compiler: arceb-elf-gcc (GCC) 11.3.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/alaahl/linux/commit/c5a13c319e10e795850b61bc= 7e3447b08024be2e > git remote add alaahl https://github.com/alaahl/linux.git > git fetch --no-tags alaahl netdev-next > git checkout c5a13c319e10e795850b61bc7e3447b08024be2e > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.3.0 make.cro= ss W=3D1 O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash drivers/hwmon/ drivers/= net/ethernet/sfc/siena/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > >> drivers/net/ethernet/sfc/siena/siena_sriov.c:1578:5: warning: no previ= ous prototype for 'efx_init_sriov' [-Wmissing-prototypes] > 1578 | int efx_init_sriov(void) > | ^~~~~~~~~~~~~~ > >> drivers/net/ethernet/sfc/siena/siena_sriov.c:1590:6: warning: no previ= ous prototype for 'efx_fini_sriov' [-Wmissing-prototypes] > 1590 | void efx_fini_sriov(void) > | ^~~~~~~~~~~~~~ > = > = > vim +/efx_init_sriov +1578 drivers/net/ethernet/sfc/siena/siena_sriov.c > = > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1577 = > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 @1578 int efx_init_sriov(void) > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1579 { > 327c685eb745e3 drivers/net/ethernet/sfc/siena_sriov.c Shradha Shah 2014-= 11-05 1580 /* A single threaded workqueue is sufficient. efx_siena_sriov= _vfdi() and > 327c685eb745e3 drivers/net/ethernet/sfc/siena_sriov.c Shradha Shah 2014-= 11-05 1581 * efx_siena_sriov_peer_work() spend almost all their time sl= eeping for > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1582 * MCDI to complete anyway > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1583 */ > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1584 vfdi_workqueue =3D create_singlethread_workqueue("sfc_vfdi"); > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1585 if (!vfdi_workqueue) > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1586 return -ENOMEM; > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1587 return 0; > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1588 } > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1589 = > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 @1590 void efx_fini_sriov(void) > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1591 { > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1592 destroy_workqueue(vfdi_workqueue); > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1593 } > cd2d5b529cdb9b drivers/net/ethernet/sfc/siena_sriov.c Ben Hutchings 2012-= 02-14 1594 = > = > :::::: The code at line 1578 was first introduced by commit > :::::: cd2d5b529cdb9bd274f3e4bc68d37d4d63b7f383 sfc: Add SR-IOV back-end = support for SFC9000 family > = > :::::: TO: Ben Hutchings > :::::: CC: Ben Hutchings > = > -- = > 0-DAY CI Kernel Test Service > https://01.org/lkp --===============7933162242035123074==--