From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A85DFC433F5 for ; Wed, 11 May 2022 14:29:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EEDAB1811; Wed, 11 May 2022 16:28:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EEDAB1811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652279344; bh=I9vGeFJi5v7ksxvFEo5+MO2yt1A/jE0rU1SS+JkUmtQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r0mQ7DsL+D6Gz6H69cCedC9/ueLZE1vp+Ij2UtdHff4SY3FjjoKwki0EY4DXWPTru fznotGQhYvfv1hYb9UktO4CqREOph3UrYrfJU+wEwtfX7xqbjEQRkDOOOZVg23KQUF A5mbdHGj96pdFgUn2bXtmrZRUKWfY+QgMoMWJHWg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7CD30F80137; Wed, 11 May 2022 16:28:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 73A9DF8015B; Wed, 11 May 2022 16:28:09 +0200 (CEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 84F28F80116 for ; Wed, 11 May 2022 16:28:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 84F28F80116 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e93bbb54f9so2965368fac.12 for ; Wed, 11 May 2022 07:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l5hfI95nGKptfm8+V5D6k5JgCAeWViIYLBqO5SQ8AOg=; b=V0tTRBtbGobpwSwBcAWAc44okMmOkW63Ciq9zQFvs61j2CQ+ZAnmcHGm+S3o2RIG4e /4wLs3e8mlEGbDbQsLc5q4jgdnTwFNalCDDfYKxvdxvDNR8wXY7mwPqK7WAhP7fIq4wG nMPV0noAzkp1LS0XQhEqqOuoUWKkRR63hnAckQAmmK9XkABCxYzgXIP0qjK7oJzm8eWK Hj8lbRAnFLxHlRVkSHzznL4KVmmTglIK5jsVsXeNbtOr7OTekBVm/PKd8MyWaLURuwAb AMkeKKrPhjpBMDwsvHPp6nOJLtdeCFPwnxtqCqAll+ltZBZWv0NW6akvp2SAurvVTkm0 F2TQ== X-Gm-Message-State: AOAM531gVTdrlnaytcZDZexSXhJNcOFrQ5zNFtd26AOu0Qgb09WiQhz5 7a2vkvFxgZX/J4dCWXmVOg== X-Google-Smtp-Source: ABdhPJwx6Qb8tL87ntfzUHzEzTkhI+b4g11lzmWoqGBuzVTYMC1eKnagTBy0+lyWuayExf/sakpdXw== X-Received: by 2002:a05:6870:14d6:b0:ed:ed86:9040 with SMTP id l22-20020a05687014d600b000eded869040mr2918700oab.199.1652279282580; Wed, 11 May 2022 07:28:02 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j18-20020a4a9452000000b0035eb4e5a6c3sm967857ooi.25.2022.05.11.07.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 07:28:02 -0700 (PDT) Received: (nullmailer pid 259228 invoked by uid 1000); Wed, 11 May 2022 14:28:01 -0000 Date: Wed, 11 May 2022 09:28:01 -0500 From: Rob Herring To: Daniel Kaehn Subject: Re: [PATCH v7 2/2] Add generic serial MIDI driver using serial bus API Message-ID: <20220511142801.GA236225-robh@kernel.org> References: <20220509145933.1161526-1-kaehndan@gmail.com> <20220509145933.1161526-3-kaehndan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509145933.1161526-3-kaehndan@gmail.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, May 09, 2022 at 09:59:33AM -0500, Daniel Kaehn wrote: > Generic serial MIDI driver adding support for using serial devices > compatible with the serial bus as raw MIDI devices, allowing using > additional serial devices not compatible with the existing > serial-u16550 driver. Supports only setting standard serial baudrates on > the underlying serial device; however, the underlying serial device can > be configured so that a requested 38.4 kBaud is actually the standard MIDI > 31.25 kBaud. Supports DeviceTree configuration. > > Signed-off-by: Daniel Kaehn > --- > sound/drivers/Kconfig | 18 ++ > sound/drivers/Makefile | 2 + > sound/drivers/serial-generic.c | 374 +++++++++++++++++++++++++++++++++ > 3 files changed, 394 insertions(+) > create mode 100644 sound/drivers/serial-generic.c Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6F4C433F5 for ; Wed, 11 May 2022 14:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234520AbiEKO2R (ORCPT ); Wed, 11 May 2022 10:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244676AbiEKO2P (ORCPT ); Wed, 11 May 2022 10:28:15 -0400 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068BA7C17D for ; Wed, 11 May 2022 07:28:04 -0700 (PDT) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-edf9ddb312so2994103fac.8 for ; Wed, 11 May 2022 07:28:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l5hfI95nGKptfm8+V5D6k5JgCAeWViIYLBqO5SQ8AOg=; b=oK1zzHXWA8rdkdeYW9MLdvoRNmiqdaN1FFKR+FpWGcUS6GLURq2tXsQPlzcNkZBG9+ S07MM+FoSBxi9q3ORdp5C/VLI3xLDW3wTinBAhFAOhoQJ22B0ztSxGkwgTsOo/G34aix WS0lRwgXeiKy+GAxd9w0Bub16eKp8+pOAbo+pFGnwBDpFUsC7MRtng+nduJ9SBhmsQsA xgPUi/2g08lSnwA1i9uy7k9LZXeVew3/82w9cabqmsNCDyijPStrqh/T3p1zTtQdHXUD +v3Wn8kiIYTDiyUhtPm7Q0GLsb+CAqmnbyfpHWQHHp83qxHVszEMoUhqUeGrmrts58IO xNuA== X-Gm-Message-State: AOAM530SqGq2NEKJMgxzvml/qDcpn3moZTmbpkNmyPVbnaEPFecMptdo Sw3Xfd/cgOHmXhoMyl8vQA== X-Google-Smtp-Source: ABdhPJwx6Qb8tL87ntfzUHzEzTkhI+b4g11lzmWoqGBuzVTYMC1eKnagTBy0+lyWuayExf/sakpdXw== X-Received: by 2002:a05:6870:14d6:b0:ed:ed86:9040 with SMTP id l22-20020a05687014d600b000eded869040mr2918700oab.199.1652279282580; Wed, 11 May 2022 07:28:02 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j18-20020a4a9452000000b0035eb4e5a6c3sm967857ooi.25.2022.05.11.07.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 07:28:02 -0700 (PDT) Received: (nullmailer pid 259228 invoked by uid 1000); Wed, 11 May 2022 14:28:01 -0000 Date: Wed, 11 May 2022 09:28:01 -0500 From: Rob Herring To: Daniel Kaehn Cc: tiwai@suse.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 2/2] Add generic serial MIDI driver using serial bus API Message-ID: <20220511142801.GA236225-robh@kernel.org> References: <20220509145933.1161526-1-kaehndan@gmail.com> <20220509145933.1161526-3-kaehndan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509145933.1161526-3-kaehndan@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 09, 2022 at 09:59:33AM -0500, Daniel Kaehn wrote: > Generic serial MIDI driver adding support for using serial devices > compatible with the serial bus as raw MIDI devices, allowing using > additional serial devices not compatible with the existing > serial-u16550 driver. Supports only setting standard serial baudrates on > the underlying serial device; however, the underlying serial device can > be configured so that a requested 38.4 kBaud is actually the standard MIDI > 31.25 kBaud. Supports DeviceTree configuration. > > Signed-off-by: Daniel Kaehn > --- > sound/drivers/Kconfig | 18 ++ > sound/drivers/Makefile | 2 + > sound/drivers/serial-generic.c | 374 +++++++++++++++++++++++++++++++++ > 3 files changed, 394 insertions(+) > create mode 100644 sound/drivers/serial-generic.c Reviewed-by: Rob Herring