From: Anup Patel <apatel@ventanamicro.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
Anup Patel <apatel@ventanamicro.com>
Subject: [PATCH v2 7/8] target/riscv: Force disable extensions if priv spec version does not match
Date: Wed, 11 May 2022 20:15:27 +0530 [thread overview]
Message-ID: <20220511144528.393530-8-apatel@ventanamicro.com> (raw)
In-Reply-To: <20220511144528.393530-1-apatel@ventanamicro.com>
We should disable extensions in riscv_cpu_realize() if minimum required
priv spec version is not satisfied. This also ensures that machines with
priv spec v1.11 (or lower) cannot enable H, V, and various multi-letter
extensions.
Fixes: a775398be2e ("target/riscv: Add isa extenstion strings to the
device tree")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
target/riscv/cpu.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index f3b61dfd63..25a4ba3e22 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -541,6 +541,40 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
set_priv_version(env, priv_version);
}
+ /* Force disable extensions if priv spec version does not match */
+ if (env->priv_ver < PRIV_VERSION_1_12_0) {
+ cpu->cfg.ext_h = false;
+ cpu->cfg.ext_v = false;
+ cpu->cfg.ext_zfh = false;
+ cpu->cfg.ext_zfhmin = false;
+ cpu->cfg.ext_zfinx = false;
+ cpu->cfg.ext_zhinx = false;
+ cpu->cfg.ext_zhinxmin = false;
+ cpu->cfg.ext_zdinx = false;
+ cpu->cfg.ext_zba = false;
+ cpu->cfg.ext_zbb = false;
+ cpu->cfg.ext_zbc = false;
+ cpu->cfg.ext_zbkb = false;
+ cpu->cfg.ext_zbkc = false;
+ cpu->cfg.ext_zbkx = false;
+ cpu->cfg.ext_zbs = false;
+ cpu->cfg.ext_zk = false;
+ cpu->cfg.ext_zkn = false;
+ cpu->cfg.ext_zknd = false;
+ cpu->cfg.ext_zkne = false;
+ cpu->cfg.ext_zknh = false;
+ cpu->cfg.ext_zkr = false;
+ cpu->cfg.ext_zks = false;
+ cpu->cfg.ext_zksed = false;
+ cpu->cfg.ext_zksh = false;
+ cpu->cfg.ext_zkt = false;
+ cpu->cfg.ext_zve32f = false;
+ cpu->cfg.ext_zve64f = false;
+ cpu->cfg.ext_svinval = false;
+ cpu->cfg.ext_svnapot = false;
+ cpu->cfg.ext_svpbmt = false;
+ }
+
if (cpu->cfg.mmu) {
riscv_set_feature(env, RISCV_FEATURE_MMU);
}
--
2.34.1
next prev parent reply other threads:[~2022-05-11 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 14:45 [PATCH v2 0/8] QEMU RISC-V nested virtualization fixes Anup Patel
2022-05-11 14:45 ` [PATCH v2 1/8] target/riscv: Fix csr number based privilege checking Anup Patel
2022-05-13 18:19 ` Atish Patra
2022-05-11 14:45 ` [PATCH v2 2/8] target/riscv: Fix hstatus.GVA bit setting for traps taken from HS-mode Anup Patel
2022-05-16 23:24 ` Alistair Francis
2022-05-11 14:45 ` [PATCH v2 3/8] target/riscv: Set [m|s]tval for both illegal and virtual instruction traps Anup Patel
2022-05-11 14:45 ` [PATCH v2 4/8] target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt() Anup Patel
2022-05-23 21:38 ` Alistair Francis
2022-05-24 12:19 ` Anup Patel
2022-05-11 14:45 ` [PATCH v2 5/8] target/riscv: Don't force update priv spec version to latest Anup Patel
2022-05-13 18:23 ` Atish Patra
2022-05-11 14:45 ` [PATCH v2 6/8] target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or higher Anup Patel
2022-05-13 18:24 ` Atish Patra
2022-05-11 14:45 ` Anup Patel [this message]
2022-05-13 18:45 ` [PATCH v2 7/8] target/riscv: Force disable extensions if priv spec version does not match Atish Patra
2022-05-17 0:15 ` Alistair Francis
2022-05-19 15:07 ` Anup Patel
2022-05-23 21:52 ` Alistair Francis
2022-05-24 12:10 ` Anup Patel
2022-05-11 14:45 ` [PATCH v2 8/8] hw/riscv: virt: Fix interrupt parent for dynamic platform devices Anup Patel
2022-05-23 21:38 ` Alistair Francis
2022-05-24 22:19 ` [PATCH v2 0/8] QEMU RISC-V nested virtualization fixes Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511144528.393530-8-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=Alistair.Francis@wdc.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.