From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8C3C433F5 for ; Wed, 11 May 2022 18:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344687AbiEKS6p (ORCPT ); Wed, 11 May 2022 14:58:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343977AbiEKS6o (ORCPT ); Wed, 11 May 2022 14:58:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9245B6D3A5 for ; Wed, 11 May 2022 11:58:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1480F60FD1 for ; Wed, 11 May 2022 18:58:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56BC6C340EE; Wed, 11 May 2022 18:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652295522; bh=ANeKWcNsPJ7LU/OV+d7iwnqbX69jlywUCHmny8sE2C8=; h=Date:To:From:Subject:From; b=EGUG/EOItKC2NFXVlHQmvFo1uTqsoJld/eJdAEnM5McjpNnqcplYk67btNofHRHl0 /V8RUXPZypXGuQPSVDEd1t+Ptlw50hv2jH8+AiEtVsT+bOuLWwwP/v9ajT5RDSeVwR L8daygt/uJ0hVt2itoKT8pQ+ZOlTAOpBiRfeMNbI= Date: Wed, 11 May 2022 11:58:41 -0700 To: mm-commits@vger.kernel.org, konishi.ryusuke@gmail.com, abaci@linux.alibaba.com, yang.lee@linux.alibaba.com, akpm@linux-foundation.org From: Andrew Morton Subject: + nilfs2-fix-some-kernel-doc-comments.patch added to mm-nonmm-unstable branch Message-Id: <20220511185842.56BC6C340EE@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: nilfs2: Fix some kernel-doc comments has been added to the -mm mm-nonmm-unstable branch. Its filename is nilfs2-fix-some-kernel-doc-comments.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/nilfs2-fix-some-kernel-doc-comments.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Yang Li Subject: nilfs2: Fix some kernel-doc comments The description of @flags in nilfs_dirty_inode() kernel-doc comment is missing, and some functions had kernel-doc that used a hash instead of a colon to separate the parameter name from the one line description. Fix them to remove some warnings found by running scripts/kernel-doc, which is caused by using 'make W=1'. fs/nilfs2/inode.c:73: warning: Function parameter or member 'inode' not described in 'nilfs_get_block' fs/nilfs2/inode.c:73: warning: Function parameter or member 'blkoff' not described in 'nilfs_get_block' fs/nilfs2/inode.c:73: warning: Function parameter or member 'bh_result' not described in 'nilfs_get_block' fs/nilfs2/inode.c:73: warning: Function parameter or member 'create' not described in 'nilfs_get_block' fs/nilfs2/inode.c:145: warning: Function parameter or member 'file' not described in 'nilfs_readpage' fs/nilfs2/inode.c:145: warning: Function parameter or member 'page' not described in 'nilfs_readpage' fs/nilfs2/inode.c:968: warning: Function parameter or member 'flags' not described in 'nilfs_dirty_inode' Link: https://lkml.kernel.org/r/20220324024215.63479-1-yang.lee@linux.alibaba.com Link: https://lkml.kernel.org/r/1652276316-7791-1-git-send-email-konishi.ryusuke@gmail.com Reported-by: Abaci Robot Signed-off-by: Yang Li Signed-off-by: Ryusuke Konishi Signed-off-by: Andrew Morton --- fs/nilfs2/inode.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) --- a/fs/nilfs2/inode.c~nilfs2-fix-some-kernel-doc-comments +++ a/fs/nilfs2/inode.c @@ -63,10 +63,10 @@ void nilfs_inode_sub_blocks(struct inode /** * nilfs_get_block() - get a file block on the filesystem (callback function) - * @inode - inode struct of the target file - * @blkoff - file block number - * @bh_result - buffer head to be mapped on - * @create - indicate whether allocating the block or not when it has not + * @inode: inode struct of the target file + * @blkoff: file block number + * @bh_result: buffer head to be mapped on + * @create: indicate whether allocating the block or not when it has not * been allocated yet. * * This function does not issue actual read request of the specified data @@ -142,8 +142,8 @@ int nilfs_get_block(struct inode *inode, /** * nilfs_readpage() - implement readpage() method of nilfs_aops {} * address_space_operations. - * @file - file struct of the file to be read - * @page - the page to be read + * @file: file struct of the file to be read + * @page: the page to be read */ static int nilfs_readpage(struct file *file, struct page *page) { @@ -1088,6 +1088,7 @@ int __nilfs_mark_inode_dirty(struct inod /** * nilfs_dirty_inode - reflect changes on given inode to an inode block. * @inode: inode of the file to be registered. + * @flags: flags to determine the dirty state of the inode * * nilfs_dirty_inode() loads a inode block containing the specified * @inode and copies data from a nilfs_inode to a corresponding inode _ Patches currently in -mm which might be from yang.lee@linux.alibaba.com are nilfs2-fix-some-kernel-doc-comments.patch