From: Zev Weiss <zweiss@equinix.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Zev Weiss <zev@bewilderbeest.net>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Delta AHE-50DC BMC
Date: Wed, 11 May 2022 21:38:48 +0000 [thread overview]
Message-ID: <20220511213848.GF11809@packtop> (raw)
In-Reply-To: <CACPK8Xdg9doTkKowWj7yS30Wqh=kstK5YbY1+QxRPw_6A0pR9A@mail.gmail.com>
On Tue, May 10, 2022 at 11:04:01PM PDT, Joel Stanley wrote:
>On Wed, 11 May 2022 at 03:37, Zev Weiss <zev@bewilderbeest.net> wrote:
>>
>> On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote:
>> > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that
>> > are mostly compatible with the existing ast2400-evb device tree, with
>> > a couple small tweaks for the serial console UART and ethernet MACs.
>> >
>> > Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>> > ---
>> > arch/arm/dts/Makefile | 1 +
>> > arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++
>> > 2 files changed, 35 insertions(+)
>> > create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
>> >
>>
>> Ping...does this look like a reasonable approach for a board that's
>> mostly-but-not-entirely EVB-compatible?
>
>That looks okay. Are you sure you have everything that the evb enables
>on your board? Dual flashes on both flash controllers, etc?
>
Ah, good point -- while it does have dual flashes on the fmc, I should
probably disable spi1.
>I wonder if it would be better to put more into ast2400-u-boot.dtsi
>and use that?
>
>But I don't have strong opinions either way. Your device tree looks
>fine, and I am happy to merge it.
>
Hmm, hadn't considered that possibility...I'm likewise not strongly
opinionated, but I guess the current approach of extending the evb dts
seems slightly simpler?
Thanks for the review -- I'll send a v2 with spi1 disabled soon.
Zev
prev parent reply other threads:[~2022-05-11 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 21:00 [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Delta AHE-50DC BMC Zev Weiss
2022-05-11 3:37 ` Zev Weiss
2022-05-11 6:04 ` Joel Stanley
2022-05-11 21:38 ` Zev Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511213848.GF11809@packtop \
--to=zweiss@equinix.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.