From: Jakub Kicinski <kuba@kernel.org>
To: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Cc: Tony Lu <tonylu@linux.alibaba.com>,
kgraul@linux.ibm.com, davem@davemloft.net, pabeni@redhat.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/smc: non blocking recvmsg() return -EAGAIN when no data and signal_pending
Date: Thu, 12 May 2022 09:06:38 -0700 [thread overview]
Message-ID: <20220512090638.0fbe7710@kernel.org> (raw)
In-Reply-To: <9be49a5a-c87d-1630-3ff3-90e6a233d38b@linux.alibaba.com>
On Thu, 12 May 2022 11:51:22 +0800 Guangguan Wang wrote:
> On 2022/5/12 11:43, Tony Lu wrote:
> > On Thu, May 12, 2022 at 11:11:55AM +0800, Guangguan Wang wrote:
> >> Non blocking sendmsg will return -EAGAIN when any signal pending
> >> and no send space left, while non blocking recvmsg return -EINTR
> >> when signal pending and no data received. This may makes confused.
> >> As TCP returns -EAGAIN in the conditions described above. Align the
> >> behavior of smc with TCP.
> >>
> >> Fixes: 846e344eb722 ("net/smc: add receive timeout check")
> >> Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
> >> Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
> >
> > I see that you have already sent this patch to net, so this patch is a
> > duplicate. There is no need to send it again to net-next.
>
> Ok, just ignore it. Thanks！
You gotta repost just patch 2, then. Please wait until net and net-next
get merged before sending (or 12h if you don't know how to figure out if
that already happened ;))
next prev parent reply other threads:[~2022-05-12 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 3:11 [PATCH net-next v2 0/2] net/smc: two fixes for using smc with io_uring Guangguan Wang
2022-05-12 3:11 ` [PATCH net-next v2 1/2] net/smc: non blocking recvmsg() return -EAGAIN when no data and signal_pending Guangguan Wang
2022-05-12 3:43 ` Tony Lu
2022-05-12 3:51 ` Guangguan Wang
2022-05-12 16:06 ` Jakub Kicinski [this message]
2022-05-12 3:11 ` [PATCH net-next v2 2/2] net/smc: align the connect behaviour with TCP Guangguan Wang
2022-05-12 12:08 ` Karsten Graul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512090638.0fbe7710@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=guangguan.wang@linux.alibaba.com \
--cc=kgraul@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.