From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4552CC433EF for ; Thu, 12 May 2022 10:19:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3CE7843AB; Thu, 12 May 2022 12:19:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="EDyhJDU6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F37ED83FEC; Thu, 12 May 2022 12:19:09 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0C1D783FEC for ; Thu, 12 May 2022 12:19:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 993BBB82736; Thu, 12 May 2022 10:19:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C3C0C385B8; Thu, 12 May 2022 10:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652350744; bh=N3ZbNsHhxUGvCn+yE2OtpnIRwBnHHBY7vaHTUHPxS0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EDyhJDU60EuiiiGd3jOJhEbIH4SozQnnhwNUZ/V4yPEfsmMdYxalP2RqhUWw1xDJ5 bdE93cFUi0zh8sOiMO0gOvDPLD1eyetbtDVU64xvu4Lez++VyAi8vIlUbI2nvgtLuH VN7VFNPoPzEbS6s+cSbWv/C5g4DoaeV0t1dxCFluFrrCqi4/Nm4nKQaFxCnX2nIhjP oJh7p+x4o6fI7NVjD3tfo8myMfWHOOXnNXaTitns5mXnFHfs0u5ez9Dso2R21gUtUi qMBYWRKEXFBrffN1jF/2n3bau9cCp7AnkUPLH2FQNhmsAUeUzUe1E8cGx0xkpw5t9P 4NEdfSNorm2lQ== Received: by pali.im (Postfix) id 56E6C24F5; Thu, 12 May 2022 12:19:01 +0200 (CEST) Date: Thu, 12 May 2022 12:19:01 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Miquel Raynal Cc: Tom Rini , Sean Nyekjaer , Joao Marcos Costa , Thomas Petazzoni , u-boot@lists.denx.de, Sean Nyekjaer Subject: Re: [PATCH] fs/squashfs: use do_div function for math Message-ID: <20220512101901.egbghfpf76f23tfs@pali> References: <20220505092637.1856223-1-sean@geanix.com> <20220505131500.GF3580959@bill-the-cat> <20220509150815.43d7543c@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220509150815.43d7543c@xps13> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Monday 09 May 2022 15:08:15 Miquel Raynal wrote: > Hello, > > trini@konsulko.com wrote on Thu, 5 May 2022 09:15:00 -0400: > > > On Thu, May 05, 2022 at 11:26:37AM +0200, Sean Nyekjaer wrote: > > > > > From: Sean Nyekjaer > > > > > > When compling for x86: > > > ld.bfd: fs/squashfs/sqfs.o: in function `sqfs_read': > > > u-boot/fs/squashfs/sqfs.c:1443: undefined reference to `__udivmoddi4' > > > ld.bfd: u-boot/fs/squashfs/sqfs.c:1521: undefined reference to `__udivmoddi4' > > > > > > Signed-off-by: Sean Nyekjaer > > > --- > > > fs/squashfs/sqfs.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c > > > index 5d9c52af80..6405db4ff3 100644 > > > --- a/fs/squashfs/sqfs.c > > > +++ b/fs/squashfs/sqfs.c > > > @@ -8,6 +8,7 @@ > > > */ > > > > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -1440,7 +1441,7 @@ int sqfs_read(const char *filename, void *buf, loff_t offset, loff_t len, > > > } > > > > > > for (j = 0; j < datablk_count; j++) { > > > - start = data_offset / ctxt.cur_dev->blksz; > > > + start = do_div(data_offset, ctxt.cur_dev->blksz); > > > table_size = SQFS_BLOCK_SIZE(finfo.blk_sizes[j]); > > > table_offset = data_offset - (start * ctxt.cur_dev->blksz); > > > n_blks = DIV_ROUND_UP(table_size + table_offset, > > > @@ -1516,7 +1517,7 @@ int sqfs_read(const char *filename, void *buf, loff_t offset, loff_t len, > > > goto out; > > > } > > > > > > - start = frag_entry.start / ctxt.cur_dev->blksz; > > > + start = do_div(frag_entry.start, ctxt.cur_dev->blksz); > > > table_size = SQFS_BLOCK_SIZE(frag_entry.size); > > > table_offset = frag_entry.start - (start * ctxt.cur_dev->blksz); > > > n_blks = DIV_ROUND_UP(table_size + table_offset, ctxt.cur_dev->blksz); > > > > Adding maintainers... > > I guess that's a correct fix, so > > Reviewed-by: Miquel Raynal > > Thanks, > Miquèl Hello! do_div() macro modifies its first argument. It is correct? Because previous code did not modify anything.