From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45549C433EF for ; Thu, 12 May 2022 12:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353587AbiELMRV (ORCPT ); Thu, 12 May 2022 08:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352872AbiELMRT (ORCPT ); Thu, 12 May 2022 08:17:19 -0400 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [IPv6:2a01:4f8:150:2161:1:b009:f23e:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2A1F51318 for ; Thu, 12 May 2022 05:17:18 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 5911210045BFD; Thu, 12 May 2022 14:17:17 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 3FC192E4EB2; Thu, 12 May 2022 14:17:17 +0200 (CEST) Date: Thu, 12 May 2022 14:17:17 +0200 From: Lukas Wunner To: netdev@vger.kernel.org Cc: Andrew Lunn Subject: Re: [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask Message-ID: <20220512121717.GD4703@wunner.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 12, 2022 at 10:42:06AM +0200, Lukas Wunner wrote: > Cache the interrupt mask to avoid re-reading it from the PHY upon every > interrupt. > > This will simplify a subsequent commit which detects hot-removal in the > interrupt handler and bails out. > > Analyzing and debugging PHY transactions also becomes simpler if such > redundant reads are avoided. > > Last not least, interrupt overhead and latency is slightly improved. > > Tested-by: Oleksij Rempel # LAN9514/9512/9500 > Tested-by: Ferry Toth # LAN9514 > Signed-off-by: Lukas Wunner Reviewed-by: Andrew Lunn Andrew kindly provided this tag here: https://lore.kernel.org/netdev/YnGsDtscYkh28PFm@lunn.ch/ Forgot to add it to the commit. Sending it in separately so patchwork picks it up. My apologies for the inconvenience.