From: Jason Gunthorpe <jgg@nvidia.com>
To: Shiraz Saleem <shiraz.saleem@intel.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
Mustafa Ismail <mustafa.ismail@intel.com>
Subject: Re: [PATCH for-next] RDMA/irdma: Add SW mechanism to generate completions on error
Date: Thu, 12 May 2022 13:56:54 -0300 [thread overview]
Message-ID: <20220512165654.GA1364750@nvidia.com> (raw)
In-Reply-To: <20220425181624.1617-1-shiraz.saleem@intel.com>
On Mon, Apr 25, 2022 at 01:16:24PM -0500, Shiraz Saleem wrote:
> From: Mustafa Ismail <mustafa.ismail@intel.com>
>
> HW flushes after QP in error state is not reliable. This can lead to
> application hang waiting on a completion for outstanding WRs.
> Implement a SW mechanism to generate completions for any
> outstanding WR's after the QP is modified to error.
>
> This is accomplished by starting a delayed worker after the QP is
> modified to error and the HW flush is performed. The worker
> will generate completions that will be returned to the application
> when it polls the CQ. This mechanism only applies to Kernel
> applications.
>
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/hw.c | 31 ++++----
> drivers/infiniband/hw/irdma/utils.c | 147 ++++++++++++++++++++++++++++++++++++
> drivers/infiniband/hw/irdma/verbs.c | 56 ++++++++------
> drivers/infiniband/hw/irdma/verbs.h | 13 +++-
> 4 files changed, 210 insertions(+), 37 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2022-05-12 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 18:16 [PATCH for-next] RDMA/irdma: Add SW mechanism to generate completions on error Shiraz Saleem
2022-05-12 16:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512165654.GA1364750@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.