From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexanderduyck@fb.com>,
Coco Li <lixiaoyan@google.com>, Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH v6 net-next 13/13] mlx5: support BIG TCP packets
Date: Fri, 13 May 2022 10:04:21 -0700 [thread overview]
Message-ID: <20220513100421.7c6d9f20@kernel.org> (raw)
In-Reply-To: <CANn89i+Y8XO9b2LSLorER2-NEPzfcAo3uG+VDxrTcimyS-kdTg@mail.gmail.com>
On Fri, 13 May 2022 06:05:36 -0700 Eric Dumazet wrote:
> The problem is that skb_cow_head() can fail.
>
> Really we have thought about this already.
>
> A common helper for drivers is mostly unusable, you would have to
> pre-allocate a per TX-ring slot to store the headers.
> We would end up with adding complexity at queue creation/dismantle.
>
> We could do that later, because some NICs do not inline the headers in
> TX descriptor, but instead request
> one mapped buffer for the headers part only.
>
> BTW, I know Tariq already reviewed, the issue at hand is about
> CONFIG_FORTIFY which is blocking us.
>
> This is why I was considering not submitting mlx5 change until Kees
> Cook and others come up with a solution.
We do have the solution, no?
commit 43213daed6d6 ("fortify: Provide a memcpy trap door for sharp
corners")
next prev parent reply other threads:[~2022-05-13 17:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:32 [PATCH v6 net-next 00/13] tcp: BIG TCP implementation Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 01/13] net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 02/13] net: allow gso_max_size to exceed 65536 Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 03/13] net: limit GSO_MAX_SIZE to 524280 bytes Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 04/13] tcp_cubic: make hystart_ack_delay() aware of BIG TCP Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 05/13] ipv6: add struct hop_jumbo_hdr definition Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 06/13] ipv6/gso: remove temporary HBH/jumbo header Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 07/13] ipv6/gro: insert " Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 08/13] net: allow gro_max_size to exceed 65536 Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 09/13] ipv6: Add hop-by-hop header to jumbograms in ip6_output Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 10/13] net: loopback: enable BIG TCP packets Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 11/13] veth: " Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 12/13] mlx4: support " Eric Dumazet
2022-05-10 3:32 ` [PATCH v6 net-next 13/13] mlx5: " Eric Dumazet
2022-05-12 8:40 ` Saeed Mahameed
2022-05-12 9:02 ` Paolo Abeni
2022-05-13 4:29 ` Saeed Mahameed
2022-05-13 4:34 ` Eric Dumazet
2022-05-13 5:49 ` Saeed Mahameed
2022-05-13 13:05 ` Eric Dumazet
2022-05-13 17:04 ` Jakub Kicinski [this message]
2022-05-13 17:12 ` Eric Dumazet
2022-05-10 19:49 ` [PATCH v6 net-next 00/13] tcp: BIG TCP implementation Alexander H Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513100421.7c6d9f20@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=leon@kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.