From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= Subject: [PATCH 0/4] memcontrol selftests fixups Date: Fri, 13 May 2022 19:18:07 +0200 Message-ID: <20220513171811.730-1-mkoutny@suse.com> References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652462320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lUuJK4eL9+OrReBYOWwXyTY//4zqDis40btPse6/uis=; b=ZfFAq7QzVD1bjBp+hkF5Z3fIv8AxgN0GzCRe9/I5WP8uaXdZ+RPtceXWSsm6MUZFQnXRSC 2oKg8kF5CJh4K3Mi+mNb8k/06l/ppvpwpWERxZqevlMKpjNhxXkNBOSwii9lXxf/7qjD+u vNfpJWgXzl11DC15sWKmZHQbjp4oyFE= In-Reply-To: <20220512174452.tr34tuh4k5jm6qjs-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org> List-ID: Content-Type: text/plain; charset="macroman" To: void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mkoutny-IBi9RG/b67k@public.gmane.org, roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Richard Palethorpe SGVsbG8uCgpJJ20ganVzdCBmbHVzaGluZyB0aGUgc2ltcGxlIHBhdGNoZXMgdG8gbWFrZSBtZW1j b250cm9sIHNlbGZ0ZXN0cyBjaGVjayB0aGUKZXZlbnRzIGJlaGF2aW9yIHdlIGhhZCBjb25zZW5z dXMgYWJvdXQgKHRlc3RfbWVtY2dfbG93IGZhaWxzKS4gKEkndmUgZHJvcHBlZCB0bwpnb3RvIG1h Y3JvcyBmb3Igbm93LikKCih0ZXN0X21lbWNnX3JlY2xhaW0sIHRlc3RfbWVtY2dfc3dhcF9tYXgg ZmFpbCBmb3IgbWUgbm93IGJ1dCBpdCdzIHByZXNlbnQKZXZlbiBiZWZvcmUgdGhlIHJlZmFjdG9y aW5nLikKClRoZSBvbmx5IGJpZ2dlciBjaGFuZ2UgaXMgYWRqdXN0bWVudCBvZiB0aGUgcHJvdGVj dGVkIHZhbHVlcyB0byBtYWtlIHRlc3RzCnN1Y2NlZWQgd2l0aCB0aGUgZ2l2ZW4gdG9sZXJhbmNl LgoKSXQncyBiYXNlZCBvbiBtbS1zdGFibGUgWzFdIGNvbW1pdCBlMjQwYWM1MmY3ZGEuIEFGQUlD LCB0aGUgZml4dXAgYW5kIHBhcnRpYWwKcmV2ZXJ0cyBtYXkgYmUgZm9sZGVkIGludG8gcmVzcGVj dGl2ZSBjb21taXRzLgpMZXQgbWUga25vdyBpZiBpdCBzaG91bGQgYmUgKHJlKWJhc2VkIG9uIHNv bWV0aGluZyBlbHNlLgoKVGhhbmtzLApNaWNoYWwKClsxXSBodHRwczovL2dpdC5rZXJuZWwub3Jn L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9ha3BtL21tLmdpdC9sb2cvdG9vbHMvdGVzdGluZy9z ZWxmdGVzdHMvY2dyb3VwP2g9bW0tc3RhYmxlCgpNaWNoYWwgS291dG7DvSAoNCk6CiAgc2VsZnRl c3RzOiBtZW1jZzogRml4IGNvbXBpbGF0aW9uCiAgc2VsZnRlc3RzOiBtZW1jZzogRXhwZWN0IG5v IGxvdyBldmVudHMgaW4gdW5wcm90ZWN0ZWQgc2libGluZwogIHNlbGZ0ZXN0czogbWVtY2c6IEFk anVzdCBleHBlY3RlZCByZWNsYWltIHZhbHVlcyBvZiBwcm90ZWN0ZWQgY2dyb3VwcwogIHNlbGZ0 ZXN0czogbWVtY2c6IFJlbW92ZSBwcm90ZWN0aW9uIGZyb20gdG9wIGxldmVsIG1lbWNnCgogLi4u L3NlbGZ0ZXN0cy9jZ3JvdXAvdGVzdF9tZW1jb250cm9sLmMgICAgICAgIHwgNTkgKysrKysrKysr LS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDMwIGRlbGV0aW9u cygtKQoKLS0gCjIuMzUuMwoK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338A6C433F5 for ; Fri, 13 May 2022 17:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DAB76B0073; Fri, 13 May 2022 13:18:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96F266B0078; Fri, 13 May 2022 13:18:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F64D6B0078; Fri, 13 May 2022 13:18:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6CBEA6B0073 for ; Fri, 13 May 2022 13:18:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 413E660B0A for ; Fri, 13 May 2022 17:18:42 +0000 (UTC) X-FDA: 79461379284.06.74884AD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id E37041400A5 for ; Fri, 13 May 2022 17:18:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2B6931F949; Fri, 13 May 2022 17:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652462320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lUuJK4eL9+OrReBYOWwXyTY//4zqDis40btPse6/uis=; b=ZfFAq7QzVD1bjBp+hkF5Z3fIv8AxgN0GzCRe9/I5WP8uaXdZ+RPtceXWSsm6MUZFQnXRSC 2oKg8kF5CJh4K3Mi+mNb8k/06l/ppvpwpWERxZqevlMKpjNhxXkNBOSwii9lXxf/7qjD+u vNfpJWgXzl11DC15sWKmZHQbjp4oyFE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D660013446; Fri, 13 May 2022 17:18:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vARDM++SfmIeUgAAMHmgww (envelope-from ); Fri, 13 May 2022 17:18:39 +0000 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: void@manifault.com Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, mkoutny@suse.com, roman.gushchin@linux.dev, shakeelb@google.com, tj@kernel.org, Richard Palethorpe Subject: [PATCH 0/4] memcontrol selftests fixups Date: Fri, 13 May 2022 19:18:07 +0200 Message-Id: <20220513171811.730-1-mkoutny@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E37041400A5 X-Stat-Signature: zkwmkxmarff49rc7hfi6x7w48u7kj8th Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZfFAq7Qz; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com X-Rspam-User: X-HE-Tag: 1652462306-568081 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello. I'm just flushing the simple patches to make memcontrol selftests check the events behavior we had consensus about (test_memcg_low fails). (I've dropped to goto macros for now.) (test_memcg_reclaim, test_memcg_swap_max fail for me now but it's present even before the refactoring.) The only bigger change is adjustment of the protected values to make tests succeed with the given tolerance. It's based on mm-stable [1] commit e240ac52f7da. AFAIC, the fixup and partial reverts may be folded into respective commits. Let me know if it should be (re)based on something else. Thanks, Michal [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/tools/testing/selftests/cgroup?h=mm-stable Michal Koutný (4): selftests: memcg: Fix compilation selftests: memcg: Expect no low events in unprotected sibling selftests: memcg: Adjust expected reclaim values of protected cgroups selftests: memcg: Remove protection from top level memcg .../selftests/cgroup/test_memcontrol.c | 59 +++++++++---------- 1 file changed, 29 insertions(+), 30 deletions(-) -- 2.35.3