From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 4/4] net: call skb_defer_free_flush() before each napi_poll()
Date: Mon, 16 May 2022 11:56:34 -0700 [thread overview]
Message-ID: <20220516115634.4417e3eb@kernel.org> (raw)
In-Reply-To: <CANn89iL9xw83hEGA4=K-F1qkjyRhvAJ85c9W5nY1Fsmq777V0A@mail.gmail.com>
On Mon, 16 May 2022 11:26:14 -0700 Eric Dumazet wrote:
> On Mon, May 16, 2022 at 11:21 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Sun, 15 May 2022 21:24:56 -0700 Eric Dumazet wrote:
> > > -end:
> > > - skb_defer_free_flush(sd);
> > > +end:;
> >
> > Sorry for the nit pick but can I remove this and just return like we
> > did before f3412b3879b4? Is there a reason such "label:;}" is good?
>
> I thought that having a return in the middle of this function would
> hurt us at some point.
I guess personal preference. Let's leave it unless someone else shares
my disregard for pointlessly jumping to the closing bracket :)
next prev parent reply other threads:[~2022-05-16 18:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 4:24 [PATCH net-next 0/4] net: polish skb defer freeing Eric Dumazet
2022-05-16 4:24 ` [PATCH net-next 1/4] net: fix possible race in skb_attempt_defer_free() Eric Dumazet
2022-05-16 18:15 ` Jakub Kicinski
2022-05-16 18:24 ` Eric Dumazet
2022-05-16 18:54 ` Jakub Kicinski
2022-05-16 4:24 ` [PATCH net-next 2/4] net: use napi_consume_skb() in skb_defer_free_flush() Eric Dumazet
2022-05-16 4:24 ` [PATCH net-next 3/4] net: add skb_defer_max sysctl Eric Dumazet
2022-05-16 20:39 ` Jakub Kicinski
2022-05-16 20:43 ` Eric Dumazet
2022-05-16 4:24 ` [PATCH net-next 4/4] net: call skb_defer_free_flush() before each napi_poll() Eric Dumazet
2022-05-16 18:21 ` Jakub Kicinski
2022-05-16 18:26 ` Eric Dumazet
2022-05-16 18:56 ` Jakub Kicinski [this message]
2022-05-16 10:40 ` [PATCH net-next 0/4] net: polish skb defer freeing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516115634.4417e3eb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.