From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957DAC4332F for ; Mon, 16 May 2022 10:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242766AbiEPKny (ORCPT ); Mon, 16 May 2022 06:43:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242812AbiEPKnl (ORCPT ); Mon, 16 May 2022 06:43:41 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8EFB1DC; Mon, 16 May 2022 03:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652697810; x=1684233810; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bq57x6TVD4fbOFuNt0pXx4+SkjFnfxJO4hgo5uenDQs=; b=R8aOpmx+J7CyN+Mi4wDWdb5vaHG0iLFSvjIBDhwj73GauQN3X6APDYuK 8QVnZFB5QbhoqB8U75kiKZ9WmNMRU9OraCwCSmai/J/r9umMJbLiztNAU rOkZ99vZKfic9oWNLJrZJl6l1KSksP1Zafuq69kIvGx1m/U1SWcvM+Chy cIS/gbSKM9FwLwVsUzX/btZCNCIVgHdTUaVpmvn1o0dhKUmOk9uk7KhZi sCPHT7ocXiK2saXsFE7VyYVtE7M50mjn3aIwd6g+1vFrOZ0/Xftcje2hz pLAGI4HAlT9TJ7prjx9kmClO/ODH04ekqig3kb8Y08Y0uLx0RFZH/pY7u Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="251306720" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="251306720" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 03:43:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="672290564" Received: from lkp-server02.sh.intel.com (HELO 0628dcddc537) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2022 03:43:27 -0700 Received: from kbuild by 0628dcddc537 with local (Exim 4.95) (envelope-from ) id 1nqYCE-000018-Gj; Mon, 16 May 2022 10:43:26 +0000 Date: Mon, 16 May 2022 18:42:34 +0800 From: kernel test robot To: Anand Moon , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Anand Moon Subject: Re: [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422 Message-ID: <202205161820.8rHIcsvI-lkp@intel.com> References: <20220515064126.1424-5-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220515064126.1424-5-linux.amoon@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Anand, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ec7f49619d8ee13e108740c82f942cd401b989e9] url: https://github.com/intel-lab-lkp/linux/commits/Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 base: ec7f49619d8ee13e108740c82f942cd401b989e9 config: hexagon-randconfig-r033-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161820.8rHIcsvI-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/eb50b0c2100fabd6d09b87abd11f52c5295512e8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 git checkout eb50b0c2100fabd6d09b87abd11f52c5295512e8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/thermal/samsung/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/thermal/samsung/exynos_tmu.c:929:40: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare] if (data->soc == SOC_ARCH_EXYNOS5420 && ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 1 warning generated. vim +929 drivers/thermal/samsung/exynos_tmu.c 865 866 static int exynos_map_dt_data(struct platform_device *pdev) 867 { 868 struct exynos_tmu_data *data = platform_get_drvdata(pdev); 869 struct resource res; 870 871 if (!data || !pdev->dev.of_node) 872 return -ENODEV; 873 874 data->id = of_alias_get_id(pdev->dev.of_node, "tmuctrl"); 875 if (data->id < 0) 876 data->id = 0; 877 878 data->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); 879 if (data->irq <= 0) { 880 dev_err(&pdev->dev, "failed to get IRQ\n"); 881 return -ENODEV; 882 } 883 884 if (of_address_to_resource(pdev->dev.of_node, 0, &res)) { 885 dev_err(&pdev->dev, "failed to get Resource 0\n"); 886 return -ENODEV; 887 } 888 889 data->base = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); 890 if (!data->base) { 891 dev_err(&pdev->dev, "Failed to ioremap memory\n"); 892 return -EADDRNOTAVAIL; 893 } 894 895 data->soc = (enum soc_type)of_device_get_match_data(&pdev->dev); 896 897 switch (data->soc) { 898 case SOC_ARCH_EXYNOS4210: 899 data->tmu_set_trip_temp = exynos4210_tmu_set_trip_temp; 900 data->tmu_set_trip_hyst = exynos4210_tmu_set_trip_hyst; 901 data->tmu_initialize = exynos4210_tmu_initialize; 902 data->tmu_control = exynos4210_tmu_control; 903 data->tmu_read = exynos4210_tmu_read; 904 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 905 data->ntrip = 4; 906 data->gain = 15; 907 data->reference_voltage = 7; 908 data->efuse_value = 55; 909 data->min_efuse_value = 40; 910 data->max_efuse_value = 100; 911 break; 912 case SOC_ARCH_EXYNOS3250: 913 case SOC_ARCH_EXYNOS4412: 914 case SOC_ARCH_EXYNOS5250: 915 case SOC_ARCH_EXYNOS5260: 916 case SOC_ARCH_EXYNOS5420: 917 case SOC_ARCH_EXYNOS5420_TRIMINFO: 918 data->tmu_set_trip_temp = exynos4412_tmu_set_trip_temp; 919 data->tmu_set_trip_hyst = exynos4412_tmu_set_trip_hyst; 920 data->tmu_initialize = exynos4412_tmu_initialize; 921 data->tmu_control = exynos4210_tmu_control; 922 data->tmu_read = exynos4412_tmu_read; 923 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 924 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 925 data->ntrip = 4; 926 data->gain = 8; 927 data->reference_voltage = 16; 928 data->efuse_value = 55; > 929 if (data->soc == SOC_ARCH_EXYNOS5420 && 930 data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) { 931 data->min_efuse_value = 16; 932 data->max_efuse_value = 76; 933 } else { 934 data->min_efuse_value = 40; 935 data->max_efuse_value = 100; 936 } 937 break; 938 case SOC_ARCH_EXYNOS5433: 939 data->tmu_set_trip_temp = exynos5433_tmu_set_trip_temp; 940 data->tmu_set_trip_hyst = exynos5433_tmu_set_trip_hyst; 941 data->tmu_initialize = exynos5433_tmu_initialize; 942 data->tmu_control = exynos5433_tmu_control; 943 data->tmu_read = exynos4412_tmu_read; 944 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 945 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 946 data->ntrip = 8; 947 data->gain = 8; 948 if (res.start == EXYNOS5433_G3D_BASE) 949 data->reference_voltage = 23; 950 else 951 data->reference_voltage = 16; 952 data->efuse_value = 75; 953 data->min_efuse_value = 40; 954 data->max_efuse_value = 150; 955 break; 956 case SOC_ARCH_EXYNOS7: 957 data->tmu_set_trip_temp = exynos7_tmu_set_trip_temp; 958 data->tmu_set_trip_hyst = exynos7_tmu_set_trip_hyst; 959 data->tmu_initialize = exynos7_tmu_initialize; 960 data->tmu_control = exynos7_tmu_control; 961 data->tmu_read = exynos7_tmu_read; 962 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 963 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 964 data->ntrip = 8; 965 data->gain = 9; 966 data->reference_voltage = 17; 967 data->efuse_value = 75; 968 data->min_efuse_value = 15; 969 data->max_efuse_value = 100; 970 break; 971 default: 972 dev_err(&pdev->dev, "Platform not supported\n"); 973 return -EINVAL; 974 } 975 976 data->cal_type = TYPE_ONE_POINT_TRIMMING; 977 978 /* 979 * Check if the TMU shares some registers and then try to map the 980 * memory of common registers. 981 */ 982 if (data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) 983 return 0; 984 985 if (of_address_to_resource(pdev->dev.of_node, 1, &res)) { 986 dev_err(&pdev->dev, "failed to get Resource 1\n"); 987 return -ENODEV; 988 } 989 990 data->base_second = devm_ioremap(&pdev->dev, res.start, 991 resource_size(&res)); 992 if (!data->base_second) { 993 dev_err(&pdev->dev, "Failed to ioremap memory\n"); 994 return -ENOMEM; 995 } 996 997 return 0; 998 } 999 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 359C5C433F5 for ; Mon, 16 May 2022 10:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y+sqxrp8LMv3x/I9kmS5qMxceVIoEnFdj/1EoAhRShY=; b=0kcrbME6WgdSDH e4+gmYQ7aYD1HuOr3LPkdhkn655u6DxPxu9E6N/Hsd9LAy9aC5FPZ8uaMLU+6be3mR6BrP10IQfFm xuwljvfvY3RDDkFl7xdxm/DsLFehWoq4o+8UL4+B5ZyVpx1oSFqZHvyQUnACMWNiUd6GY4OsD8upe Obzogj7LkUiSopSuE5QO6jGFLnXDW70JuKa+0zq4k2nYfkHkZtrQ6k9HUS0GVz82mvt5hm4txnixG wJeu8kG+tIWIc/D9Lbu989iWIVnCKI3qPRrlMxOzz5EP8G69M0f5AHRUX9BZjy2zI4QJbRbGnQ4Zr 3rd9MmB7RD1n/yopOXsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqYCV-007A9G-QG; Mon, 16 May 2022 10:43:43 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqYCL-007A4m-JY for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 10:43:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652697813; x=1684233813; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bq57x6TVD4fbOFuNt0pXx4+SkjFnfxJO4hgo5uenDQs=; b=VSV+DdyDKf3KIG4lQvun7/dA1+0i6KsNyFr0AYWdIQK9ls+XsynaoV6e V+k84xnEHEc/Yfwv6xR8GyorLL/yjKBfRL5IDvglP6MptfPq91JB6cjD7 1nt9Uo+dxtUlfGn92q0FHjDfWBI6fftt4DcmxDaqioVb0JIqSLf7+xilC 5pEFlCiAIfSMUqBdtOKZ4n8EhLAriRT4PEFQlqJLP0nHmwL9ds6ANexDz 4p0B2E2dwMkLwlqGThnR04rhVIqYgAzjfea1JQMjA1of8Sl4Fk6/iXUYg wync7ewM6UMzIPXeIymZPvpAeSH5/C7JCj7SxFJrNgmxFMGrPZT0N0n4N g==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="270918889" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="270918889" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 03:43:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="672290564" Received: from lkp-server02.sh.intel.com (HELO 0628dcddc537) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2022 03:43:27 -0700 Received: from kbuild by 0628dcddc537 with local (Exim 4.95) (envelope-from ) id 1nqYCE-000018-Gj; Mon, 16 May 2022 10:43:26 +0000 Date: Mon, 16 May 2022 18:42:34 +0800 From: kernel test robot To: Anand Moon , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Anand Moon Subject: Re: [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422 Message-ID: <202205161820.8rHIcsvI-lkp@intel.com> References: <20220515064126.1424-5-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220515064126.1424-5-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_034333_717451_45F79D50 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anand, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ec7f49619d8ee13e108740c82f942cd401b989e9] url: https://github.com/intel-lab-lkp/linux/commits/Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 base: ec7f49619d8ee13e108740c82f942cd401b989e9 config: hexagon-randconfig-r033-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161820.8rHIcsvI-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/eb50b0c2100fabd6d09b87abd11f52c5295512e8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 git checkout eb50b0c2100fabd6d09b87abd11f52c5295512e8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/thermal/samsung/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/thermal/samsung/exynos_tmu.c:929:40: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare] if (data->soc == SOC_ARCH_EXYNOS5420 && ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 1 warning generated. vim +929 drivers/thermal/samsung/exynos_tmu.c 865 866 static int exynos_map_dt_data(struct platform_device *pdev) 867 { 868 struct exynos_tmu_data *data = platform_get_drvdata(pdev); 869 struct resource res; 870 871 if (!data || !pdev->dev.of_node) 872 return -ENODEV; 873 874 data->id = of_alias_get_id(pdev->dev.of_node, "tmuctrl"); 875 if (data->id < 0) 876 data->id = 0; 877 878 data->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); 879 if (data->irq <= 0) { 880 dev_err(&pdev->dev, "failed to get IRQ\n"); 881 return -ENODEV; 882 } 883 884 if (of_address_to_resource(pdev->dev.of_node, 0, &res)) { 885 dev_err(&pdev->dev, "failed to get Resource 0\n"); 886 return -ENODEV; 887 } 888 889 data->base = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); 890 if (!data->base) { 891 dev_err(&pdev->dev, "Failed to ioremap memory\n"); 892 return -EADDRNOTAVAIL; 893 } 894 895 data->soc = (enum soc_type)of_device_get_match_data(&pdev->dev); 896 897 switch (data->soc) { 898 case SOC_ARCH_EXYNOS4210: 899 data->tmu_set_trip_temp = exynos4210_tmu_set_trip_temp; 900 data->tmu_set_trip_hyst = exynos4210_tmu_set_trip_hyst; 901 data->tmu_initialize = exynos4210_tmu_initialize; 902 data->tmu_control = exynos4210_tmu_control; 903 data->tmu_read = exynos4210_tmu_read; 904 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 905 data->ntrip = 4; 906 data->gain = 15; 907 data->reference_voltage = 7; 908 data->efuse_value = 55; 909 data->min_efuse_value = 40; 910 data->max_efuse_value = 100; 911 break; 912 case SOC_ARCH_EXYNOS3250: 913 case SOC_ARCH_EXYNOS4412: 914 case SOC_ARCH_EXYNOS5250: 915 case SOC_ARCH_EXYNOS5260: 916 case SOC_ARCH_EXYNOS5420: 917 case SOC_ARCH_EXYNOS5420_TRIMINFO: 918 data->tmu_set_trip_temp = exynos4412_tmu_set_trip_temp; 919 data->tmu_set_trip_hyst = exynos4412_tmu_set_trip_hyst; 920 data->tmu_initialize = exynos4412_tmu_initialize; 921 data->tmu_control = exynos4210_tmu_control; 922 data->tmu_read = exynos4412_tmu_read; 923 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 924 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 925 data->ntrip = 4; 926 data->gain = 8; 927 data->reference_voltage = 16; 928 data->efuse_value = 55; > 929 if (data->soc == SOC_ARCH_EXYNOS5420 && 930 data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) { 931 data->min_efuse_value = 16; 932 data->max_efuse_value = 76; 933 } else { 934 data->min_efuse_value = 40; 935 data->max_efuse_value = 100; 936 } 937 break; 938 case SOC_ARCH_EXYNOS5433: 939 data->tmu_set_trip_temp = exynos5433_tmu_set_trip_temp; 940 data->tmu_set_trip_hyst = exynos5433_tmu_set_trip_hyst; 941 data->tmu_initialize = exynos5433_tmu_initialize; 942 data->tmu_control = exynos5433_tmu_control; 943 data->tmu_read = exynos4412_tmu_read; 944 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 945 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 946 data->ntrip = 8; 947 data->gain = 8; 948 if (res.start == EXYNOS5433_G3D_BASE) 949 data->reference_voltage = 23; 950 else 951 data->reference_voltage = 16; 952 data->efuse_value = 75; 953 data->min_efuse_value = 40; 954 data->max_efuse_value = 150; 955 break; 956 case SOC_ARCH_EXYNOS7: 957 data->tmu_set_trip_temp = exynos7_tmu_set_trip_temp; 958 data->tmu_set_trip_hyst = exynos7_tmu_set_trip_hyst; 959 data->tmu_initialize = exynos7_tmu_initialize; 960 data->tmu_control = exynos7_tmu_control; 961 data->tmu_read = exynos7_tmu_read; 962 data->tmu_set_emulation = exynos4412_tmu_set_emulation; 963 data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; 964 data->ntrip = 8; 965 data->gain = 9; 966 data->reference_voltage = 17; 967 data->efuse_value = 75; 968 data->min_efuse_value = 15; 969 data->max_efuse_value = 100; 970 break; 971 default: 972 dev_err(&pdev->dev, "Platform not supported\n"); 973 return -EINVAL; 974 } 975 976 data->cal_type = TYPE_ONE_POINT_TRIMMING; 977 978 /* 979 * Check if the TMU shares some registers and then try to map the 980 * memory of common registers. 981 */ 982 if (data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) 983 return 0; 984 985 if (of_address_to_resource(pdev->dev.of_node, 1, &res)) { 986 dev_err(&pdev->dev, "failed to get Resource 1\n"); 987 return -ENODEV; 988 } 989 990 data->base_second = devm_ioremap(&pdev->dev, res.start, 991 resource_size(&res)); 992 if (!data->base_second) { 993 dev_err(&pdev->dev, "Failed to ioremap memory\n"); 994 return -ENOMEM; 995 } 996 997 return 0; 998 } 999 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel