From: kernel test robot <lkp@intel.com>
To: "Yaşar Arabacı" <yasar11732@gmail.com>, gregkh@linuxfoundation.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
paulo.miguel.almeida.rodenas@gmail.com, dan.carpenter@oracle.com,
alexandre.belloni@bootlin.com, realwakka@gmail.com,
u.kleine-koenig@pengutronix.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Yaşar Arabacı" <yasar11732@gmail.com>
Subject: Re: [PATCH] Staging: pi433: Don't use ioctl for per-client configuration
Date: Mon, 16 May 2022 19:23:17 +0800 [thread overview]
Message-ID: <202205161930.aGSjQp2u-lkp@intel.com> (raw)
In-Reply-To: <20220515104711.94567-1-yasar11732@gmail.com>
Hi "Yaşar,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Ya-ar-Arabac/Staging-pi433-Don-t-use-ioctl-for-per-client-configuration/20220515-185057
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e41f7a5521d7f03dca99e3207633df71740569dd
config: riscv-randconfig-r036-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161930.aGSjQp2u-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/0cfbff215eb0e9e558af6b491d319fc736a927c6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ya-ar-Arabac/Staging-pi433-Don-t-use-ioctl-for-per-client-configuration/20220515-185057
git checkout 0cfbff215eb0e9e558af6b491d319fc736a927c6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/staging/pi433/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/pi433/pi433_if.c:832:4: warning: variable 'required' is uninitialized when used here [-Wuninitialized]
required, available);
^~~~~~~~
include/linux/dev_printk.h:155:39: note: expanded from macro 'dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:167:19: note: expanded from macro 'dynamic_dev_dbg'
dev, fmt, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/staging/pi433/pi433_if.c:801:24: note: initialize the variable 'required' to silence this warning
unsigned int required, available, copied;
^
= 0
1 warning generated.
vim +/required +832 drivers/staging/pi433/pi433_if.c
874bcba65f9a3a Marcus Wolf 2017-07-16 792
874bcba65f9a3a Marcus Wolf 2017-07-16 793 static ssize_t
874bcba65f9a3a Marcus Wolf 2017-07-16 794 pi433_write(struct file *filp, const char __user *buf,
874bcba65f9a3a Marcus Wolf 2017-07-16 795 size_t count, loff_t *f_pos)
874bcba65f9a3a Marcus Wolf 2017-07-16 796 {
874bcba65f9a3a Marcus Wolf 2017-07-16 797 struct pi433_instance *instance;
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 798 struct pi433_tx_cfg *tx_cfg;
874bcba65f9a3a Marcus Wolf 2017-07-16 799 struct pi433_device *device;
57f8965af417f9 Stefano Manni 2017-11-16 800 int retval;
5451dab9b7f546 Valentin Vidic 2018-04-19 801 unsigned int required, available, copied;
874bcba65f9a3a Marcus Wolf 2017-07-16 802
874bcba65f9a3a Marcus Wolf 2017-07-16 803 instance = filp->private_data;
874bcba65f9a3a Marcus Wolf 2017-07-16 804 device = instance->device;
874bcba65f9a3a Marcus Wolf 2017-07-16 805
63688e61d5629c Sophie Matter 2018-07-11 806 /*
63688e61d5629c Sophie Matter 2018-07-11 807 * check, whether internal buffer (tx thread) is big enough
63688e61d5629c Sophie Matter 2018-07-11 808 * for requested size
63688e61d5629c Sophie Matter 2018-07-11 809 */
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 810 if (unlikely(count > MAX_MSG_SIZE))
874bcba65f9a3a Marcus Wolf 2017-07-16 811 return -EMSGSIZE;
874bcba65f9a3a Marcus Wolf 2017-07-16 812
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 813 if (unlikely(count < sizeof(struct pi433_tx_cfg)))
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 814 return -EMSGSIZE;
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 815
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 816 tx_cfg = (struct pi433_tx_cfg *)buf;
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 817
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 818 if (unlikely(count != sizeof(struct pi433_tx_cfg)) + tx_cfg->payload_size)
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 819 return -EMSGSIZE;
ce514dadc61a53 Paulo Miguel Almeida 2022-01-15 820
63688e61d5629c Sophie Matter 2018-07-11 821 /*
63688e61d5629c Sophie Matter 2018-07-11 822 * write the following sequence into fifo:
056eeda2f9e637 Derek Robson 2017-07-22 823 * - tx_cfg
056eeda2f9e637 Derek Robson 2017-07-22 824 * - size of message
056eeda2f9e637 Derek Robson 2017-07-22 825 * - message
056eeda2f9e637 Derek Robson 2017-07-22 826 */
874bcba65f9a3a Marcus Wolf 2017-07-16 827 mutex_lock(&device->tx_fifo_lock);
5451dab9b7f546 Valentin Vidic 2018-04-19 828
5451dab9b7f546 Valentin Vidic 2018-04-19 829 available = kfifo_avail(&device->tx_fifo);
0cfbff215eb0e9 Yaşar Arabacı 2022-05-15 830 if (count > available) {
1b6a6147374eb3 Paulo Miguel Almeida 2022-02-07 831 dev_dbg(device->dev, "write to fifo failed: %d bytes required but %d available\n",
5451dab9b7f546 Valentin Vidic 2018-04-19 @832 required, available);
5451dab9b7f546 Valentin Vidic 2018-04-19 833 mutex_unlock(&device->tx_fifo_lock);
5451dab9b7f546 Valentin Vidic 2018-04-19 834 return -EAGAIN;
5451dab9b7f546 Valentin Vidic 2018-04-19 835 }
5451dab9b7f546 Valentin Vidic 2018-04-19 836
874bcba65f9a3a Marcus Wolf 2017-07-16 837 retval = kfifo_from_user(&device->tx_fifo, buf, count, &copied);
874bcba65f9a3a Marcus Wolf 2017-07-16 838 if (retval || copied != count)
874bcba65f9a3a Marcus Wolf 2017-07-16 839 goto abort;
874bcba65f9a3a Marcus Wolf 2017-07-16 840
874bcba65f9a3a Marcus Wolf 2017-07-16 841 mutex_unlock(&device->tx_fifo_lock);
874bcba65f9a3a Marcus Wolf 2017-07-16 842
874bcba65f9a3a Marcus Wolf 2017-07-16 843 /* start transfer */
874bcba65f9a3a Marcus Wolf 2017-07-16 844 wake_up_interruptible(&device->tx_wait_queue);
1b6a6147374eb3 Paulo Miguel Almeida 2022-02-07 845 dev_dbg(device->dev, "write: generated new msg with %d bytes.\n", copied);
874bcba65f9a3a Marcus Wolf 2017-07-16 846
dd1114693bcc7d Oliver Graute 2017-12-19 847 return copied;
874bcba65f9a3a Marcus Wolf 2017-07-16 848
874bcba65f9a3a Marcus Wolf 2017-07-16 849 abort:
5451dab9b7f546 Valentin Vidic 2018-04-19 850 dev_warn(device->dev,
1b6a6147374eb3 Paulo Miguel Almeida 2022-02-07 851 "write to fifo failed, non recoverable: 0x%x\n", retval);
874bcba65f9a3a Marcus Wolf 2017-07-16 852 mutex_unlock(&device->tx_fifo_lock);
874bcba65f9a3a Marcus Wolf 2017-07-16 853 return -EAGAIN;
874bcba65f9a3a Marcus Wolf 2017-07-16 854 }
874bcba65f9a3a Marcus Wolf 2017-07-16 855
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-16 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 10:47 [PATCH] Staging: pi433: Don't use ioctl for per-client configuration Yaşar Arabacı
2022-05-15 10:54 ` Greg KH
2022-05-15 10:55 ` Greg KH
2022-05-16 7:33 ` Dan Carpenter
2022-05-16 17:23 ` Yaşar Arabacı
2022-05-16 11:23 ` kernel test robot [this message]
2022-05-16 15:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205161930.aGSjQp2u-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=paulo.miguel.almeida.rodenas@gmail.com \
--cc=realwakka@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yasar11732@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.