From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Linus Kaschulla <linus@cosmos-ink.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] fs/squashfs: Add block size option
Date: Tue, 17 May 2022 08:05:45 +0200 [thread overview]
Message-ID: <20220517060545.GP1597494@scaer> (raw)
In-Reply-To: <20220517053803.GN1597494@scaer>
Linus, All,
On 2022-05-17 07:38 +0200, Yann E. MORIN spake thusly:
> On 2022-05-17 03:24 +0000, Linus Kaschulla spake thusly:
> > This patch adds the ability to select from common block sizes
> > which for example can aid in improving compression ratio.
[--SNIP--]
> > +ifeq ($(BR2_TARGET_ROOTFS_SQUASHFS4_BS_64K),y)
I got a bit confused here, in fact: BR2_TARGET_ROOTFS_SQUASHFS4_BS_64K
has a '4' after the 'SQUASHFS', but the options in the choice do not,
so none of this conditional block was ever hit in fact. I dropped it.
And I see where that '4' comes from: you mimicked the compression type
choice. I totally missed that initially. That's a remnant from days pat,
and if we were to add that code today, we'd not keep the '4'.
An yway, applied to master with:
- drop spurious boolean-based setting in .mk
- split into multi-line
- qstrip variable expansion
Thanks!
> Finally, it would have been nice to add two test cases that at least the
> 4K and 1024K options do work (the existing test tests the defaultm i.e
> 128K). Tests are in: support/testing/tests/fs/test_squashfs.py
Still interested in seeing a test-case, though! ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-17 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 3:24 [Buildroot] [PATCH 1/2] fs/squashfs: Add block size option Linus Kaschulla via buildroot
2022-05-17 3:24 ` [Buildroot] [PATCH 2/2] fs/squashfs: Add option to compress with extreme options Linus Kaschulla via buildroot
2022-05-17 6:09 ` Yann E. MORIN
2022-05-17 5:38 ` [Buildroot] [PATCH 1/2] fs/squashfs: Add block size option Yann E. MORIN
2022-05-17 6:05 ` Yann E. MORIN [this message]
2022-05-17 14:04 ` Linus via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517060545.GP1597494@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=linus@cosmos-ink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.