From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 03/12] xfs/348: golden output is not correct
Date: Tue, 17 May 2022 17:01:02 +1000 [thread overview]
Message-ID: <20220517070111.1381936-4-david@fromorbit.com> (raw)
In-Reply-To: <20220517070111.1381936-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
The output of xfs/348 encodes the observed behaviour at the time the
test was written, not the correct behaviour that should occur.
Recent improvements in verification checking in the upstream kernel
(1eb70f54c445 "xfs: validate inode fork size against fork format")
have resulted in the kernel having correct behaviour and now the
test fails. Fix the test output to reflect correct behaviour.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
tests/xfs/348.out | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/348.out b/tests/xfs/348.out
index 0d407718..9130f42a 100644
--- a/tests/xfs/348.out
+++ b/tests/xfs/348.out
@@ -108,7 +108,7 @@ would have junked entry "DATA" in directory PARENT_INO
would have junked entry "EMPTY" in directory PARENT_INO
would have junked entry "FIFO" in directory PARENT_INO
stat: 'SCRATCH_MNT/test/DIR' is a directory
-stat: 'SCRATCH_MNT/test/DATA' is a directory
+stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
@@ -240,7 +240,7 @@ would have junked entry "DIR" in directory PARENT_INO
would have junked entry "EMPTY" in directory PARENT_INO
would have junked entry "FIFO" in directory PARENT_INO
stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning
-stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
+stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link
stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
--
2.35.1
next prev parent reply other threads:[~2022-05-17 7:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:00 [PATCH 00/13 V2] fstests: fixes and more fixes Dave Chinner
2022-05-17 7:01 ` [PATCH 01/12] fstests: filter quota warnings Dave Chinner
2022-05-17 7:01 ` [PATCH 02/12] xfs/122: add attribute log formats to test output Dave Chinner
2022-05-17 7:01 ` Dave Chinner [this message]
2022-05-17 7:01 ` [PATCH 04/12] fstests: fix group list generation for whacky test names Dave Chinner
2022-05-19 18:52 ` Darrick J. Wong
2022-05-20 8:36 ` Zorro Lang
2022-05-20 8:54 ` Zorro Lang
2022-05-20 9:25 ` Zorro Lang
2022-05-20 16:23 ` Darrick J. Wong
2022-05-21 0:27 ` Zorro Lang
2022-05-17 7:01 ` [PATCH 05/12] README: document _begin_fstests better Dave Chinner
2022-05-19 23:13 ` Darrick J. Wong
2022-05-20 1:58 ` Dave Chinner
2022-05-20 2:02 ` Darrick J. Wong
2022-05-20 5:23 ` Zorro Lang
2022-05-20 5:42 ` Dave Chinner
2022-05-20 6:16 ` Zorro Lang
2022-05-17 7:01 ` [PATCH 06/12] xfs/148: make test debuggable Dave Chinner
2022-05-19 18:55 ` Darrick J. Wong
2022-05-17 7:01 ` [PATCH 07/12] xfs/148: fix failure from bad shortform size assumptions Dave Chinner
2022-05-20 7:34 ` Zorro Lang
2022-05-21 23:22 ` Dave Chinner
2022-05-17 7:01 ` [PATCH 08/12] generic/081: don't run on DAX capable devices Dave Chinner
2022-05-18 5:11 ` Dave Chinner
2022-05-17 7:01 ` [PATCH 12/12] xfs/191: remove broken test Dave Chinner
2022-05-19 18:55 ` Darrick J. Wong
2022-05-17 7:49 ` [PATCH 00/13 V2] fstests: fixes and more fixes Dave Chinner
2022-05-17 8:24 ` Zorro Lang
2022-05-17 21:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517070111.1381936-4-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.