All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl,
	mchehab@kernel.org
Subject: Re: [PATCH] au0828: allow higher speeds
Date: Tue, 17 May 2022 16:19:39 +0300	[thread overview]
Message-ID: <20220517131939.GL29930@kadam> (raw)
In-Reply-To: <7f809320-4dd5-c8e3-1a77-e9d8627d292d@suse.com>

On Tue, May 17, 2022 at 03:15:08PM +0200, Oliver Neukum wrote:
> 
> 
> On 17.05.22 15:03, Dan Carpenter wrote:
> > On Tue, May 17, 2022 at 02:54:47PM +0200, Oliver Neukum wrote:
> >> This should be taken as a minimum speed.
> >>
> > Did you find this by testing or by reviewing the code?  What does this
> Review.
> > bug look like to the user?
> The device will refuse to work if you connect it via a USB 3.0 hub
> to XHCI

Please add that to the commit message.  It really does help.

regards,
dan carpenter


      reply	other threads:[~2022-05-17 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 12:54 [PATCH] au0828: allow higher speeds Oliver Neukum
2022-05-17 13:03 ` Dan Carpenter
2022-05-17 13:15   ` Oliver Neukum
2022-05-17 13:19     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517131939.GL29930@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.