From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [PATCH v1 2/2] pinctrl: intel: Drop unsued irqchip member in struct intel_pinctrl
Date: Tue, 17 May 2022 14:55:35 +0800 [thread overview]
Message-ID: <202205171446.KkMJMsjU-lkp@intel.com> (raw)
In-Reply-To: <20220516185618.32448-2-andriy.shevchenko@linux.intel.com>
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on v5.18-rc7 next-20220516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-intel-make-irq_chip-immutable/20220517-025735
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220517/202205171446.KkMJMsjU-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/396b7abcd486a384c9b8fd7a0ecb13aff05e2163
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/pinctrl-intel-make-irq_chip-immutable/20220517-025735
git checkout 396b7abcd486a384c9b8fd7a0ecb13aff05e2163
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pinctrl/intel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/pinctrl/intel/pinctrl-cherryview.c:1614:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.name = "chv-gpio";
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1615:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.irq_startup = chv_gpio_irq_startup;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1616:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.irq_ack = chv_gpio_irq_ack;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1617:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.irq_mask = chv_gpio_irq_mask;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1618:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.irq_unmask = chv_gpio_irq_unmask;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1619:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.irq_set_type = chv_gpio_irq_type;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1620:9: error: no member named 'irqchip' in 'struct intel_pinctrl'
pctrl->irqchip.flags = IRQCHIP_SKIP_SET_WAKE;
~~~~~ ^
drivers/pinctrl/intel/pinctrl-cherryview.c:1622:27: error: no member named 'irqchip' in 'struct intel_pinctrl'
chip->irq.chip = &pctrl->irqchip;
~~~~~ ^
8 errors generated.
vim +1614 drivers/pinctrl/intel/pinctrl-cherryview.c
bd90633a5c5433b Hans de Goede 2019-11-14 1595
3ea2e2cabd2dc74 Andy Shevchenko 2020-07-27 1596 static int chv_gpio_probe(struct intel_pinctrl *pctrl, int irq)
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1597 {
293428f93260d45 Andy Shevchenko 2020-06-09 1598 const struct intel_community *community = &pctrl->communities[0];
36ad7b24486ae5e Andy Shevchenko 2020-04-01 1599 const struct intel_padgroup *gpp;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1600 struct gpio_chip *chip = &pctrl->chip;
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1601 struct device *dev = pctrl->dev;
7036502783729c2 Mika Westerberg 2017-04-10 1602 bool need_valid_mask = !dmi_check_system(chv_no_valid_mask);
03c4749dd6c7ff9 Mika Westerberg 2017-11-27 1603 int ret, i, irq_base;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1604
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1605 *chip = chv_gpio_chip;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1606
293428f93260d45 Andy Shevchenko 2020-06-09 1607 chip->ngpio = pctrl->soc->pins[pctrl->soc->npins - 1].number + 1;
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1608 chip->label = dev_name(dev);
bd90633a5c5433b Hans de Goede 2019-11-14 1609 chip->add_pin_ranges = chv_gpio_add_pin_ranges;
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1610 chip->parent = dev;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1611 chip->base = -1;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1612
b9a19bdbc843abd Hans de Goede 2019-11-14 1613 pctrl->irq = irq;
b9a19bdbc843abd Hans de Goede 2019-11-14 @1614 pctrl->irqchip.name = "chv-gpio";
b9a19bdbc843abd Hans de Goede 2019-11-14 1615 pctrl->irqchip.irq_startup = chv_gpio_irq_startup;
b9a19bdbc843abd Hans de Goede 2019-11-14 1616 pctrl->irqchip.irq_ack = chv_gpio_irq_ack;
b9a19bdbc843abd Hans de Goede 2019-11-14 1617 pctrl->irqchip.irq_mask = chv_gpio_irq_mask;
b9a19bdbc843abd Hans de Goede 2019-11-14 1618 pctrl->irqchip.irq_unmask = chv_gpio_irq_unmask;
b9a19bdbc843abd Hans de Goede 2019-11-14 1619 pctrl->irqchip.irq_set_type = chv_gpio_irq_type;
b9a19bdbc843abd Hans de Goede 2019-11-14 1620 pctrl->irqchip.flags = IRQCHIP_SKIP_SET_WAKE;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1621
b9a19bdbc843abd Hans de Goede 2019-11-14 1622 chip->irq.chip = &pctrl->irqchip;
b9a19bdbc843abd Hans de Goede 2019-11-14 1623 chip->irq.init_hw = chv_gpio_irq_init_hw;
b9a19bdbc843abd Hans de Goede 2019-11-14 1624 chip->irq.parent_handler = chv_gpio_irq_handler;
b9a19bdbc843abd Hans de Goede 2019-11-14 1625 chip->irq.num_parents = 1;
b9a19bdbc843abd Hans de Goede 2019-11-14 1626 chip->irq.parents = &pctrl->irq;
b9a19bdbc843abd Hans de Goede 2019-11-14 1627 chip->irq.default_type = IRQ_TYPE_NONE;
b9a19bdbc843abd Hans de Goede 2019-11-14 1628 chip->irq.handler = handle_bad_irq;
b9a19bdbc843abd Hans de Goede 2019-11-14 1629 if (need_valid_mask) {
b9a19bdbc843abd Hans de Goede 2019-11-14 1630 chip->irq.init_valid_mask = chv_init_irq_valid_mask;
b9a19bdbc843abd Hans de Goede 2019-11-14 1631 } else {
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1632 irq_base = devm_irq_alloc_descs(dev, -1, 0, pctrl->soc->npins, NUMA_NO_NODE);
845e405e5e6c9dc Grygorii Strashko 2017-10-03 1633 if (irq_base < 0) {
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1634 dev_err(dev, "Failed to allocate IRQ numbers\n");
845e405e5e6c9dc Grygorii Strashko 2017-10-03 1635 return irq_base;
845e405e5e6c9dc Grygorii Strashko 2017-10-03 1636 }
845e405e5e6c9dc Grygorii Strashko 2017-10-03 1637 }
845e405e5e6c9dc Grygorii Strashko 2017-10-03 1638
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1639 ret = devm_gpiochip_add_data(dev, chip, pctrl);
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1640 if (ret) {
db1b2a8caf5b495 Andy Shevchenko 2021-11-26 1641 dev_err(dev, "Failed to register gpiochip\n");
d1073418d952f6a Mika Westerberg 2016-09-20 1642 return ret;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1643 }
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1644
83b9dc11312f48a Mika Westerberg 2018-04-25 1645 if (!need_valid_mask) {
36ad7b24486ae5e Andy Shevchenko 2020-04-01 1646 for (i = 0; i < community->ngpps; i++) {
36ad7b24486ae5e Andy Shevchenko 2020-04-01 1647 gpp = &community->gpps[i];
83b9dc11312f48a Mika Westerberg 2018-04-25 1648
83b9dc11312f48a Mika Westerberg 2018-04-25 1649 irq_domain_associate_many(chip->irq.domain, irq_base,
36ad7b24486ae5e Andy Shevchenko 2020-04-01 1650 gpp->base, gpp->size);
36ad7b24486ae5e Andy Shevchenko 2020-04-01 1651 irq_base += gpp->size;
83b9dc11312f48a Mika Westerberg 2018-04-25 1652 }
83b9dc11312f48a Mika Westerberg 2018-04-25 1653 }
83b9dc11312f48a Mika Westerberg 2018-04-25 1654
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1655 return 0;
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1656 }
6e08d6bbebebcf7 Mika Westerberg 2014-11-03 1657
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-17 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 18:56 [PATCH v1 1/2] pinctrl: intel: make irq_chip immutable Andy Shevchenko
2022-05-16 18:56 ` [PATCH v1 2/2] pinctrl: intel: Drop unsued irqchip member in struct intel_pinctrl Andy Shevchenko
2022-05-17 6:55 ` kernel test robot [this message]
2022-05-17 8:28 ` kernel test robot
2022-05-17 10:09 ` [PATCH v1 1/2] pinctrl: intel: make irq_chip immutable Mika Westerberg
2022-05-17 16:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205171446.KkMJMsjU-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.