From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: yanjun.zhu@linux.dev, leon@kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/rxe: Compact the function free_rd_atomic_resource
Date: Tue, 17 May 2022 11:55:45 -0300 [thread overview]
Message-ID: <20220517145545.GG63055@ziepe.ca> (raw)
In-Reply-To: <c9e99081-f6aa-0167-77ff-57533b107e90@gmail.com>
On Tue, May 17, 2022 at 09:51:44AM -0500, Bob Pearson wrote:
> On 5/17/22 14:08, yanjun.zhu@linux.dev wrote:
> > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> >
> > Compact the function and move it to the header file.
> I have two issues with this patch.
>
> There is no advantage of having an inline function in a header file
> that is only called once. The compiler is perfectly capable of (and does)
> inlining a static function in a .c file if only called once. This just
> makes the code harder to read.
That is only if the function is static in the compilation unit, in
this case the only call site is in a different compilation unit
That still doesn't excuse putting it in a header file, but it does
suggest it could be just moved and made static.
> There is a patch in for-rc that gets rid of read.mr in favor of an rkey.
> This patch is out of date.
You are resending that with some fix?
Jason
next prev parent reply other threads:[~2022-05-17 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 19:08 [PATCH 1/1] RDMA/rxe: Compact the function free_rd_atomic_resource yanjun.zhu
2022-05-17 14:51 ` Bob Pearson
2022-05-17 14:55 ` Jason Gunthorpe [this message]
2022-05-17 15:14 ` Yanjun Zhu
2022-05-17 15:49 ` Bob Pearson
2022-05-19 14:00 ` Yanjun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517145545.GG63055@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.