From: Jakub Kicinski <kuba@kernel.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH] gcc: fix -Warray-compare
Date: Tue, 17 May 2022 18:50:35 -0700 [thread overview]
Message-ID: <20220517185035.4ee3dd8e@kernel.org> (raw)
In-Reply-To: <21708ede-f378-d20e-0b1d-410e946fcca5@suse.cz>
On Tue, 17 May 2022 16:19:16 +0200 Martin Liška wrote:
> Subject: [PATCH] gcc: fix -Warray-compare
The subject should be more like
eth: sun: cassini: remove dead code
>
> Fixes the following GCC warning:
>
> drivers/net/ethernet/sun/cassini.c:1316:29: error: comparison between two arrays [-Werror=array-compare]
> drivers/net/ethernet/sun/cassini.c:3783:34: error: comparison between two arrays [-Werror=array-compare]
Because AFAICT this comparison will always be true:
#define CAS_HP_ALT_FIRMWARE cas_prog_null
Hopefully DaveM will correct if I'm getting this wrong :)
next prev parent reply other threads:[~2022-05-18 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 14:19 [PATCH] gcc: fix -Warray-compare Martin Liška
2022-05-18 1:50 ` Jakub Kicinski [this message]
2022-05-18 7:18 ` [PATCH v2] eth: sun: cassini: remove dead code Martin Liška
2022-05-18 13:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517185035.4ee3dd8e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.