From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA87C433F5 for ; Tue, 17 May 2022 20:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352944AbiEQUfN (ORCPT ); Tue, 17 May 2022 16:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239770AbiEQUfM (ORCPT ); Tue, 17 May 2022 16:35:12 -0400 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A5F52B08; Tue, 17 May 2022 13:35:11 -0700 (PDT) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-f17f1acffeso115047fac.4; Tue, 17 May 2022 13:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GmVQSVvz0XOG6SjnV7V4V6/T41LZgX89awI2HyE+m1g=; b=M16Wo2uODFOMFu7LdbBn+yuWEHPxaWaHGQG0zRhOSXTlFMb6XbcrmKqXUCTsgm+NZf SKudcSJGY+9jLqa/p8TPEuSpUgiOeYILAkjcZAwrUgse3U3ko0wI/DalI2cZHsmxBu07 AnYifBKNTWSArJHJH4MJsY0xF4dwVF70aWWU1+fiRkS0Zr88+6U5vRlxzx81HQEbVvMz RUbx3kxZqqQnp/unR4qVdrng6cLl2J4IyW08qIn/PbEHEYalzre22x9QNtSQxpLpYIon nKyetfzPv6H6BWb+1X6mkWvXmdE2fkgSR1s5KnZBQsYCxHhybOkjv/vVA4Q9OrzLCZuG Y+HQ== X-Gm-Message-State: AOAM531jb3JeXT1J6a7O1q7yIPbg5qjsosZD7qotm1Krv5lbOFwJQzFk ktCsHUjgT8G5I3bubk/IeIyHeTFn1Q== X-Google-Smtp-Source: ABdhPJwVy5rMYvBSm6iJXKOoWVCYoOCbHdrII8531VFVtPAVHhEAMU0+Vo7aEjXF+Qq/rl3ZVqG6rw== X-Received: by 2002:a05:6870:311e:b0:de:bd67:b6c3 with SMTP id v30-20020a056870311e00b000debd67b6c3mr19403147oaa.268.1652819710483; Tue, 17 May 2022 13:35:10 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p206-20020acabfd7000000b0032617532120sm106697oif.48.2022.05.17.13.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 13:35:09 -0700 (PDT) Received: (nullmailer pid 1590333 invoked by uid 1000); Tue, 17 May 2022 20:35:08 -0000 Date: Tue, 17 May 2022 15:35:08 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, ansuelsmth@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 1/5] dt-bindings: net: add bitfield defines for Ethernet speeds Message-ID: <20220517203508.GA1587170-robh@kernel.org> References: <20220505135512.3486-1-zajec5@gmail.com> <20220505135512.3486-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505135512.3486-2-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 05, 2022 at 03:55:08PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This allows specifying multiple Ethernet speeds in a single DT uint32 > value. > > Signed-off-by: Rafał Miłecki > --- > include/dt-bindings/net/eth.h | 27 +++++++++++++++++++++++++++ ethernet.h > 1 file changed, 27 insertions(+) > create mode 100644 include/dt-bindings/net/eth.h > > diff --git a/include/dt-bindings/net/eth.h b/include/dt-bindings/net/eth.h > new file mode 100644 > index 000000000000..89caff09179b > --- /dev/null > +++ b/include/dt-bindings/net/eth.h > @@ -0,0 +1,27 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ Dual license > +/* > + * Device Tree constants for the Ethernet > + */ > + > +#ifndef _DT_BINDINGS_ETH_H > +#define _DT_BINDINGS_ETH_H > + > +#define SPEED_UNSPEC 0 > +#define SPEED_10 (1 << 0) > +#define SPEED_100 (1 << 1) > +#define SPEED_1000 (1 << 2) > +#define SPEED_2000 (1 << 3) > +#define SPEED_2500 (1 << 4) > +#define SPEED_5000 (1 << 5) > +#define SPEED_10000 (1 << 6) > +#define SPEED_14000 (1 << 7) > +#define SPEED_20000 (1 << 8) > +#define SPEED_25000 (1 << 9) > +#define SPEED_40000 (1 << 10) > +#define SPEED_50000 (1 << 11) > +#define SPEED_56000 (1 << 12) > +#define SPEED_100000 (1 << 13) > +#define SPEED_200000 (1 << 14) > +#define SPEED_400000 (1 << 15) These should probably have some namespace. ETH_*? > + > +#endif > -- > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28AD1C433F5 for ; Tue, 17 May 2022 20:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xLaF83QoMWa12/ueij2BLCnWAANjmYS26RUJFp8VAuA=; b=Jhou5E+FoW7YOM dya7L74XDnxcxIf80AzIfUG5H4cjvu4AGr8CTwm/Z33qSiOhBlKQVi9BAemamo9v9gEenPQ/SuwJU RoT7JYMQhbnsamEr8PIjtKheaPIgxmp7IbHc79K9+JInrlHDq3+N5OVlDEFIDAvbSC0iFu/Hf3flj VEVSPuGdVbvfjvo4dvGZVP/SZ6ectF3yJMLEjF6iFdpRKloJZ/Hf9U9jEofrb6xMsnTwhfNq98R+g zTV/d8+RzKdN8c3dRkJGd8QATcp5ugEOzU9MmgUfVpXRa0r3aAZf6qf2ugaVf7uxSEHFkFSyA1yxU CWULoYFViomFmP/6Sv1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr3uW-00Flwu-Uy; Tue, 17 May 2022 20:35:17 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr3uT-00FlvB-Uo for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 20:35:15 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e93bbb54f9so63124fac.12 for ; Tue, 17 May 2022 13:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GmVQSVvz0XOG6SjnV7V4V6/T41LZgX89awI2HyE+m1g=; b=rbtpBbK5ZTUJ0JxTT2mCfUfZ+snrf1CbmJq72EOOnBJnmmggNESJjMKixwWeCTQzg/ yEG0n+2nbgwjYQA3SGe/LXPoD8N+3RFiwU5t67DqNMDyvQBlzVF43lz3SZTDTB4gWyVv DpF4uebvRbbgScAxmh/Zuh3ebeURDaZEvYlMhScn8D28R3BbNe1TmlW9RfivCHTGmUY5 7JdDZJ+CBa1oxF17/5eWuZZL+5c8oFP4ilTu7hGsYq5QF5odZHUJATZM1lNVxTqDEfVf 6UiGO7PKPJqd5zUJwGkEnIf9NUwAcQ8xhUmCRfiw+nBALoET3R3oeB2qfReKEy6MpYqn /UFQ== X-Gm-Message-State: AOAM5305DD82+RrBQoIvIDewqvIcWDaEXMczsPazZZGLLcjHX4GrC5Y3 QRKXz6P/Q0GHqhR9YseLMQ== X-Google-Smtp-Source: ABdhPJwVy5rMYvBSm6iJXKOoWVCYoOCbHdrII8531VFVtPAVHhEAMU0+Vo7aEjXF+Qq/rl3ZVqG6rw== X-Received: by 2002:a05:6870:311e:b0:de:bd67:b6c3 with SMTP id v30-20020a056870311e00b000debd67b6c3mr19403147oaa.268.1652819710483; Tue, 17 May 2022 13:35:10 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p206-20020acabfd7000000b0032617532120sm106697oif.48.2022.05.17.13.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 13:35:09 -0700 (PDT) Received: (nullmailer pid 1590333 invoked by uid 1000); Tue, 17 May 2022 20:35:08 -0000 Date: Tue, 17 May 2022 15:35:08 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, ansuelsmth@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RESEND 1/5] dt-bindings: net: add bitfield defines for Ethernet speeds Message-ID: <20220517203508.GA1587170-robh@kernel.org> References: <20220505135512.3486-1-zajec5@gmail.com> <20220505135512.3486-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220505135512.3486-2-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_133514_023578_4E3EA2C9 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMDUsIDIwMjIgYXQgMDM6NTU6MDhQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBU aGlzIGFsbG93cyBzcGVjaWZ5aW5nIG11bHRpcGxlIEV0aGVybmV0IHNwZWVkcyBpbiBhIHNpbmds ZSBEVCB1aW50MzIKPiB2YWx1ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kg PHJhZmFsQG1pbGVja2kucGw+Cj4gLS0tCj4gIGluY2x1ZGUvZHQtYmluZGluZ3MvbmV0L2V0aC5o IHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrKysrCgpldGhlcm5ldC5oCgo+ICAxIGZpbGUg Y2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9k dC1iaW5kaW5ncy9uZXQvZXRoLmgKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kdC1iaW5kaW5n cy9uZXQvZXRoLmggYi9pbmNsdWRlL2R0LWJpbmRpbmdzL25ldC9ldGguaAo+IG5ldyBmaWxlIG1v ZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi44OWNhZmYwOTE3OWIKPiAtLS0gL2Rldi9u dWxsCj4gKysrIGIvaW5jbHVkZS9kdC1iaW5kaW5ncy9uZXQvZXRoLmgKPiBAQCAtMCwwICsxLDI3 IEBACj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkgKi8KCkR1YWwg bGljZW5zZQoKPiArLyoKPiArICogRGV2aWNlIFRyZWUgY29uc3RhbnRzIGZvciB0aGUgRXRoZXJu ZXQKPiArICovCj4gKwo+ICsjaWZuZGVmIF9EVF9CSU5ESU5HU19FVEhfSAo+ICsjZGVmaW5lIF9E VF9CSU5ESU5HU19FVEhfSAo+ICsKPiArI2RlZmluZSBTUEVFRF9VTlNQRUMJCTAKPiArI2RlZmlu ZSBTUEVFRF8xMAkJKDEgPDwgMCkKPiArI2RlZmluZSBTUEVFRF8xMDAJCSgxIDw8IDEpCj4gKyNk ZWZpbmUgU1BFRURfMTAwMAkJKDEgPDwgMikKPiArI2RlZmluZSBTUEVFRF8yMDAwCQkoMSA8PCAz KQo+ICsjZGVmaW5lIFNQRUVEXzI1MDAJCSgxIDw8IDQpCj4gKyNkZWZpbmUgU1BFRURfNTAwMAkJ KDEgPDwgNSkKPiArI2RlZmluZSBTUEVFRF8xMDAwMAkJKDEgPDwgNikKPiArI2RlZmluZSBTUEVF RF8xNDAwMAkJKDEgPDwgNykKPiArI2RlZmluZSBTUEVFRF8yMDAwMAkJKDEgPDwgOCkKPiArI2Rl ZmluZSBTUEVFRF8yNTAwMAkJKDEgPDwgOSkKPiArI2RlZmluZSBTUEVFRF80MDAwMAkJKDEgPDwg MTApCj4gKyNkZWZpbmUgU1BFRURfNTAwMDAJCSgxIDw8IDExKQo+ICsjZGVmaW5lIFNQRUVEXzU2 MDAwCQkoMSA8PCAxMikKPiArI2RlZmluZSBTUEVFRF8xMDAwMDAJCSgxIDw8IDEzKQo+ICsjZGVm aW5lIFNQRUVEXzIwMDAwMAkJKDEgPDwgMTQpCj4gKyNkZWZpbmUgU1BFRURfNDAwMDAwCQkoMSA8 PCAxNSkKClRoZXNlIHNob3VsZCBwcm9iYWJseSBoYXZlIHNvbWUgbmFtZXNwYWNlLiBFVEhfKj8K PiArCj4gKyNlbmRpZgo+IC0tIAo+IDIuMzQuMQo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=