All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jeffrey Ji <jeffreyjilinux@gmail.com>
Cc: Ido Schimmel <idosch@idosch.org>, David Ahern <dsahern@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Brian Vazquez <brianvv@google.com>,
	netdev@vger.kernel.org, Jeffrey Ji <jeffreyji@google.com>
Subject: Re: [PATCH net-next] show rx_otherhost_dropped stat in ip link show
Date: Wed, 18 May 2022 13:00:02 -0700	[thread overview]
Message-ID: <20220518130002.0a1bf327@hermes.local> (raw)
In-Reply-To: <CACB8nPkQkH3fJt29kNQ_YqikP8eKPSuBJvh-_cFO_zqie2rw0A@mail.gmail.com>

On Wed, 18 May 2022 07:29:08 -1000
Jeffrey Ji <jeffreyjilinux@gmail.com> wrote:

> > >               /* RX stats */
> > > -             fprintf(fp, "    RX: %*s %*s %*s %*s %*s %*s %*s%s",
> > > +             fprintf(fp, "    RX: %*s %*s %*s %*s %*s %*s %*s%*s%s",
> > >                       cols[0] - 4, "bytes", cols[1], "packets",
> > >                       cols[2], "errors", cols[3], "dropped",
> > >                       cols[4], "missed", cols[5], "mcast",
> > > -                     cols[6], s->rx_compressed ? "compressed" : "", _SL_);
> > > +                     s->rx_compressed ? cols[6] : 0,
> > > +                     s->rx_compressed ? "compressed " : "",
> > > +                     s->rx_otherhost_dropped ? cols[7] : 0,
> > > +                     s->rx_otherhost_dropped ? "otherhost_dropped" : "",

This belongs in the detail part not in the common stats.

Look where nohandler etc errors are.

      parent reply	other threads:[~2022-05-18 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 19:18 [PATCH net-next] show rx_otherhost_dropped stat in ip link show Jeffrey Ji
2022-05-09 20:10 ` Brian Vazquez
2022-05-10  7:09 ` Ido Schimmel
2022-05-18 17:29   ` Jeffrey Ji
2022-05-18 19:39     ` Jakub Kicinski
2022-05-18 20:00     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518130002.0a1bf327@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=brianvv@google.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=idosch@idosch.org \
    --cc=jeffreyji@google.com \
    --cc=jeffreyjilinux@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.