From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
sagi@grimberg.me, james.smart@broadcom.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH V2] nvme: set non-mdts limits in nvme_scan_work
Date: Wed, 18 May 2022 16:51:15 +0200 [thread overview]
Message-ID: <20220518145115.GA486@lst.de> (raw)
In-Reply-To: <YoUFurG9sH1Qhfue@kbusch-mbp.dhcp.thefacebook.com>
On Wed, May 18, 2022 at 08:42:02AM -0600, Keith Busch wrote:
> On Wed, May 18, 2022 at 10:56:02AM +0200, Christoph Hellwig wrote:
> > This re-reads the limits everytime a namespace is added or deleted,
> > is that really such a good idea?
>
> The limits are reported in logical blocks, which is dependent on the formats
> that attached namespaces have.
Well, the Identify controller limits aren't really supposed to
change randomly. But ok, maybe that is a reason to frequently
rescan due work around this broken design. Can we add a comment
to explain that?
next prev parent reply other threads:[~2022-05-18 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 6:49 [PATCH V2] nvme: set non-mdts limits in nvme_scan_work Chaitanya Kulkarni
2022-05-18 8:56 ` Christoph Hellwig
2022-05-18 14:42 ` Keith Busch
2022-05-18 14:51 ` Christoph Hellwig [this message]
2022-05-18 15:52 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518145115.GA486@lst.de \
--to=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.