From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE974C433F5 for ; Wed, 18 May 2022 08:58:42 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-jdyMCrLMPB-D8mpoYNu66w-1; Wed, 18 May 2022 04:58:36 -0400 X-MC-Unique: jdyMCrLMPB-D8mpoYNu66w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9EC73C0CD4C; Wed, 18 May 2022 08:58:34 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A0D840C1421; Wed, 18 May 2022 08:58:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 05AB51947B8F; Wed, 18 May 2022 08:58:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6E5461947B84 for ; Wed, 18 May 2022 08:58:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 403B5492C14; Wed, 18 May 2022 08:58:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BBC3403373 for ; Wed, 18 May 2022 08:58:32 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2109B3C0CD50 for ; Wed, 18 May 2022 08:58:32 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-149-oM_I62vyP-K4PcPY0r6fEw-1; Wed, 18 May 2022 04:58:30 -0400 X-MC-Unique: oM_I62vyP-K4PcPY0r6fEw-1 X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="296854866" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="296854866" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 01:58:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="605789798" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 18 May 2022 01:58:25 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nrFVh-0001zV-1B; Wed, 18 May 2022 08:58:25 +0000 Date: Wed, 18 May 2022 16:58:06 +0800 From: kernel test robot To: Matthias Kaehlcke , Alasdair Kergon , Mike Snitzer , Kees Cook , James Morris , "Serge E . Hallyn" Message-ID: <202205181616.3eTP2DaC-lkp@intel.com> References: <20220517163437.v4.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> MIME-Version: 1.0 In-Reply-To: <20220517163437.v4.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Subject: Re: [dm-devel] [PATCH v4 2/3] LoadPin: Enable loading from trusted dm-verity devices X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Douglas Anderson , kbuild-all@lists.01.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu , linux-security-module@vger.kernel.org, Matthias Kaehlcke Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc7 next-20220517] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220518/202205181616.3eTP2DaC-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/755e5d82e4d054b2b58a54c94681080cc8cb4582 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 git checkout 755e5d82e4d054b2b58a54c94681080cc8cb4582 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash security/loadpin/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from security/loadpin/loadpin.c:21: include/linux/dm-verity-loadpin.h:22:1: error: expected identifier or '(' before '{' token 22 | { | ^ >> include/linux/dm-verity-loadpin.h:21:20: warning: 'dm_verity_loadpin_is_sb_trusted' used but never defined 21 | static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/dm_verity_loadpin_is_sb_trusted +21 include/linux/dm-verity-loadpin.h afd03270f57b8c Matthias Kaehlcke 2022-05-17 17 afd03270f57b8c Matthias Kaehlcke 2022-05-17 18 #if IS_ENABLED(CONFIG_SECURITY_LOADPIN) && IS_BUILTIN(CONFIG_DM_VERITY) afd03270f57b8c Matthias Kaehlcke 2022-05-17 19 bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 20 #else afd03270f57b8c Matthias Kaehlcke 2022-05-17 @21 static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 @22 { afd03270f57b8c Matthias Kaehlcke 2022-05-17 23 return false; afd03270f57b8c Matthias Kaehlcke 2022-05-17 24 } afd03270f57b8c Matthias Kaehlcke 2022-05-17 25 #endif afd03270f57b8c Matthias Kaehlcke 2022-05-17 26 -- 0-DAY CI Kernel Test Service https://01.org/lkp -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BE3C433EF for ; Wed, 18 May 2022 08:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbiERI6y (ORCPT ); Wed, 18 May 2022 04:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbiERI6x (ORCPT ); Wed, 18 May 2022 04:58:53 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9025D13CA3B; Wed, 18 May 2022 01:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652864327; x=1684400327; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xR5ju/m+J7LrQ2NG96ZPR+tRwF+afBBK3BjNI5wn7n4=; b=keH05FyVsuyBYS/g6Lkp6aZWjz8B0/3do5lA8Ha86hH7s0YZIYyU9u0A LyjXqRwwzsz6/NVxB9ftqmwzB8egsIXGGfKY2czvH3u7p7E/z7A9aRu5J FSsr3SKX9Qj4lHscOnAidR+SrC+pu6Pe7Or0TEXTS4sDpjnjs9msXos2T EabAnVZ8ppm2rvzZVcqwfBlY7Sf7Onejazh3bJloGh5vq9VPZEZKgVpHY KMOkKjtXOc9BXJkadKOskHg7deWL6tHkF8luGlZ2wK2UqgJegoIFFrhDc xFK7IYuch6ZnqBxpEeyOoCoXSW4PiMGx6B7vBknqxcQYC9w+PLtOvBIOE g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="334615033" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="334615033" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 01:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="605789798" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 18 May 2022 01:58:25 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nrFVh-0001zV-1B; Wed, 18 May 2022 08:58:25 +0000 Date: Wed, 18 May 2022 16:58:06 +0800 From: kernel test robot To: Matthias Kaehlcke , Alasdair Kergon , Mike Snitzer , Kees Cook , James Morris , "Serge E . Hallyn" Cc: kbuild-all@lists.01.org, linux-security-module@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu , Douglas Anderson , Matthias Kaehlcke Subject: Re: [PATCH v4 2/3] LoadPin: Enable loading from trusted dm-verity devices Message-ID: <202205181616.3eTP2DaC-lkp@intel.com> References: <20220517163437.v4.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517163437.v4.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc7 next-20220517] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220518/202205181616.3eTP2DaC-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/755e5d82e4d054b2b58a54c94681080cc8cb4582 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 git checkout 755e5d82e4d054b2b58a54c94681080cc8cb4582 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash security/loadpin/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from security/loadpin/loadpin.c:21: include/linux/dm-verity-loadpin.h:22:1: error: expected identifier or '(' before '{' token 22 | { | ^ >> include/linux/dm-verity-loadpin.h:21:20: warning: 'dm_verity_loadpin_is_sb_trusted' used but never defined 21 | static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/dm_verity_loadpin_is_sb_trusted +21 include/linux/dm-verity-loadpin.h afd03270f57b8c Matthias Kaehlcke 2022-05-17 17 afd03270f57b8c Matthias Kaehlcke 2022-05-17 18 #if IS_ENABLED(CONFIG_SECURITY_LOADPIN) && IS_BUILTIN(CONFIG_DM_VERITY) afd03270f57b8c Matthias Kaehlcke 2022-05-17 19 bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 20 #else afd03270f57b8c Matthias Kaehlcke 2022-05-17 @21 static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 @22 { afd03270f57b8c Matthias Kaehlcke 2022-05-17 23 return false; afd03270f57b8c Matthias Kaehlcke 2022-05-17 24 } afd03270f57b8c Matthias Kaehlcke 2022-05-17 25 #endif afd03270f57b8c Matthias Kaehlcke 2022-05-17 26 -- 0-DAY CI Kernel Test Service https://01.org/lkp