From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87665C433F5 for ; Wed, 18 May 2022 18:59:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 25CEE405CF; Wed, 18 May 2022 18:59:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KhaQMw2D5a5L; Wed, 18 May 2022 18:59:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id B353C41015; Wed, 18 May 2022 18:59:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7A963C0032; Wed, 18 May 2022 18:59:09 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0B716C002D for ; Wed, 18 May 2022 18:59:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E9AC941015 for ; Wed, 18 May 2022 18:59:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nq7kXQLX1-Fc for ; Wed, 18 May 2022 18:59:07 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by smtp2.osuosl.org (Postfix) with ESMTPS id 04CA8405CF for ; Wed, 18 May 2022 18:59:06 +0000 (UTC) Received: by mail-oi1-f179.google.com with SMTP id q10so3791086oia.9 for ; Wed, 18 May 2022 11:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hl6vHR8m/JLovYO2gNE3ChbiYGqpt17k+OnwcqxZkjo=; b=KoFYhxUA5NlephtwG9bAA3Z7uUf4LRpQO2btPxc9waPMCTqMqv+R6eWk0D2F13BB/u Re4UQelV6+M+7X/txK8z/1oDqbUG46ANd4zpKWqe6MjNuooTuFopTUHm/B2AiGJ16XOo hpWRUAEPc5CIBzbQfayHl6SySBL20kbFGhgK9fXs580nHu0HVvzkUzNt95Wxprp3qlUU k5+H3Nj4r2BlIXUiIYCvcEAxDhmbsahT/pYCO+nWm207muLRpSa2yRkriRA332Q/QxZr s0Jb5s/YBkcc4iyMOPZr6VnAjOIZ4SxnrQ95tNd/Ck4b2DRGeDVEP+IYsVlituPS474G W6Rg== X-Gm-Message-State: AOAM532o/5KJ+3Yc9WdUxhJpFJLVG8Hmw2NayVjXRGAWxAX7254N4+r/ vPWle32L1aROsx/OBYKTgA== X-Google-Smtp-Source: ABdhPJyZK52/lZYsS9R3kKj1OyynJ0P1NooNpNVdFnOOXczUhwNDyIXF2qHiL1sltyV70oHQTWK1Fg== X-Received: by 2002:a05:6808:aa4:b0:325:91ff:43cc with SMTP id r4-20020a0568080aa400b0032591ff43ccmr623013oij.166.1652900345928; Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bd15-20020a056870d78f00b000e686d1389esm1202223oab.56.2022.05.18.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: (nullmailer pid 3695375 invoked by uid 1000); Wed, 18 May 2022 18:59:04 -0000 Date: Wed, 18 May 2022 13:59:04 -0500 From: Rob Herring To: Arnd Bergmann Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220518185904.GA3685644-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Juergen Gross , DTML , Stefano Stabellini , Julien Grall , "Michael S. Tsirkin" , Linux Kernel Mailing List , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Jean-Philippe Brucker , Christoph Hellwig , xen-devel , Krzysztof Kozlowski , Linux ARM X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > > @@ -13,6 +13,9 @@ description: > > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > > more details. > > > > +allOf: > > + - $ref: /schemas/arm/xen,dev-domid.yaml# > > + > > properties: > > compatible: > > const: virtio,mmio > > @@ -33,6 +36,10 @@ properties: > > description: Required for devices making accesses thru an IOMMU. > > maxItems: 1 > > > > + xen,dev-domid: > > + description: Required when Xen grant mappings need to be enabled for device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > required: > > - compatible > > - reg > > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space, but it would think it's > conceptually close enough that it makes sense for the binding. Something common is almost always better. That may also have the issue that fw_devlink will make the 'iommu' driver a dependency to probe. Rob _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D01C433F5 for ; Wed, 18 May 2022 18:59:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.332455.556148 (Exim 4.92) (envelope-from ) id 1nrOt4-0007AN-C5; Wed, 18 May 2022 18:59:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332455.556148; Wed, 18 May 2022 18:59:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOt4-0007AG-9D; Wed, 18 May 2022 18:59:10 +0000 Received: by outflank-mailman (input) for mailman id 332455; Wed, 18 May 2022 18:59:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOt2-0007AA-R3 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 18:59:08 +0000 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9777b426-d6dc-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 20:59:07 +0200 (CEST) Received: by mail-oi1-f173.google.com with SMTP id l16so3799067oil.6 for ; Wed, 18 May 2022 11:59:07 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bd15-20020a056870d78f00b000e686d1389esm1202223oab.56.2022.05.18.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: (nullmailer pid 3695375 invoked by uid 1000); Wed, 18 May 2022 18:59:04 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9777b426-d6dc-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hl6vHR8m/JLovYO2gNE3ChbiYGqpt17k+OnwcqxZkjo=; b=plLHEWQBviL1JKX1XEORj8Gy4wxV9WNSHLb+VbfZ+lXq5Cr1KSdCLqvThrnGlVgUGF eHDeAG2Um1a7lwOiYjQB9HV8fGn3NVtU11T+HmCSVFmPI7utjJkNjaCeG316/CIp8qyq Rl/BKZQomqF7CQeObda2VLuRYDsx1A9qAdi5jQYvy7j3SE6mjkXo4k9ClM4LO2UzkXk5 OAB2AG+6PMlVq0GpU0NfE/H3ygGK1Bkde7zPeMqO4N9pJIy7592g1geHqvmOLYVqkRqQ pU+l8kW/bPDf4sAbEwdg2v6+folqR47RlzQM/UNOTjxc8nHD9TA4kStEqrxC1pHHChwi WJqA== X-Gm-Message-State: AOAM532ym+iRu62ep70ObL2HEXXSmrTZlmcS0Is/a+GS10ZGGzk2GjtV 8+yTKuoewVnBuJwtoYzU/w== X-Google-Smtp-Source: ABdhPJyZK52/lZYsS9R3kKj1OyynJ0P1NooNpNVdFnOOXczUhwNDyIXF2qHiL1sltyV70oHQTWK1Fg== X-Received: by 2002:a05:6808:aa4:b0:325:91ff:43cc with SMTP id r4-20020a0568080aa400b0032591ff43ccmr623013oij.166.1652900345928; Wed, 18 May 2022 11:59:05 -0700 (PDT) Date: Wed, 18 May 2022 13:59:04 -0500 From: Rob Herring To: Arnd Bergmann Cc: Oleksandr Tyshchenko , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220518185904.GA3685644-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > > @@ -13,6 +13,9 @@ description: > > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > > more details. > > > > +allOf: > > + - $ref: /schemas/arm/xen,dev-domid.yaml# > > + > > properties: > > compatible: > > const: virtio,mmio > > @@ -33,6 +36,10 @@ properties: > > description: Required for devices making accesses thru an IOMMU. > > maxItems: 1 > > > > + xen,dev-domid: > > + description: Required when Xen grant mappings need to be enabled for device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > required: > > - compatible > > - reg > > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space, but it would think it's > conceptually close enough that it makes sense for the binding. Something common is almost always better. That may also have the issue that fw_devlink will make the 'iommu' driver a dependency to probe. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82F9CC433EF for ; Wed, 18 May 2022 19:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1ZsZDSh3FRwQwv+AgI6II+NmLaNKzflVeD+RcysRJYg=; b=1xJT6h5LmUWvaz Vr0Y8GL+HSZhvQqdRGcQpGccb94yCXFGkirHVzbkjbgX2YD0T82vXL8BWf3GI8tgfyyJInpRgW6V2 jPk6iojSUV6xyUE4iCqk1z0RQ6c/9hCgKL2ugc2+FspHJ7NDg5PfGYHP9Jz82aCpuumEpvWQpgoMD Cq07NGXPeDn9p/t2lxWgAx6mtPAketl7upN4/+qlaIuL6f1bWc35I2V14k/sOHKFg74MEz5hzkBLT IBSD0PwltrAxwTXd4FTZs0tVtBpxiLe0Tx9dKGTDD3aC+OcCI2qDcaS0TR946l1vh0nqqdrffhCP6 QBymBdL8QyUBXX37PPUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrOt6-003W8h-54; Wed, 18 May 2022 18:59:12 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrOt3-003W7S-CC for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 18:59:11 +0000 Received: by mail-oi1-f180.google.com with SMTP id e189so3790257oia.8 for ; Wed, 18 May 2022 11:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hl6vHR8m/JLovYO2gNE3ChbiYGqpt17k+OnwcqxZkjo=; b=7ZbljwqhYbNuW8YoLsTBrBqdr8L7YS2ZNkJ6MwVPgT0nVNDwqX2IVKEF4MqGRMx15l 3rznJut7OCnWGbTMfgFgnyKnngNOcjcVTWVUnmHraI4LJLkdqZKKlt9/v+oiW5MN/Tat 93LMLRrVCyhkvVXost53EccRCgaOLcA+Ro7kixuO3goFsL+hSulGEpQ73ntjbh3rT3C0 e+XQTU/7rwWpWPZys6QgRPTS4opMqzTBDpdN+F9nyI/ShXdo31HqneUwTRL8sB+QokL6 wm1IZ+LZk/Qbt66JQ0WF8V01izIgwYkJVPIn1Q4kg4KWHUcrdMio+CYzzjWawo5Q44Dp 0IWw== X-Gm-Message-State: AOAM533iYdS4dcCke68v+Xsi788S+BAmZysUqMiTi2psqr/DKDSkDQ8c G+2mYa8aDqnJPEDrW8egEQ== X-Google-Smtp-Source: ABdhPJyZK52/lZYsS9R3kKj1OyynJ0P1NooNpNVdFnOOXczUhwNDyIXF2qHiL1sltyV70oHQTWK1Fg== X-Received: by 2002:a05:6808:aa4:b0:325:91ff:43cc with SMTP id r4-20020a0568080aa400b0032591ff43ccmr623013oij.166.1652900345928; Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bd15-20020a056870d78f00b000e686d1389esm1202223oab.56.2022.05.18.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: (nullmailer pid 3695375 invoked by uid 1000); Wed, 18 May 2022 18:59:04 -0000 Date: Wed, 18 May 2022 13:59:04 -0500 From: Rob Herring To: Arnd Bergmann Cc: Oleksandr Tyshchenko , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220518185904.GA3685644-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_115909_441234_510340D1 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > > @@ -13,6 +13,9 @@ description: > > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > > more details. > > > > +allOf: > > + - $ref: /schemas/arm/xen,dev-domid.yaml# > > + > > properties: > > compatible: > > const: virtio,mmio > > @@ -33,6 +36,10 @@ properties: > > description: Required for devices making accesses thru an IOMMU. > > maxItems: 1 > > > > + xen,dev-domid: > > + description: Required when Xen grant mappings need to be enabled for device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > required: > > - compatible > > - reg > > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space, but it would think it's > conceptually close enough that it makes sense for the binding. Something common is almost always better. That may also have the issue that fw_devlink will make the 'iommu' driver a dependency to probe. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel