From: Stephen Hemminger <stephen@networkplumber.org>
To: Wenjun Wu <wenjun1.wu@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com,
qi.z.zhang@intel.com, simei.su@intel.com
Subject: Re: [PATCH v2] net/iavf: fix race condition for multi-cores
Date: Thu, 19 May 2022 08:27:21 -0700 [thread overview]
Message-ID: <20220519082721.5a09795d@hermes.local> (raw)
In-Reply-To: <20220519073334.760947-1-wenjun1.wu@intel.com>
On Thu, 19 May 2022 15:33:34 +0800
Wenjun Wu <wenjun1.wu@intel.com> wrote:
>
> + if (dev->data->dev_conf.rxmode.offloads &
> + RTE_ETH_RX_OFFLOAD_TIMESTAMP)
> + rte_spinlock_init(&vf->phc_time_aq_lock);
> +
There is no reason this init needs to be only true with some flags.
Just always do it.
next prev parent reply other threads:[~2022-05-19 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 1:19 [PATCH v1] net/iavf: fix race condition for multi-cores Wenjun Wu
2022-05-19 3:13 ` Stephen Hemminger
2022-05-19 7:33 ` [PATCH v2] " Wenjun Wu
2022-05-19 15:27 ` Stephen Hemminger [this message]
2022-05-20 7:35 ` [PATCH v3] " Wenjun Wu
2022-05-23 4:49 ` [PATCH v4] " Wenjun Wu
2022-05-23 5:17 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519082721.5a09795d@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.