From: Jakub Kicinski <kuba@kernel.org>
To: Nikolaus Vladutescu-Zopp <nikolaus@vladutescu-zopp.com>
Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, blairuk@gmail.com,
kai.heng.feng@canonical.com
Subject: Re: [PATCH] net: atlantic: Avoid out-of-bounds indexing
Date: Thu, 19 May 2022 17:51:10 -0700 [thread overview]
Message-ID: <20220519175110.4b9c0a45@kernel.org> (raw)
In-Reply-To: <f9fab445-e4f4-88c1-c9a3-0129af1ccf27@vladutescu-zopp.com>
On Thu, 19 May 2022 03:09:50 +0200 Nikolaus Vladutescu-Zopp wrote:
> A UBSAN warning is observed on atlantic driver:
>
> [ 16.257086] UBSAN: array-index-out-of-bounds in
> drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1268:48
> [ 16.257090] index 8 is out of range for type 'aq_vec_s *[8]'
>
> The index is assigned right before breaking out the loop, so there's no
> actual deferencing happening.
> So only use the index inside the loop to fix the issue.
>
> Same issue was observed and corrected in two other places.
>
> BugLink: https://bugs.launchpad.net/bugs/1958770
> Suggested-by: bsdz <blairuk@gmail.com>
> Suggested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Tested-by: Nikolaus Vladutescu-Zopp <nikolaus@vladutescu-zopp.com>
> Signed-off-by: Nikolaus Vladutescu-Zopp <nikolaus@vladutescu-zopp.com>
The patch does not apply, please rebase on net/master:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
and repost. Please use [PATCH net] as the subject prefix. Please add
a Fixes tag, if possible. Please replace "bsdz" with the person's name
or remove that tag.
next prev parent reply other threads:[~2022-05-20 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 1:09 [PATCH] net: atlantic: Avoid out-of-bounds indexing Nikolaus Vladutescu-Zopp
2022-05-20 0:51 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-04 5:08 Kai-Heng Feng
2022-03-05 5:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519175110.4b9c0a45@kernel.org \
--to=kuba@kernel.org \
--cc=blairuk@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolaus@vladutescu-zopp.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.