All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: tytso@mit.edu, Jason@zx2c4.com
Cc: hch@lst.de, linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 2/2] random: wire up fops->splice_read_iter()
Date: Thu, 19 May 2022 13:31:33 -0600	[thread overview]
Message-ID: <20220519193133.194138-3-axboe@kernel.dk> (raw)
In-Reply-To: <20220519193133.194138-1-axboe@kernel.dk>

Now that random/urandom is using read_iter, we can wire it up to using
the generic splice read handler.

Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 drivers/char/random.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 529afd31d549..6da8f1441815 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1647,6 +1647,7 @@ const struct file_operations random_fops = {
 	.compat_ioctl = compat_ptr_ioctl,
 	.fasync = random_fasync,
 	.llseek = noop_llseek,
+	.splice_read = generic_file_splice_read,
 };
 
 const struct file_operations urandom_fops = {
@@ -1656,6 +1657,7 @@ const struct file_operations urandom_fops = {
 	.compat_ioctl = compat_ptr_ioctl,
 	.fasync = random_fasync,
 	.llseek = noop_llseek,
+	.splice_read = generic_file_splice_read,
 };
 
 
-- 
2.35.1


  parent reply	other threads:[~2022-05-19 19:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 19:31 [PATCHSET 0/2] Fix splice from random/urandom Jens Axboe
2022-05-19 19:31 ` [PATCH 1/2] random: convert to using fops->read_iter() Jens Axboe
2022-05-19 23:12   ` Jason A. Donenfeld
2022-05-19 23:20     ` Jason A. Donenfeld
2022-05-19 23:21       ` Jens Axboe
2022-05-19 23:21         ` Jason A. Donenfeld
2022-05-19 23:21     ` Jens Axboe
2022-05-19 19:31 ` Jens Axboe [this message]
2022-05-19 19:48 ` [PATCHSET 0/2] Fix splice from random/urandom Christoph Hellwig
2022-05-19 19:55   ` Jens Axboe
2022-05-20  6:02     ` Christoph Hellwig
2022-05-20 12:51       ` Jens Axboe
2022-05-19 20:05 ` Jason A. Donenfeld
2022-05-19 20:49   ` Jens Axboe
2022-05-19 21:02     ` Jens Axboe
2022-05-19 23:15       ` Jason A. Donenfeld
2022-05-19 23:22         ` Jens Axboe
2022-05-19 23:25           ` Jason A. Donenfeld
2022-05-19 23:33             ` Jens Axboe
2022-05-19 23:39               ` Jason A. Donenfeld
2022-05-19 23:44                 ` Jens Axboe
2022-05-19 23:13     ` Jason A. Donenfeld
2022-05-19 23:19       ` Jens Axboe
2022-05-19 23:23         ` Jason A. Donenfeld
2022-05-19 23:25           ` Jens Axboe
2022-05-19 23:27             ` Jason A. Donenfeld
2022-05-19 23:57               ` Jens Axboe
2022-05-20  0:00                 ` Jason A. Donenfeld
2022-05-20  0:02                   ` Jens Axboe
2022-05-20  0:48                     ` Jason A. Donenfeld
2022-05-20  0:56                       ` Jens Axboe
2022-05-20  1:00                         ` Jason A. Donenfeld
2022-05-20  1:05                           ` Jens Axboe
2022-05-20  1:10                           ` Jens Axboe
2022-05-20 12:43                             ` Jason A. Donenfeld
2022-05-20 12:49                               ` Jens Axboe
2022-05-20 13:04                                 ` Jason A. Donenfeld
  -- strict thread matches above, loose matches on Subject: below --
2022-05-19 23:31 [PATCHSET v2 " Jens Axboe
2022-05-19 23:31 ` [PATCH 2/2] random: wire up fops->splice_read_iter() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519193133.194138-3-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Jason@zx2c4.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.