From: Shreenidhi Shedi <yesshedi@gmail.com>
To: srivatsa@csail.mit.edu, amakhalov@vmware.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com
Cc: virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
x86@kernel.org, linux-kernel@vger.kernel.org, yesshedi@gmail.com,
Shreenidhi Shedi <sshedi@vmware.com>
Subject: [PATCH] x86/vmware: use unsigned integer for shifting
Date: Fri, 20 May 2022 12:58:57 +0530 [thread overview]
Message-ID: <20220520072857.592746-1-sshedi@vmware.com> (raw)
Shifting signed 32-bit value by 31 bits is implementation-defined
behaviour. Using unsigned is better option for this.
Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
---
arch/x86/kernel/cpu/vmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c
index c04b933f48d3..b28f789d3c56 100644
--- a/arch/x86/kernel/cpu/vmware.c
+++ b/arch/x86/kernel/cpu/vmware.c
@@ -476,7 +476,7 @@ static bool __init vmware_legacy_x2apic_available(void)
{
uint32_t eax, ebx, ecx, edx;
VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
- return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
+ return (eax & (1U << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
(eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;
}
--
2.36.1
next reply other threads:[~2022-05-20 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 7:28 Shreenidhi Shedi [this message]
2022-05-20 9:26 ` [PATCH] x86/vmware: use unsigned integer for shifting Borislav Petkov
2022-05-20 9:26 ` Borislav Petkov
2022-05-20 11:29 ` Srivatsa S. Bhat
2022-05-20 11:29 ` Srivatsa S. Bhat
2022-05-20 11:42 ` Shreenidhi Shedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520072857.592746-1-sshedi@vmware.com \
--to=yesshedi@gmail.com \
--cc=amakhalov@vmware.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=srivatsa@csail.mit.edu \
--cc=sshedi@vmware.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.