From: Kanchan Joshi <joshi.k@samsung.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, axboe@kernel.dk,
linux-nvme@lists.infradead.org, gost.dev@samsung.com,
joshiiitr@gmail.com
Subject: Re: [PATCH v2 0/2] uring-passthrough for admin commands
Date: Fri, 20 May 2022 13:51:34 +0530 [thread overview]
Message-ID: <20220520082134.GA28050@test-zns> (raw)
In-Reply-To: <20220520060143.GA16433@lst.de>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Fri, May 20, 2022 at 08:01:43AM +0200, Christoph Hellwig wrote:
>On Fri, May 20, 2022 at 10:25:58AM +0530, Kanchan Joshi wrote:
>> The series enables uring-passthrough for admin-commands.
>>
>> Patch 1 is prep.
>> Patch 2 adds new opcode for admin uring-passthrough, and enables it on
>> nvme controller dev(/dev/nvmeX). It reuses the code of io-command
>> passthrough, with the only difference that commands are issued on admin
>> queue.
>
>Looks good:
>
>Reviewed-by: Christoph Hellwig <hch@lst.de>
>
>Can we add vectored admin commands as well, please? We basically
>get them for free, so I see no reason not to add them.
Sure. By free, you mean this I suppose:
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -699,6 +699,9 @@ int nvme_dev_uring_cmd(struct io_uring_cmd *ioucmd, unsigned int issue_flags)
case NVME_URING_CMD_ADMIN:
ret = nvme_uring_cmd_io(ctrl, NULL, ioucmd, issue_flags, false);
break;
+ case NVME_URING_CMD_ADMIN_VEC:
+ ret = nvme_uring_cmd_io(ctrl, NULL, ioucmd, issue_flags, true);
+ break;
anything else? I will fold this in, and submit v3 before Jens takes a
look.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-05-20 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220520050118epcas5p1f6a930419285ecdac65afaa22255c03f@epcas5p1.samsung.com>
2022-05-20 4:55 ` [PATCH v2 0/2] uring-passthrough for admin commands Kanchan Joshi
2022-05-20 4:55 ` [PATCH v2 1/2] nvme: helper for uring-passthrough checks Kanchan Joshi
2022-05-20 4:56 ` [PATCH v2 2/2] nvme: enable uring-passthrough for admin commands Kanchan Joshi
2022-05-20 6:01 ` [PATCH v2 0/2] " Christoph Hellwig
2022-05-20 8:21 ` Kanchan Joshi [this message]
2022-05-20 9:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520082134.GA28050@test-zns \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.