From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
flyingpeng@tencent.com, imagedong@tencent.com,
benbjiang@tencent.com
Subject: Re: [PATCH net-next] tcp_ipv6: set the drop_reason in the right place
Date: Fri, 20 May 2022 09:34:25 -0700 [thread overview]
Message-ID: <20220520093425.0489d6d9@kernel.org> (raw)
In-Reply-To: <4deccb83-79c4-5276-3183-d6e6ffa3ec53@tessares.net>
On Fri, 20 May 2022 18:22:22 +0200 Matthieu Baerts wrote:
> On 20/05/2022 04:13, Jakub Kicinski wrote:
> > Looks like the IPv6 version of the patch under Fixes was
> > a copy/paste of the IPv4 but hit the wrong spot.
> > It is tcp_v6_rcv() which uses drop_reason as a boolean, and
> > needs to be protected against reason == 0 before calling free.
> > tcp_v6_do_rcv() has a pretty straightforward flow.
>
> Thank you for the patch!
>
> It looks like this fixes an issue our MPTCP CI detected recently:
>
> https://github.com/multipath-tcp/mptcp_net-next/issues/277
>
>
> Just in case someone else had this issue on their side, here is the call
> trace we had:
Ack, I got the same trace. Let me add the trace to the commit msg and
fast-path merging this fix so more people don't hit the stack trace.
next prev parent reply other threads:[~2022-05-20 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 2:13 [PATCH net-next] tcp_ipv6: set the drop_reason in the right place Jakub Kicinski
2022-05-20 16:22 ` Matthieu Baerts
2022-05-20 16:34 ` Jakub Kicinski [this message]
2022-05-20 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520093425.0489d6d9@kernel.org \
--to=kuba@kernel.org \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.