From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1DEC433EF for ; Fri, 20 May 2022 12:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232424AbiETMV6 (ORCPT ); Fri, 20 May 2022 08:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349291AbiETMVt (ORCPT ); Fri, 20 May 2022 08:21:49 -0400 X-Greylist: delayed 2803 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 20 May 2022 05:21:16 PDT Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E2724C406; Fri, 20 May 2022 05:21:13 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 89441FF810; Fri, 20 May 2022 12:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653049272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9/j3N/5Wrep8nEVTKpfSVpG01w0RrIsJwIuJSpfUqk=; b=RfW0rjzcmmERfR5djFuVWqGNNOXEXZH64WSz4zF6bNV8PZOupWqEnejx3YHzGPR+ANVyqf u1X+8G40M4FtwDyht1zoabB49i3jwiatJroTJKQsi8taz+RmQUh7KOjlv3g7H4mwsBkOEX E/2xcdCNRM5z9JO4Qlm5sMWl3Px7hdyoPqweUk79/uJg6x8eq86WoxsWxi9VL98gUDG6wv wt0+qMRqFXeArB91COg4rAgJAMcC6yoywoHCtjeNU8H2BTfoF1zFcuBdcf1kk46rzz6dOu K1/VdbzH87ALHDx9nJLW3gvFjxdEVBf1JMUA+bWEM3Kl7OnBLa1FtUBEnu2L1A== Date: Fri, 20 May 2022 14:21:09 +0200 From: Herve Codina To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Michael Turquette , Stephen Boyd , Horatiu Vultur , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520142109.57b84da2@bootlin.com> In-Reply-To: References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Krzysztof, On Fri, 20 May 2022 13:40:13 +0200 Krzysztof Kozlowski wrote: > On 20/05/2022 13:34, Herve Codina wrote: > > On Fri, 13 May 2022 14:57:55 +0200 > > Krzysztof Kozlowski wrote: > > =20 > >> On 13/05/2022 12:58, Herve Codina wrote: =20 > >>> The USB device controller available in the Microchip LAN966x SOC > >>> is the same IP as the one present in the SAMA5D3 SOC. > >>> > >>> Add the LAN966x compatible string and set the SAMA5D3 compatible > >>> string as a fallback for the LAN966x. > >>> > >>> Signed-off-by: Herve Codina > >>> --- > >>> Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Do= cumentation/devicetree/bindings/usb/atmel-usb.txt > >>> index f512f0290728..a6fab7d63f37 100644 > >>> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt > >>> +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt > >>> @@ -87,6 +87,9 @@ Required properties: > >>> "atmel,at91sam9g45-udc" > >>> "atmel,sama5d3-udc" > >>> "microchip,sam9x60-udc" > >>> + "microchip,lan996x-udc" =20 > >> > >> No wildcards please, especially that it closely fits previous wildcard > >> (lan996x includes lan9960 which looks a lot like sam9x60...) > >> =20 > >=20 > > Well, first, I made a mistake. It should be lan966x instead of lan996x. > >=20 > > This family is composed of the LAN9662 and the LAN9668 SOCs. > >=20 > > Related to the wilcard, lan966x is used in several bindings for common > > parts used by both SOCs: > > - microchip,lan966x-gck > > - microchip,lan966x-cpu-syscon > > - microchip,lan966x-switch > > - microchip,lan966x-miim > > - microchip,lan966x-serdes > > - microchip,lan966x-pinctrl =20 >=20 > And for new bindings I pointed that it is not preferred, so already few > other started using specific compatible. >=20 > >=20 > > I think it makes sense to keep 'microchip,lan966x-udc' for the USB > > device controller (same controller on LAN9662 and LAN9668) and so > > keeping the same rules as for other common parts. =20 >=20 > Having wildcard was rather a mistake and we already started correcting > it, so keeping the "mistake" neither gives you consistency, nor > correctness... >=20 I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case). What do you think about: - microchip,lan9662-udc - microchip,lan9668-udc - microchip,lan966-udc <-- Family lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst (1) https://lore.kernel.org/all/20211004105926.5696-1-kavyasree.kotagiri@mi= crochip.com/ Regards, Herve --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B94A5C433EF for ; Fri, 20 May 2022 12:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RSvsf7mRjTheDGEsIq7Z38v0IfyGuBFNkuCsKkotVbI=; b=IE05WSJxVakjgU J198iIMEldRb2XeUyv6cbfDw2gEYy2fV3DzekY4NI7yxqtCq8kS9BmNDFYBQAZtZjM37jc5mtRXju AcNjujh+EbhWgtC+vWA8gOeSw94VdvSVyNLUetq+1Bdk3s/RnFvBicS7A150okizeYsInm4lRjRpK B4uhGilombt5iExrtVGLj4woOLQa3vkeI/uLmZlZURt9BnvB3mJOpNXNieURvbwOSwIO4cb1ORFM7 CK9VpqotAPMsAi7y5yUoGQvsUNkXZtKWOVVQ+KQNHeYciwIIA6Q80AqpQBxnXCfNfc5VoF3t9eHQK E+4ZhRAs55RfECktCNUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1dC-00CIH2-75; Fri, 20 May 2022 12:21:22 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1d8-00CIFQ-1u for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 12:21:19 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 89441FF810; Fri, 20 May 2022 12:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653049272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9/j3N/5Wrep8nEVTKpfSVpG01w0RrIsJwIuJSpfUqk=; b=RfW0rjzcmmERfR5djFuVWqGNNOXEXZH64WSz4zF6bNV8PZOupWqEnejx3YHzGPR+ANVyqf u1X+8G40M4FtwDyht1zoabB49i3jwiatJroTJKQsi8taz+RmQUh7KOjlv3g7H4mwsBkOEX E/2xcdCNRM5z9JO4Qlm5sMWl3Px7hdyoPqweUk79/uJg6x8eq86WoxsWxi9VL98gUDG6wv wt0+qMRqFXeArB91COg4rAgJAMcC6yoywoHCtjeNU8H2BTfoF1zFcuBdcf1kk46rzz6dOu K1/VdbzH87ALHDx9nJLW3gvFjxdEVBf1JMUA+bWEM3Kl7OnBLa1FtUBEnu2L1A== Date: Fri, 20 May 2022 14:21:09 +0200 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520142109.57b84da2@bootlin.com> In-Reply-To: References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_052118_405713_CBAF9421 X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Thomas Petazzoni , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, Horatiu Vultur , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gRnJpLCAyMCBNYXkgMjAyMiAxMzo0MDoxMyArMDIwMApLcnp5c3p0 b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBP biAyMC8wNS8yMDIyIDEzOjM0LCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBPbiBGcmksIDEzIE1h eSAyMDIyIDE0OjU3OjU1ICswMjAwCj4gPiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yu a296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4gICAKPiA+PiBPbiAxMy8wNS8yMDIyIDEy OjU4LCBIZXJ2ZSBDb2RpbmEgd3JvdGU6ICAKPiA+Pj4gVGhlIFVTQiBkZXZpY2UgY29udHJvbGxl ciBhdmFpbGFibGUgaW4gdGhlIE1pY3JvY2hpcCBMQU45NjZ4IFNPQwo+ID4+PiBpcyB0aGUgc2Ft ZSBJUCBhcyB0aGUgb25lIHByZXNlbnQgaW4gdGhlIFNBTUE1RDMgU09DLgo+ID4+Pgo+ID4+PiBB ZGQgdGhlIExBTjk2NnggY29tcGF0aWJsZSBzdHJpbmcgYW5kIHNldCB0aGUgU0FNQTVEMyBjb21w YXRpYmxlCj4gPj4+IHN0cmluZyBhcyBhIGZhbGxiYWNrIGZvciB0aGUgTEFOOTY2eC4KPiA+Pj4K PiA+Pj4gU2lnbmVkLW9mZi1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5j b20+Cj4gPj4+IC0tLQo+ID4+PiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Vz Yi9hdG1lbC11c2IudHh0IHwgMyArKysKPiA+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKykKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy91c2IvYXRtZWwtdXNiLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy91c2IvYXRtZWwtdXNiLnR4dAo+ID4+PiBpbmRleCBmNTEyZjAyOTA3MjguLmE2ZmFiN2Q2 M2YzNyAxMDA2NDQKPiA+Pj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3VzYi9hdG1lbC11c2IudHh0Cj4gPj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy91c2IvYXRtZWwtdXNiLnR4dAo+ID4+PiBAQCAtODcsNiArODcsOSBAQCBSZXF1aXJl ZCBwcm9wZXJ0aWVzOgo+ID4+PiAgCSAgICAgICAiYXRtZWwsYXQ5MXNhbTlnNDUtdWRjIgo+ID4+ PiAgCSAgICAgICAiYXRtZWwsc2FtYTVkMy11ZGMiCj4gPj4+ICAJICAgICAgICJtaWNyb2NoaXAs c2FtOXg2MC11ZGMiCj4gPj4+ICsJICAgICAgICJtaWNyb2NoaXAsbGFuOTk2eC11ZGMiICAgIAo+ ID4+Cj4gPj4gTm8gd2lsZGNhcmRzIHBsZWFzZSwgZXNwZWNpYWxseSB0aGF0IGl0IGNsb3NlbHkg Zml0cyBwcmV2aW91cyB3aWxkY2FyZAo+ID4+IChsYW45OTZ4IGluY2x1ZGVzIGxhbjk5NjAgd2hp Y2ggbG9va3MgYSBsb3QgbGlrZSBzYW05eDYwLi4uKQo+ID4+ICAKPiA+IAo+ID4gV2VsbCwgZmly c3QsIEkgbWFkZSBhIG1pc3Rha2UuIEl0IHNob3VsZCBiZSBsYW45NjZ4IGluc3RlYWQgb2YgbGFu OTk2eC4KPiA+IAo+ID4gVGhpcyBmYW1pbHkgaXMgY29tcG9zZWQgb2YgdGhlIExBTjk2NjIgYW5k IHRoZSBMQU45NjY4IFNPQ3MuCj4gPiAKPiA+IFJlbGF0ZWQgdG8gdGhlIHdpbGNhcmQsIGxhbjk2 NnggaXMgdXNlZCBpbiBzZXZlcmFsIGJpbmRpbmdzIGZvciBjb21tb24KPiA+IHBhcnRzIHVzZWQg YnkgYm90aCBTT0NzOgo+ID4gLSBtaWNyb2NoaXAsbGFuOTY2eC1nY2sKPiA+IC0gbWljcm9jaGlw LGxhbjk2NngtY3B1LXN5c2Nvbgo+ID4gLSBtaWNyb2NoaXAsbGFuOTY2eC1zd2l0Y2gKPiA+IC0g bWljcm9jaGlwLGxhbjk2NngtbWlpbQo+ID4gLSBtaWNyb2NoaXAsbGFuOTY2eC1zZXJkZXMKPiA+ IC0gbWljcm9jaGlwLGxhbjk2NngtcGluY3RybCAgCj4gCj4gQW5kIGZvciBuZXcgYmluZGluZ3Mg SSBwb2ludGVkIHRoYXQgaXQgaXMgbm90IHByZWZlcnJlZCwgc28gYWxyZWFkeSBmZXcKPiBvdGhl ciBzdGFydGVkIHVzaW5nIHNwZWNpZmljIGNvbXBhdGlibGUuCj4gCj4gPiAKPiA+IEkgdGhpbmsg aXQgbWFrZXMgc2Vuc2UgdG8ga2VlcCAnbWljcm9jaGlwLGxhbjk2NngtdWRjJyBmb3IgdGhlIFVT Qgo+ID4gZGV2aWNlIGNvbnRyb2xsZXIgKHNhbWUgY29udHJvbGxlciBvbiBMQU45NjYyIGFuZCBM QU45NjY4KSBhbmQgc28KPiA+IGtlZXBpbmcgdGhlIHNhbWUgcnVsZXMgYXMgZm9yIG90aGVyIGNv bW1vbiBwYXJ0cy4gIAo+IAo+IEhhdmluZyB3aWxkY2FyZCB3YXMgcmF0aGVyIGEgbWlzdGFrZSBh bmQgd2UgYWxyZWFkeSBzdGFydGVkIGNvcnJlY3RpbmcKPiBpdCwgc28ga2VlcGluZyB0aGUgIm1p c3Rha2UiIG5laXRoZXIgZ2l2ZXMgeW91IGNvbnNpc3RlbmN5LCBub3IKPiBjb3JyZWN0bmVzcy4u Lgo+IAoKSSB0aGluayB0aGF0IHRoZSAiZmFtaWx5IiBjb21wYXRpYmxlIHNob3VsZCBiZSBwcmVz ZW50LgpUaGlzIG9uZSBhbGxvd3MgdG8gZGVmaW5lIHRoZSBjb21tb24gcGFydHMgaW4gdGhlIGNv bW1vbgouZHRzaSBmaWxlIChsYW45NjZ4LmR0c2kgaW4gb3VyIGNhc2UpLgoKV2hhdCBkbyB5b3Ug dGhpbmsgYWJvdXQ6Ci0gbWljcm9jaGlwLGxhbjk2NjItdWRjCi0gbWljcm9jaGlwLGxhbjk2Njgt dWRjCi0gbWljcm9jaGlwLGxhbjk2Ni11ZGMgIDwtLSBGYW1pbHkKCmxhbjk2NiBpcyBkZWZpbmVk IGFzIHRoZSBmYW1pbHkgY29tcGF0aWJsZSBzdHJpbmcgc2luY2UgKDEpIGluCmJpbmRpbmdzL2Fy bS9hdG1lbC1hdDkxLnlhbWwgYW5kIGluIERvY3VtZW50YXRpb24vYXJtL21pY3JvY2hpcC5yc3QK CigxKSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMTEwMDQxMDU5MjYuNTY5Ni0xLWth dnlhc3JlZS5rb3RhZ2lyaUBtaWNyb2NoaXAuY29tLwoKUmVnYXJkcywKSGVydmUKCi0tIApIZXJ2 w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcK aHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=