From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D83EC433EF for ; Fri, 20 May 2022 12:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238804AbiETMhe (ORCPT ); Fri, 20 May 2022 08:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231533AbiETMhc (ORCPT ); Fri, 20 May 2022 08:37:32 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C0655F8C5; Fri, 20 May 2022 05:37:31 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9BF98FF802; Fri, 20 May 2022 12:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653050249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WKwb1xLxCKHxo8kAUv0MtGuwurU5vlydm6P3+DNROh4=; b=l1f6zb6+GSbPTbWj42ElyYGLAOZKQx2M9xqWd+ieBlHSzmFo3aXx/ZqXctiDFGskM+Ez1H xMTSUcOwgdMAuos1ERIEoYjZM1SQOPXUIIvLX/aj9mBM7HnK2fAWTnW1o/H64SKZm2ss9p nSJEQLe/EZafTHiTY4mtYE/7AD988/9Pq2WqCS+JCsAZ6/+cHA90jLevilumLWZ2eIO2k5 YNtg7YfcjKbkn+TI4+b5vl/aXFW1VieMOVMPXO2EoAfR0vQYBqLNoNgEfhEKuXGuevdC3Q hHRHJ+/DEkh3h/2aMzgtW4wty+JV2YHauQvA6S4ZgF3WH8OWUITMpxm79SyTCQ== Date: Fri, 20 May 2022 14:37:26 +0200 From: Herve Codina To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Michael Turquette , Stephen Boyd , Horatiu Vultur , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support Message-ID: <20220520143726.6dd324fb@bootlin.com> In-Reply-To: <2945e445-3453-a45f-7d3d-3b07bf350b47@linaro.org> References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-4-herve.codina@bootlin.com> <2945e445-3453-a45f-7d3d-3b07bf350b47@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Krzysztof, Sergei On Fri, 13 May 2022 14:54:26 +0200 Krzysztof Kozlowski wrote: > On 13/05/2022 12:58, Herve Codina wrote: > > Add UDPHS (the USB High Speed Device Port controller) support. > > The UDPHS IP present in the lan966x SOC is the same as the one > > present in the SAMA5D3 SOC > >=20 > > Signed-off-by: Herve Codina > > --- > > arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x= .dtsi > > index 7d2869648050..4c09f3166d27 100644 > > --- a/arch/arm/boot/dts/lan966x.dtsi > > +++ b/arch/arm/boot/dts/lan966x.dtsi > > @@ -211,6 +211,17 @@ can0: can@e081c000 { > > status =3D "disabled"; > > }; > > =20 > > + udc: udphs@e0808000 { =20 >=20 > Generic node names, so it looks like usb. For example HCD schema > requires it. I am not sure which bindings are used here, but anyway once > they might require usb... >=20 HCD are related to the Host controller. Here we are talking about a device. In existing bindings related to USB device (or OTG as an OTG can be a host or a device) on several SOCs, we can find: - usb1: gadget@fffa4000 - usb_otg: usb@1c13000 - usb: usb@47400000 - udc: usb@13040000 - usb_otg_hs: usb_otg_hs@4a0ab000 So I will change to udc: usb@e0808000 Is that ok for you ? Regards, Herve --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5889BC433F5 for ; Fri, 20 May 2022 12:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/mE0qmwNkX+jEJ7KG7v/bXYnPCQcvab9Zh6EYO1l6Q=; b=AWfcEJI6XpOyR9 rfuUxj/0ULwJQAfrf0eQBiGpm+sdYOLOf2Dgt6PDM4+MskNITVbTO4P9W6nXRwtcWPzB6VLTDKtll eUGJw2633CDcrAQs9/HYlgrKx2eaXiv+1Zx16XWUojTQPSeJe+pQGfeETVH3qrvB2F4D7EhiU4i8z i+3mR784zaO1ApkfQxsMUIJHXXLqkE6sT9tf/mC6mEG4nlkwvCok8KlzhEARd+13Noxb/DvET4U82 rfohTkGdEpoNuqhuOsL4t9PExOakgTXGYaBv2BYmfhy7XrmEEm7kqvl7E+WSwL9Gd0kW+PExFfSR7 ZphQbzY6W7tUVj856UVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1st-00CN2S-Ts; Fri, 20 May 2022 12:37:36 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1sq-00CN1S-NI for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 12:37:34 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9BF98FF802; Fri, 20 May 2022 12:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653050249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WKwb1xLxCKHxo8kAUv0MtGuwurU5vlydm6P3+DNROh4=; b=l1f6zb6+GSbPTbWj42ElyYGLAOZKQx2M9xqWd+ieBlHSzmFo3aXx/ZqXctiDFGskM+Ez1H xMTSUcOwgdMAuos1ERIEoYjZM1SQOPXUIIvLX/aj9mBM7HnK2fAWTnW1o/H64SKZm2ss9p nSJEQLe/EZafTHiTY4mtYE/7AD988/9Pq2WqCS+JCsAZ6/+cHA90jLevilumLWZ2eIO2k5 YNtg7YfcjKbkn+TI4+b5vl/aXFW1VieMOVMPXO2EoAfR0vQYBqLNoNgEfhEKuXGuevdC3Q hHRHJ+/DEkh3h/2aMzgtW4wty+JV2YHauQvA6S4ZgF3WH8OWUITMpxm79SyTCQ== Date: Fri, 20 May 2022 14:37:26 +0200 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support Message-ID: <20220520143726.6dd324fb@bootlin.com> In-Reply-To: <2945e445-3453-a45f-7d3d-3b07bf350b47@linaro.org> References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-4-herve.codina@bootlin.com> <2945e445-3453-a45f-7d3d-3b07bf350b47@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_053733_141392_ED9F3C02 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Thomas Petazzoni , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, Horatiu Vultur , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLCBTZXJnZWkKCk9uIEZyaSwgMTMgTWF5IDIwMjIgMTQ6NTQ6MjYgKzAyMDAK S3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiB3cm90 ZToKCj4gT24gMTMvMDUvMjAyMiAxMjo1OCwgSGVydmUgQ29kaW5hIHdyb3RlOgo+ID4gQWRkIFVE UEhTICh0aGUgVVNCIEhpZ2ggU3BlZWQgRGV2aWNlIFBvcnQgY29udHJvbGxlcikgc3VwcG9ydC4K PiA+IFRoZSBVRFBIUyBJUCBwcmVzZW50IGluIHRoZSBsYW45NjZ4IFNPQyBpcyB0aGUgc2FtZSBh cyB0aGUgb25lCj4gPiBwcmVzZW50IGluIHRoZSBTQU1BNUQzIFNPQwo+ID4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBIZXJ2ZSBDb2RpbmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4KPiA+IC0tLQo+ ID4gIGFyY2gvYXJtL2Jvb3QvZHRzL2xhbjk2NnguZHRzaSB8IDExICsrKysrKysrKysrCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL2xhbjk2NnguZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL2xhbjk2Nngu ZHRzaQo+ID4gaW5kZXggN2QyODY5NjQ4MDUwLi40YzA5ZjMxNjZkMjcgMTAwNjQ0Cj4gPiAtLS0g YS9hcmNoL2FybS9ib290L2R0cy9sYW45NjZ4LmR0c2kKPiA+ICsrKyBiL2FyY2gvYXJtL2Jvb3Qv ZHRzL2xhbjk2NnguZHRzaQo+ID4gQEAgLTIxMSw2ICsyMTEsMTcgQEAgY2FuMDogY2FuQGUwODFj MDAwIHsKPiA+ICAJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4gIAkJfTsKPiA+ICAKPiA+ICsJ CXVkYzogdWRwaHNAZTA4MDgwMDAgeyAgCj4gCj4gR2VuZXJpYyBub2RlIG5hbWVzLCBzbyBpdCBs b29rcyBsaWtlIHVzYi4gRm9yIGV4YW1wbGUgSENEIHNjaGVtYQo+IHJlcXVpcmVzIGl0LiBJIGFt IG5vdCBzdXJlIHdoaWNoIGJpbmRpbmdzIGFyZSB1c2VkIGhlcmUsIGJ1dCBhbnl3YXkgb25jZQo+ IHRoZXkgbWlnaHQgcmVxdWlyZSB1c2IuLi4KPiAKCkhDRCBhcmUgcmVsYXRlZCB0byB0aGUgSG9z dCBjb250cm9sbGVyLgpIZXJlIHdlIGFyZSB0YWxraW5nIGFib3V0IGEgZGV2aWNlLgoKSW4gZXhp c3RpbmcgYmluZGluZ3MgcmVsYXRlZCB0byBVU0IgZGV2aWNlIChvciBPVEcgYXMgYW4gT1RHIGNh biBiZSBhCmhvc3Qgb3IgYSBkZXZpY2UpIG9uIHNldmVyYWwgU09Dcywgd2UgY2FuIGZpbmQ6Ci0g dXNiMTogZ2FkZ2V0QGZmZmE0MDAwCi0gdXNiX290ZzogdXNiQDFjMTMwMDAKLSB1c2I6IHVzYkA0 NzQwMDAwMAotIHVkYzogdXNiQDEzMDQwMDAwCi0gdXNiX290Z19oczogdXNiX290Z19oc0A0YTBh YjAwMAoKClNvIEkgd2lsbCBjaGFuZ2UgdG8KICB1ZGM6IHVzYkBlMDgwODAwMAoKSXMgdGhhdCBv ayBmb3IgeW91ID8KClJlZ2FyZHMsCkhlcnZlCgotLSAKSGVydsOpIENvZGluYSwgQm9vdGxpbgpF bWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK