From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA31C433EF for ; Fri, 20 May 2022 13:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236247AbiETNCw (ORCPT ); Fri, 20 May 2022 09:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbiETNCw (ORCPT ); Fri, 20 May 2022 09:02:52 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3FD91053C9; Fri, 20 May 2022 06:02:49 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59257100012; Fri, 20 May 2022 13:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653051768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sM+OQWMMenMdJO9VR7JqvfPNJ36dVqv2du9IbwKv91Y=; b=GYqkhhX9Ravj9OLkpyMQwENtAgyIVKU1s2TSxcGELOwbbLIgP1KvDYQgmETc6+ntlED7F2 Gwk6Lmfpx7++EE+pMxjdgZY6PIOUe4cEgCiWEM18wnF8dJnZbzb+eGlwTmk/ofyZwHEgzD twsN10wNEhd9HJFh3UBM2m1JE89kf61LlRBYXGDvzqcKDczAlcpSBSH7rKok5MzRo3dgpD 7WedWx1CTlj+H3qkGhWC4sXiCcZdRxi0eukArpQDvrd04mT8e6pOI1RNKFVEacoUX/RisY oZvZ42roNURnuYz/BAJ4L2KS9NokcxmLAYRRpZWuYmNN2INs39YX6JUJXQYalQ== Date: Fri, 20 May 2022 15:02:43 +0200 From: Herve Codina To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Michael Turquette , Stephen Boyd , Horatiu Vultur , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520150243.625723fa@bootlin.com> In-Reply-To: <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski wrote: > On 20/05/2022 14:21, Herve Codina wrote: > >>> I think it makes sense to keep 'microchip,lan966x-udc' for the USB > >>> device controller (same controller on LAN9662 and LAN9668) and so > >>> keeping the same rules as for other common parts. =20 > >> > >> Having wildcard was rather a mistake and we already started correcting > >> it, so keeping the "mistake" neither gives you consistency, nor > >> correctness... > >> =20 > >=20 > > I think that the "family" compatible should be present. > > This one allows to define the common parts in the common > > .dtsi file (lan966x.dtsi in our case). > >=20 > > What do you think about: > > - microchip,lan9662-udc > > - microchip,lan9668-udc > > - microchip,lan966-udc <-- Family > >=20 > > lan966 is defined as the family compatible string since (1) in > > bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst > > =20 >=20 > You can add some family compatible, if it makes sense. I don't get why > do you mention it - we did not discuss family names, but using > wildcards... Just please do not add wildcards. Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard". Regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9832C433EF for ; Fri, 20 May 2022 13:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rsE035Mz8+QdGyQNS9z5LWz9hXP6BxphnasVGZ3UwgE=; b=l0rpNBYypYvs0N 6BjmyuIaCpohT9d/CcutDcD/gUO90HvuLUF8SOG+J9cPlj1BNnncSjoxPpj5VBdvzWmf9bmSISET8 lrmaMjIutam6ar6qDST0xK9qNr67ozY/8ToitT+hv9Iz21G96E00uyJqCUjcnRfiybcA7/jL3+M5S B2e+GxRUKEFX+sIhXwMe5uUC92YnN6KELbrAB9IneUbedbzOcjjIhU4gEp6tsbpuqeRNL3afbu2U4 2uLC+KxysNF9lqE6eNegkRKleYtjmvFZfSk3g0kqNw5OURIE1BpdEZzsBW5n0aKsB6AW4Avsav5i+ nBzzZG3nKnbz1zOmAkYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2HO-00CY5A-Dz; Fri, 20 May 2022 13:02:54 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2HL-00CY3j-3w for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 13:02:53 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59257100012; Fri, 20 May 2022 13:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653051768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sM+OQWMMenMdJO9VR7JqvfPNJ36dVqv2du9IbwKv91Y=; b=GYqkhhX9Ravj9OLkpyMQwENtAgyIVKU1s2TSxcGELOwbbLIgP1KvDYQgmETc6+ntlED7F2 Gwk6Lmfpx7++EE+pMxjdgZY6PIOUe4cEgCiWEM18wnF8dJnZbzb+eGlwTmk/ofyZwHEgzD twsN10wNEhd9HJFh3UBM2m1JE89kf61LlRBYXGDvzqcKDczAlcpSBSH7rKok5MzRo3dgpD 7WedWx1CTlj+H3qkGhWC4sXiCcZdRxi0eukArpQDvrd04mT8e6pOI1RNKFVEacoUX/RisY oZvZ42roNURnuYz/BAJ4L2KS9NokcxmLAYRRpZWuYmNN2INs39YX6JUJXQYalQ== Date: Fri, 20 May 2022 15:02:43 +0200 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520150243.625723fa@bootlin.com> In-Reply-To: <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_060251_393517_2C1FA90A X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Thomas Petazzoni , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, Horatiu Vultur , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMCBNYXkgMjAyMiAxNDo1MDoyNCArMDIwMApLcnp5c3p0b2YgS296bG93c2tpIDxr cnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBPbiAyMC8wNS8yMDIyIDE0 OjIxLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPj4+IEkgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8g a2VlcCAnbWljcm9jaGlwLGxhbjk2NngtdWRjJyBmb3IgdGhlIFVTQgo+ID4+PiBkZXZpY2UgY29u dHJvbGxlciAoc2FtZSBjb250cm9sbGVyIG9uIExBTjk2NjIgYW5kIExBTjk2NjgpIGFuZCBzbwo+ ID4+PiBrZWVwaW5nIHRoZSBzYW1lIHJ1bGVzIGFzIGZvciBvdGhlciBjb21tb24gcGFydHMuICAg IAo+ID4+Cj4gPj4gSGF2aW5nIHdpbGRjYXJkIHdhcyByYXRoZXIgYSBtaXN0YWtlIGFuZCB3ZSBh bHJlYWR5IHN0YXJ0ZWQgY29ycmVjdGluZwo+ID4+IGl0LCBzbyBrZWVwaW5nIHRoZSAibWlzdGFr ZSIgbmVpdGhlciBnaXZlcyB5b3UgY29uc2lzdGVuY3ksIG5vcgo+ID4+IGNvcnJlY3RuZXNzLi4u Cj4gPj4gIAo+ID4gCj4gPiBJIHRoaW5rIHRoYXQgdGhlICJmYW1pbHkiIGNvbXBhdGlibGUgc2hv dWxkIGJlIHByZXNlbnQuCj4gPiBUaGlzIG9uZSBhbGxvd3MgdG8gZGVmaW5lIHRoZSBjb21tb24g cGFydHMgaW4gdGhlIGNvbW1vbgo+ID4gLmR0c2kgZmlsZSAobGFuOTY2eC5kdHNpIGluIG91ciBj YXNlKS4KPiA+IAo+ID4gV2hhdCBkbyB5b3UgdGhpbmsgYWJvdXQ6Cj4gPiAtIG1pY3JvY2hpcCxs YW45NjYyLXVkYwo+ID4gLSBtaWNyb2NoaXAsbGFuOTY2OC11ZGMKPiA+IC0gbWljcm9jaGlwLGxh bjk2Ni11ZGMgIDwtLSBGYW1pbHkKPiA+IAo+ID4gbGFuOTY2IGlzIGRlZmluZWQgYXMgdGhlIGZh bWlseSBjb21wYXRpYmxlIHN0cmluZyBzaW5jZSAoMSkgaW4KPiA+IGJpbmRpbmdzL2FybS9hdG1l bC1hdDkxLnlhbWwgYW5kIGluIERvY3VtZW50YXRpb24vYXJtL21pY3JvY2hpcC5yc3QKPiA+ICAg Cj4gCj4gWW91IGNhbiBhZGQgc29tZSBmYW1pbHkgY29tcGF0aWJsZSwgaWYgaXQgbWFrZXMgc2Vu c2UuIEkgZG9uJ3QgZ2V0IHdoeQo+IGRvIHlvdSBtZW50aW9uIGl0IC0gd2UgZGlkIG5vdCBkaXNj dXNzIGZhbWlseSBuYW1lcywgYnV0IHVzaW5nCj4gd2lsZGNhcmRzLi4uIEp1c3QgcGxlYXNlIGRv IG5vdCBhZGQgd2lsZGNhcmRzLgoKV2VsbCwgSSBtZW50aW9uZWQgaXQgYXMgSSB3aWxsIG9ubHkg dXNlIHRoZSBmYW1pbHkgY29tcGF0aWJsZSBzdHJpbmcKYW5kIG5vdCB0aGUgU09DIChsYW45NjYy IG9yIGxhbjk2NjgpIGNvbXBhdGlibGUgc3RyaW5nIGluIGxhbjk2NnguZHRzaS4KSW4gdGhpcyBj YXNlLCB0aGUgZmFtaWx5IGNvbXBhdGlibGUgc3RyaW5nIGNhbiBiZSBzZWVuIGFzIGEga2luZCBv Zgoid2lsZGNhcmQiLgoKUmVnYXJkcywKSGVydsOpCgotLSAKSGVydsOpIENvZGluYSwgQm9vdGxp bgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5j b20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK