From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A939BC433F5 for ; Fri, 20 May 2022 14:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241237AbiETOM3 (ORCPT ); Fri, 20 May 2022 10:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234377AbiETOM2 (ORCPT ); Fri, 20 May 2022 10:12:28 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E76381271A5; Fri, 20 May 2022 07:12:26 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 176FD100008; Fri, 20 May 2022 14:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653055945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MaQV0rcRl9yju3BQiEVjVqUfjR6zffQamWBXh+IHtho=; b=T1I9QydTzzgBi3C/MLXC5ctI80aDQxh39c7tD4yw7kBo1kQgcR8zFJOs4rO5TmLCDkoVrl BeYlBXUXcDFOY/DSA6KnjZH/3v7aFq+O4ryT8AOU6kCFDk48+qKtIZh5vDNZCFbMydakf7 g8HFzQ9c9eQQ+xIdLcj6IHmOmObocR3OeHO+Nk59Y7H156wJjPefrwQsYypFHvB9uLohuG 49G0r5hUELpkt6P2LuJSGFxtUy3HtYn2Lg+KVEU2fiZkdIXfDlrDSQhJWJqjya1luTXEdv RWvYOkBrduLtm1JmPtHMgBCKTqEHb5EwqWlXPr69NjpHB/OdYbQV6+1DJv/txg== Date: Fri, 20 May 2022 16:12:22 +0200 From: Herve Codina To: Alexandre Belloni Cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Nicolas Ferre , Claudiu Beznea , Michael Turquette , Stephen Boyd , Horatiu Vultur , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520161222.71fc3a75@bootlin.com> In-Reply-To: References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> <20220520150243.625723fa@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Alexandre, On Fri, 20 May 2022 15:52:22 +0200 Alexandre Belloni wrote: > Hello, >=20 > On 20/05/2022 15:38:36+0200, Krzysztof Kozlowski wrote: > > On 20/05/2022 15:02, Herve Codina wrote: =20 > > > On Fri, 20 May 2022 14:50:24 +0200 > > > Krzysztof Kozlowski wrote: > > > =20 > > >> On 20/05/2022 14:21, Herve Codina wrote: =20 > > >>>>> I think it makes sense to keep 'microchip,lan966x-udc' for the USB > > >>>>> device controller (same controller on LAN9662 and LAN9668) and so > > >>>>> keeping the same rules as for other common parts. =20 > > >>>> > > >>>> Having wildcard was rather a mistake and we already started correc= ting > > >>>> it, so keeping the "mistake" neither gives you consistency, nor > > >>>> correctness... > > >>>> =20 > > >>> > > >>> I think that the "family" compatible should be present. > > >>> This one allows to define the common parts in the common > > >>> .dtsi file (lan966x.dtsi in our case). > > >>> > > >>> What do you think about: > > >>> - microchip,lan9662-udc > > >>> - microchip,lan9668-udc > > >>> - microchip,lan966-udc <-- Family > > >>> > > >>> lan966 is defined as the family compatible string since (1) in > > >>> bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst > > >>> =20 > > >> > > >> You can add some family compatible, if it makes sense. I don't get w= hy > > >> do you mention it - we did not discuss family names, but using > > >> wildcards... Just please do not add wildcards. =20 > > >=20 > > > Well, I mentioned it as I will only use the family compatible string > > > and not the SOC (lan9662 or lan9668) compatible string in lan966x.dts= i. > > > In this case, the family compatible string can be seen as a kind of > > > "wildcard". =20 > >=20 > > I understood as "the "family" compatible should be present" as you want > > to add it as a fallback. It would be okay (assuming devices indeed share > > family design). If you want to use it as the only one, then it is again > > not a recommended approach. Please use specific compatibles. > >=20 > > I mean, why do we have this discussion? What is the benefit for you to > > implement something not-recommended by Devicetree spec and style? > > =20 >=20 > Honestly, I would just go for microchip,lan9662-udc. There is no > difference between lan9662 and lan9668 apart from the number of switch > ports. >=20 Sounds good. I will do that. Thanks, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09BD0C433F5 for ; Fri, 20 May 2022 14:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tFX5w8BCk4AJUoqhIcjhZb3Wvi8CQRZrC+fZZaY3xN4=; b=uV3Bc4eXLDZFCs /Fu68zpOOekexDDW5ySMFWyoKcb8UIOjowERmICopa98UpV0M/qoFecUyfueF8Laze31w1KrF/VT4 u2kjqMBKXQlqnhPM8VM30uV+Ovf4sDnvOdUZgiS6rwQm4RgICVT5B32rppwFdkhAWCa0Ir/hIwVVv n3LTdonyFfqcV1v0JHzrEuxkAv2HmTZKu+c5QfoGGgNwTjBwRyjEJ8K457HuUcGa7CCsAG/inkUe1 ankc2bmAdb6AgQa5+ftOzwCF+5QktMHLJAxllnOSWYhbeiEFn+PzJZpIfiI8/xKOcSvrvTuA7v+6C g3TCcx/9i0ZcYF5rc+bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns3Mo-00Cqj7-IU; Fri, 20 May 2022 14:12:34 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns3Mk-00CqhD-MD for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 14:12:32 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 176FD100008; Fri, 20 May 2022 14:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653055945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MaQV0rcRl9yju3BQiEVjVqUfjR6zffQamWBXh+IHtho=; b=T1I9QydTzzgBi3C/MLXC5ctI80aDQxh39c7tD4yw7kBo1kQgcR8zFJOs4rO5TmLCDkoVrl BeYlBXUXcDFOY/DSA6KnjZH/3v7aFq+O4ryT8AOU6kCFDk48+qKtIZh5vDNZCFbMydakf7 g8HFzQ9c9eQQ+xIdLcj6IHmOmObocR3OeHO+Nk59Y7H156wJjPefrwQsYypFHvB9uLohuG 49G0r5hUELpkt6P2LuJSGFxtUy3HtYn2Lg+KVEU2fiZkdIXfDlrDSQhJWJqjya1luTXEdv RWvYOkBrduLtm1JmPtHMgBCKTqEHb5EwqWlXPr69NjpHB/OdYbQV6+1DJv/txg== Date: Fri, 20 May 2022 16:12:22 +0200 From: Herve Codina To: Alexandre Belloni Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Message-ID: <20220520161222.71fc3a75@bootlin.com> In-Reply-To: References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> <20220520150243.625723fa@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_071231_078360_D7CC0021 X-CRM114-Status: GOOD ( 28.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, Horatiu Vultur , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQWxleGFuZHJlLAoKT24gRnJpLCAyMCBNYXkgMjAyMiAxNTo1MjoyMiArMDIwMApBbGV4YW5k cmUgQmVsbG9uaSA8YWxleGFuZHJlLmJlbGxvbmlAYm9vdGxpbi5jb20+IHdyb3RlOgoKPiBIZWxs bywKPiAKPiBPbiAyMC8wNS8yMDIyIDE1OjM4OjM2KzAyMDAsIEtyenlzenRvZiBLb3psb3dza2kg d3JvdGU6Cj4gPiBPbiAyMC8wNS8yMDIyIDE1OjAyLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6ICAKPiA+ ID4gT24gRnJpLCAyMCBNYXkgMjAyMiAxNDo1MDoyNCArMDIwMAo+ID4gPiBLcnp5c3p0b2YgS296 bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4gPiAgIAo+ ID4gPj4gT24gMjAvMDUvMjAyMiAxNDoyMSwgSGVydmUgQ29kaW5hIHdyb3RlOiAgCj4gPiA+Pj4+ PiBJIHRoaW5rIGl0IG1ha2VzIHNlbnNlIHRvIGtlZXAgJ21pY3JvY2hpcCxsYW45NjZ4LXVkYycg Zm9yIHRoZSBVU0IKPiA+ID4+Pj4+IGRldmljZSBjb250cm9sbGVyIChzYW1lIGNvbnRyb2xsZXIg b24gTEFOOTY2MiBhbmQgTEFOOTY2OCkgYW5kIHNvCj4gPiA+Pj4+PiBrZWVwaW5nIHRoZSBzYW1l IHJ1bGVzIGFzIGZvciBvdGhlciBjb21tb24gcGFydHMuICAgICAgCj4gPiA+Pj4+Cj4gPiA+Pj4+ IEhhdmluZyB3aWxkY2FyZCB3YXMgcmF0aGVyIGEgbWlzdGFrZSBhbmQgd2UgYWxyZWFkeSBzdGFy dGVkIGNvcnJlY3RpbmcKPiA+ID4+Pj4gaXQsIHNvIGtlZXBpbmcgdGhlICJtaXN0YWtlIiBuZWl0 aGVyIGdpdmVzIHlvdSBjb25zaXN0ZW5jeSwgbm9yCj4gPiA+Pj4+IGNvcnJlY3RuZXNzLi4uCj4g PiA+Pj4+ICAgIAo+ID4gPj4+Cj4gPiA+Pj4gSSB0aGluayB0aGF0IHRoZSAiZmFtaWx5IiBjb21w YXRpYmxlIHNob3VsZCBiZSBwcmVzZW50Lgo+ID4gPj4+IFRoaXMgb25lIGFsbG93cyB0byBkZWZp bmUgdGhlIGNvbW1vbiBwYXJ0cyBpbiB0aGUgY29tbW9uCj4gPiA+Pj4gLmR0c2kgZmlsZSAobGFu OTY2eC5kdHNpIGluIG91ciBjYXNlKS4KPiA+ID4+Pgo+ID4gPj4+IFdoYXQgZG8geW91IHRoaW5r IGFib3V0Ogo+ID4gPj4+IC0gbWljcm9jaGlwLGxhbjk2NjItdWRjCj4gPiA+Pj4gLSBtaWNyb2No aXAsbGFuOTY2OC11ZGMKPiA+ID4+PiAtIG1pY3JvY2hpcCxsYW45NjYtdWRjICA8LS0gRmFtaWx5 Cj4gPiA+Pj4KPiA+ID4+PiBsYW45NjYgaXMgZGVmaW5lZCBhcyB0aGUgZmFtaWx5IGNvbXBhdGli bGUgc3RyaW5nIHNpbmNlICgxKSBpbgo+ID4gPj4+IGJpbmRpbmdzL2FybS9hdG1lbC1hdDkxLnlh bWwgYW5kIGluIERvY3VtZW50YXRpb24vYXJtL21pY3JvY2hpcC5yc3QKPiA+ID4+PiAgICAgCj4g PiA+Pgo+ID4gPj4gWW91IGNhbiBhZGQgc29tZSBmYW1pbHkgY29tcGF0aWJsZSwgaWYgaXQgbWFr ZXMgc2Vuc2UuIEkgZG9uJ3QgZ2V0IHdoeQo+ID4gPj4gZG8geW91IG1lbnRpb24gaXQgLSB3ZSBk aWQgbm90IGRpc2N1c3MgZmFtaWx5IG5hbWVzLCBidXQgdXNpbmcKPiA+ID4+IHdpbGRjYXJkcy4u LiBKdXN0IHBsZWFzZSBkbyBub3QgYWRkIHdpbGRjYXJkcy4gIAo+ID4gPiAKPiA+ID4gV2VsbCwg SSBtZW50aW9uZWQgaXQgYXMgSSB3aWxsIG9ubHkgdXNlIHRoZSBmYW1pbHkgY29tcGF0aWJsZSBz dHJpbmcKPiA+ID4gYW5kIG5vdCB0aGUgU09DIChsYW45NjYyIG9yIGxhbjk2NjgpIGNvbXBhdGli bGUgc3RyaW5nIGluIGxhbjk2NnguZHRzaS4KPiA+ID4gSW4gdGhpcyBjYXNlLCB0aGUgZmFtaWx5 IGNvbXBhdGlibGUgc3RyaW5nIGNhbiBiZSBzZWVuIGFzIGEga2luZCBvZgo+ID4gPiAid2lsZGNh cmQiLiAgCj4gPiAKPiA+IEkgdW5kZXJzdG9vZCBhcyAidGhlICJmYW1pbHkiIGNvbXBhdGlibGUg c2hvdWxkIGJlIHByZXNlbnQiIGFzIHlvdSB3YW50Cj4gPiB0byBhZGQgaXQgYXMgYSBmYWxsYmFj ay4gSXQgd291bGQgYmUgb2theSAoYXNzdW1pbmcgZGV2aWNlcyBpbmRlZWQgc2hhcmUKPiA+IGZh bWlseSBkZXNpZ24pLiBJZiB5b3Ugd2FudCB0byB1c2UgaXQgYXMgdGhlIG9ubHkgb25lLCB0aGVu IGl0IGlzIGFnYWluCj4gPiBub3QgYSByZWNvbW1lbmRlZCBhcHByb2FjaC4gUGxlYXNlIHVzZSBz cGVjaWZpYyBjb21wYXRpYmxlcy4KPiA+IAo+ID4gSSBtZWFuLCB3aHkgZG8gd2UgaGF2ZSB0aGlz IGRpc2N1c3Npb24/IFdoYXQgaXMgdGhlIGJlbmVmaXQgZm9yIHlvdSB0bwo+ID4gaW1wbGVtZW50 IHNvbWV0aGluZyBub3QtcmVjb21tZW5kZWQgYnkgRGV2aWNldHJlZSBzcGVjIGFuZCBzdHlsZT8K PiA+ICAgCj4gCj4gSG9uZXN0bHksIEkgd291bGQganVzdCBnbyBmb3IgbWljcm9jaGlwLGxhbjk2 NjItdWRjLiBUaGVyZSBpcyBubwo+IGRpZmZlcmVuY2UgYmV0d2VlbiBsYW45NjYyIGFuZCBsYW45 NjY4IGFwYXJ0IGZyb20gdGhlIG51bWJlciBvZiBzd2l0Y2gKPiBwb3J0cy4KPiAKClNvdW5kcyBn b29kLgpJIHdpbGwgZG8gdGhhdC4KClRoYW5rcywKSGVydsOpCgotLSAKSGVydsOpIENvZGluYSwg Qm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9v dGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK