From: Jakub Kicinski <kuba@kernel.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Ziyang Xuan <william.xuanziyang@huawei.com>,
chandrashekar.devegowda@intel.com, linuxwwan@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com,
ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: wwan: t7xx: fix GFP_KERNEL usage in spin_lock context
Date: Fri, 20 May 2022 17:25:56 -0700 [thread overview]
Message-ID: <20220520172556.1d62b899@kernel.org> (raw)
In-Reply-To: <CAMZdPi9z=OM0=yZbBu0eDvFd30efNpt3qmDHuCTj6LGJxdBTbw@mail.gmail.com>
On Thu, 19 May 2022 09:29:12 +0200 Loic Poulain wrote:
> On Thu, 19 May 2022 at 09:26, Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> >
> > t7xx_cldma_clear_rxq() call t7xx_cldma_alloc_and_map_skb() in spin_lock
> > context, But __dev_alloc_skb() in t7xx_cldma_alloc_and_map_skb() uses
> > GFP_KERNEL, that will introduce scheduling factor in spin_lock context.
> >
> > Because t7xx_cldma_clear_rxq() is called after stopping CLDMA, so we can
> > remove the spin_lock from t7xx_cldma_clear_rxq().
> >
> > Fixes: 39d439047f1d ("net: wwan: t7xx: Add control DMA interface")
> > Suggested-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>
> > Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Wait, you reviewed two different fixes for the same issue?
Please say something when that happens I thought both are needed :/
next prev parent reply other threads:[~2022-05-21 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:43 [PATCH net-next v3] net: wwan: t7xx: fix GFP_KERNEL usage in spin_lock context Ziyang Xuan
2022-05-19 7:29 ` Loic Poulain
2022-05-21 0:25 ` Jakub Kicinski [this message]
2022-05-21 1:01 ` Jakub Kicinski
2022-05-21 17:26 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520172556.1d62b899@kernel.org \
--to=kuba@kernel.org \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.