From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>,
Xin Long <lucien.xin@gmail.com>,
Vadim Fedorenko <vfedorenko@novek.ru>,
"David S. Miller" <davem@davemloft.net>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/6] rxrpc: Enable IPv6 checksums on transport socket
Date: Fri, 20 May 2022 18:15:22 -0700 [thread overview]
Message-ID: <20220520181522.42630ce9@kernel.org> (raw)
In-Reply-To: <165306442878.34086.2437731947506679099.stgit@warthog.procyon.org.uk>
On Fri, 20 May 2022 17:33:48 +0100 David Howells wrote:
> AF_RXRPC doesn't currently enable IPv6 UDP Tx checksums on the transport
> socket it opens and the checksums in the packets it generates end up 0.
>
> It probably should also enable IPv6 UDP Rx checksums and IPv4 UDP
> checksums. The latter only seem to be applied if the socket family is
> AF_INET and don't seem to apply if it's AF_INET6. IPv4 packets from an
> IPv6 socket seem to have checksums anyway.
>
> What seems to have happened is that the inet_inv_convert_csum() call didn't
> get converted to the appropriate udp_port_cfg parameters - and
> udp_sock_create() disables checksums unless explicitly told not too.
>
> Fix this by enabling the three udp_port_cfg checksum options.
>
> Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
> Reported-by: Marc Dionne <marc.dionne@auristor.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Reviewed-by: Xin Long <lucien.xin@gmail.com>
> Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
This is already in net..
pw build got gave up on this series.
Could you resend just the other 5 patches?
next prev parent reply other threads:[~2022-05-21 1:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 16:33 [PATCH net 0/6] rxrpc: Leak fixes David Howells
2022-05-20 16:33 ` [PATCH net 1/6] rxrpc: Enable IPv6 checksums on transport socket David Howells
2022-05-21 1:15 ` Jakub Kicinski [this message]
2022-05-21 7:27 ` David Howells
2022-05-20 16:33 ` [PATCH net 2/6] rxrpc: Fix listen() setting the bar too high for the prealloc rings David Howells
2022-05-20 16:34 ` [PATCH net 3/6] rxrpc: Don't try to resend the request if we're receiving the reply David Howells
2022-05-20 16:34 ` [PATCH net 4/6] rxrpc: Fix overlapping ACK accounting David Howells
2022-05-20 16:34 ` [PATCH net 5/6] rxrpc: Don't let ack.previousPacket regress David Howells
2022-05-20 16:34 ` [PATCH net 6/6] rxrpc: Fix decision on when to generate an IDLE ACK David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520181522.42630ce9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.