From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Fri, 20 May 2022 19:58:48 +0000 Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-Id: <20220520195848.GY2578@worktop.programming.kicks-ass.net> List-Id: References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> <87wnegyp87.fsf@email.froward.int.ebiederm.org> In-Reply-To: <87wnegyp87.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: "Eric W. Biederman" Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras On Fri, May 20, 2022 at 02:32:24PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > >> > >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > >> ptrace_freeze_traced has completed successfully. Which fundamentally > >> means the lock dance of dropping siglock and grabbing tasklist_lock does > >> not work on PREEMPT_RT. So I have worked through what is necessary so > >> that tasklist_lock does not need to be grabbed in ptrace_stop after > >> siglock is dropped. > > … > > It took me a while to realise that this is a follow-up I somehow assumed > > that you added a few patches on top. Might have been the yesterday's > > heat. b4 also refused to download this series because the v4 in this > > thread looked newer… Anyway. Both series applied: > > > > | ==============> > | WARNING: suspicious RCU usage > > | 5.18.0-rc7+ #16 Not tainted > > | ----------------------------- > > | include/linux/ptrace.h:120 suspicious rcu_dereference_check() usage! > > | > > | other info that might help us debug this: > > | > > | rcu_scheduler_active = 2, debug_locks = 1 > > | 2 locks held by ssdd/1734: > > | #0: ffff88800eaa6918 (&sighand->siglock){....}-{2:2}, at: lock_parents_siglocks+0xf0/0x3b0 > > | #1: ffff88800eaa71d8 (&sighand->siglock/2){....}-{2:2}, at: lock_parents_siglocks+0x115/0x3b0 > > | > > | stack backtrace: > > | CPU: 2 PID: 1734 Comm: ssdd Not tainted 5.18.0-rc7+ #16 > > | Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 > > | Call Trace: > > | > > | dump_stack_lvl+0x45/0x5a > > | unlock_parents_siglocks+0xb6/0xc0 > > | ptrace_stop+0xb9/0x390 > > | get_signal+0x51c/0x8d0 > > | arch_do_signal_or_restart+0x31/0x750 > > | exit_to_user_mode_prepare+0x157/0x220 > > | irqentry_exit_to_user_mode+0x5/0x50 > > | asm_sysvec_apic_timer_interrupt+0x12/0x20 > > > > That is ptrace_parent() in unlock_parents_siglocks(). > > How odd. I thought I had the appropriate lockdep config options enabled > in my test build to catch things like this. I guess not. > > Now I am trying to think how to tell it that holding the appropriate > iglock makes this ok. The typical annotation is something like: rcu_dereference_protected(foo, lockdep_is_held(&bar)) Except in this case I think the problem is that bar depends on foo in non-trivial ways. That is, foo is 'task->parent' and bar is 'task->parent->sighand->siglock' or something. The other option is to use rcu_dereference_raw() in this one instance and have a comment that explains the situation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC6AC433F5 for ; Fri, 20 May 2022 19:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242974AbiETT7w (ORCPT ); Fri, 20 May 2022 15:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236170AbiETT7v (ORCPT ); Fri, 20 May 2022 15:59:51 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F96319C39F; Fri, 20 May 2022 12:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=BKP5a5pHHBYXwyuiYqA00KUXwchZ92uDPjXicGU1+N4=; b=f3i3OO4NtAt4RShav01WKmUiP+ 599WE/SJ21kBjnzJesrvpTcA+dh6R3VaK0B5Qid5F817Vt30vklE58KbJef4mZ2dtOa8xUNUYZF8Z NrZNbvX/S+Hr+7EkhtRTVmLRYa5ssrGbzgrvWMl/2I+/8LLWLsQ6Tukep0XyzL0QX0v9ZaevzZr9i H0fxG+hX221jPI8Jj/owdXD5vy72TVl0IyF2r+St0wXN52t5fBL7jajkFEkkLa9drGkA4sMsL6xG1 ROdDN77gZUweIL3el5tIWIk5t3pRaeQjP8N7Zv+ce5IkvIbtebaz/bFnHaBN8fH9XzF3JlVv9v6yX EyHktMqg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns8lu-00E5EI-Jc; Fri, 20 May 2022 19:58:50 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id D2737981243; Fri, 20 May 2022 21:58:48 +0200 (CEST) Date: Fri, 20 May 2022 21:58:48 +0200 From: Peter Zijlstra To: "Eric W. Biederman" Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-ID: <20220520195848.GY2578@worktop.programming.kicks-ass.net> References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> <87wnegyp87.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wnegyp87.fsf@email.froward.int.ebiederm.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, May 20, 2022 at 02:32:24PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > >> > >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > >> ptrace_freeze_traced has completed successfully. Which fundamentally > >> means the lock dance of dropping siglock and grabbing tasklist_lock does > >> not work on PREEMPT_RT. So I have worked through what is necessary so > >> that tasklist_lock does not need to be grabbed in ptrace_stop after > >> siglock is dropped. > > … > > It took me a while to realise that this is a follow-up I somehow assumed > > that you added a few patches on top. Might have been the yesterday's > > heat. b4 also refused to download this series because the v4 in this > > thread looked newer… Anyway. Both series applied: > > > > | ============================= > > | WARNING: suspicious RCU usage > > | 5.18.0-rc7+ #16 Not tainted > > | ----------------------------- > > | include/linux/ptrace.h:120 suspicious rcu_dereference_check() usage! > > | > > | other info that might help us debug this: > > | > > | rcu_scheduler_active = 2, debug_locks = 1 > > | 2 locks held by ssdd/1734: > > | #0: ffff88800eaa6918 (&sighand->siglock){....}-{2:2}, at: lock_parents_siglocks+0xf0/0x3b0 > > | #1: ffff88800eaa71d8 (&sighand->siglock/2){....}-{2:2}, at: lock_parents_siglocks+0x115/0x3b0 > > | > > | stack backtrace: > > | CPU: 2 PID: 1734 Comm: ssdd Not tainted 5.18.0-rc7+ #16 > > | Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 > > | Call Trace: > > | > > | dump_stack_lvl+0x45/0x5a > > | unlock_parents_siglocks+0xb6/0xc0 > > | ptrace_stop+0xb9/0x390 > > | get_signal+0x51c/0x8d0 > > | arch_do_signal_or_restart+0x31/0x750 > > | exit_to_user_mode_prepare+0x157/0x220 > > | irqentry_exit_to_user_mode+0x5/0x50 > > | asm_sysvec_apic_timer_interrupt+0x12/0x20 > > > > That is ptrace_parent() in unlock_parents_siglocks(). > > How odd. I thought I had the appropriate lockdep config options enabled > in my test build to catch things like this. I guess not. > > Now I am trying to think how to tell it that holding the appropriate > iglock makes this ok. The typical annotation is something like: rcu_dereference_protected(foo, lockdep_is_held(&bar)) Except in this case I think the problem is that bar depends on foo in non-trivial ways. That is, foo is 'task->parent' and bar is 'task->parent->sighand->siglock' or something. The other option is to use rcu_dereference_raw() in this one instance and have a comment that explains the situation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 20 May 2022 21:58:48 +0200 From: Peter Zijlstra Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-ID: <20220520195848.GY2578@worktop.programming.kicks-ass.net> References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> <87wnegyp87.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wnegyp87.fsf@email.froward.int.ebiederm.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Eric W. Biederman" Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras T24gRnJpLCBNYXkgMjAsIDIwMjIgYXQgMDI6MzI6MjRQTSAtMDUwMCwgRXJpYyBXLiBCaWVkZXJt YW4gd3JvdGU6Cj4gU2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4 LmRlPiB3cml0ZXM6Cj4gCj4gPiBPbiAyMDIyLTA1LTE4IDE3OjQ5OjUwIFstMDUwMF0sIEVyaWMg Vy4gQmllZGVybWFuIHdyb3RlOgo+ID4+IAo+ID4+IEZvciBwdHJhY2Vfc3RvcCB0byB3b3JrIG9u IFBSRUVNVF9SVCBubyBzcGlubG9ja3MgY2FuIGJlIHRha2VuIG9uY2UKPiA+PiBwdHJhY2VfZnJl ZXplX3RyYWNlZCBoYXMgY29tcGxldGVkIHN1Y2Nlc3NmdWxseS4gIFdoaWNoIGZ1bmRhbWVudGFs bHkKPiA+PiBtZWFucyB0aGUgbG9jayBkYW5jZSBvZiBkcm9wcGluZyBzaWdsb2NrIGFuZCBncmFi YmluZyB0YXNrbGlzdF9sb2NrIGRvZXMKPiA+PiBub3Qgd29yayBvbiBQUkVFTVBUX1JULiAgU28g SSBoYXZlIHdvcmtlZCB0aHJvdWdoIHdoYXQgaXMgbmVjZXNzYXJ5IHNvCj4gPj4gdGhhdCB0YXNr bGlzdF9sb2NrIGRvZXMgbm90IG5lZWQgdG8gYmUgZ3JhYmJlZCBpbiBwdHJhY2Vfc3RvcCBhZnRl cgo+ID4+IHNpZ2xvY2sgaXMgZHJvcHBlZC4KPiA+IOKApgo+ID4gSXQgdG9vayBtZSBhIHdoaWxl IHRvIHJlYWxpc2UgdGhhdCB0aGlzIGlzIGEgZm9sbG93LXVwIEkgc29tZWhvdyBhc3N1bWVkCj4g PiB0aGF0IHlvdSBhZGRlZCBhIGZldyBwYXRjaGVzIG9uIHRvcC4gTWlnaHQgaGF2ZSBiZWVuIHRo ZSB5ZXN0ZXJkYXkncwo+ID4gaGVhdC4gYjQgYWxzbyByZWZ1c2VkIHRvIGRvd25sb2FkIHRoaXMg c2VyaWVzIGJlY2F1c2UgdGhlIHY0IGluIHRoaXMKPiA+IHRocmVhZCBsb29rZWQgbmV3ZXLigKYg QW55d2F5LiBCb3RoIHNlcmllcyBhcHBsaWVkOgo+ID4KPiA+IHwgPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KPiA+IHwgV0FSTklORzogc3VzcGljaW91cyBSQ1UgdXNhZ2UKPiA+IHwgNS4x OC4wLXJjNysgIzE2IE5vdCB0YWludGVkCj4gPiB8IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPiB8IGluY2x1ZGUvbGludXgvcHRyYWNlLmg6MTIwIHN1c3BpY2lvdXMgcmN1X2RlcmVm ZXJlbmNlX2NoZWNrKCkgdXNhZ2UhCj4gPiB8Cj4gPiB8IG90aGVyIGluZm8gdGhhdCBtaWdodCBo ZWxwIHVzIGRlYnVnIHRoaXM6Cj4gPiB8Cj4gPiB8IHJjdV9zY2hlZHVsZXJfYWN0aXZlID0gMiwg ZGVidWdfbG9ja3MgPSAxCj4gPiB8IDIgbG9ja3MgaGVsZCBieSBzc2RkLzE3MzQ6Cj4gPiB8ICAj MDogZmZmZjg4ODAwZWFhNjkxOCAoJnNpZ2hhbmQtPnNpZ2xvY2spey4uLi59LXsyOjJ9LCBhdDog bG9ja19wYXJlbnRzX3NpZ2xvY2tzKzB4ZjAvMHgzYjAKPiA+IHwgICMxOiBmZmZmODg4MDBlYWE3 MWQ4ICgmc2lnaGFuZC0+c2lnbG9jay8yKXsuLi4ufS17MjoyfSwgYXQ6IGxvY2tfcGFyZW50c19z aWdsb2NrcysweDExNS8weDNiMAo+ID4gfAo+ID4gfCBzdGFjayBiYWNrdHJhY2U6Cj4gPiB8IENQ VTogMiBQSUQ6IDE3MzQgQ29tbTogc3NkZCBOb3QgdGFpbnRlZCA1LjE4LjAtcmM3KyAjMTYKPiA+ IHwgSGFyZHdhcmUgbmFtZTogUUVNVSBTdGFuZGFyZCBQQyAoUTM1ICsgSUNIOSwgMjAwOSksIEJJ T1MgMS4xNi4wLWRlYmlhbi0xLjE2LjAtNCAwNC8wMS8yMDE0Cj4gPiB8IENhbGwgVHJhY2U6Cj4g PiB8ICA8VEFTSz4KPiA+IHwgIGR1bXBfc3RhY2tfbHZsKzB4NDUvMHg1YQo+ID4gfCAgdW5sb2Nr X3BhcmVudHNfc2lnbG9ja3MrMHhiNi8weGMwCj4gPiB8ICBwdHJhY2Vfc3RvcCsweGI5LzB4Mzkw Cj4gPiB8ICBnZXRfc2lnbmFsKzB4NTFjLzB4OGQwCj4gPiB8ICBhcmNoX2RvX3NpZ25hbF9vcl9y ZXN0YXJ0KzB4MzEvMHg3NTAKPiA+IHwgIGV4aXRfdG9fdXNlcl9tb2RlX3ByZXBhcmUrMHgxNTcv MHgyMjAKPiA+IHwgIGlycWVudHJ5X2V4aXRfdG9fdXNlcl9tb2RlKzB4NS8weDUwCj4gPiB8ICBh c21fc3lzdmVjX2FwaWNfdGltZXJfaW50ZXJydXB0KzB4MTIvMHgyMAo+ID4KPiA+IFRoYXQgaXMg cHRyYWNlX3BhcmVudCgpIGluIHVubG9ja19wYXJlbnRzX3NpZ2xvY2tzKCkuCj4gCj4gSG93IG9k ZC4gIEkgdGhvdWdodCBJIGhhZCB0aGUgYXBwcm9wcmlhdGUgbG9ja2RlcCBjb25maWcgb3B0aW9u cyBlbmFibGVkCj4gaW4gbXkgdGVzdCBidWlsZCB0byBjYXRjaCB0aGluZ3MgbGlrZSB0aGlzLiAg SSBndWVzcyBub3QuCj4gCj4gTm93IEkgYW0gdHJ5aW5nIHRvIHRoaW5rIGhvdyB0byB0ZWxsIGl0 IHRoYXQgaG9sZGluZyB0aGUgYXBwcm9wcmlhdGUKPiBpZ2xvY2sgbWFrZXMgdGhpcyBvay4KClRo ZSB0eXBpY2FsIGFubm90YXRpb24gaXMgc29tZXRoaW5nIGxpa2U6CgoJcmN1X2RlcmVmZXJlbmNl X3Byb3RlY3RlZChmb28sIGxvY2tkZXBfaXNfaGVsZCgmYmFyKSkKCkV4Y2VwdCBpbiB0aGlzIGNh c2UgSSB0aGluayB0aGUgcHJvYmxlbSBpcyB0aGF0IGJhciBkZXBlbmRzIG9uIGZvbyBpbgpub24t dHJpdmlhbCB3YXlzLiBUaGF0IGlzLCBmb28gaXMgJ3Rhc2stPnBhcmVudCcgYW5kIGJhciBpcwon dGFzay0+cGFyZW50LT5zaWdoYW5kLT5zaWdsb2NrJyBvciBzb21ldGhpbmcuCgpUaGUgb3RoZXIg b3B0aW9uIGlzIHRvIHVzZSByY3VfZGVyZWZlcmVuY2VfcmF3KCkgaW4gdGhpcyBvbmUgaW5zdGFu Y2UKYW5kIGhhdmUgYSBjb21tZW50IHRoYXQgZXhwbGFpbnMgdGhlIHNpdHVhdGlvbi4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1haWxp bmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K